unreflectWithers fix for double slot args <was> Re: RFR 8183938: [MVT] Add test for mock vector API

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Thu Jul 6 21:19:31 UTC 2017


Looks good - thanks

P.S.

for future references, the bytecode API's TypeTag class also has a 
'width' method that give you the number of slots. In this case, since 
you already have a basic type, what you did is good.

http://hg.openjdk.java.net/valhalla/valhalla/jdk/file/tip/src/java.base/share/classes/jdk/experimental/bytecode/TypeTag.java#l63

Maurizio


On 06/07/17 18:36, Paul Sandoz wrote:
> Here’s a fix:
>
> http://cr.openjdk.java.net/~psandoz/valhalla/unreflect-wither-double-slots/webrev/ 
> <http://cr.openjdk.java.net/%7Epsandoz/valhalla/unreflect-wither-double-slots/webrev/> 
>
>
> Paul.
>
>> On 6 Jul 2017, at 08:03, Paul Sandoz <paul.sandoz at oracle.com 
>> <mailto:paul.sandoz at oracle.com>> wrote:
>>
>> Yes, i will take a look, don’t let this block pushing what you have.
>>
>> Paul.
>>



More information about the valhalla-dev mailing list