unreflectWithers fix for double slot args <was> Re: RFR 8183938: [MVT] Add test for mock vector API

Paul Sandoz paul.sandoz at oracle.com
Thu Jul 6 21:28:39 UTC 2017


> On 6 Jul 2017, at 14:19, Maurizio Cimadamore <maurizio.cimadamore at oracle.com> wrote:
> 
> Looks good - thanks
> 
> P.S.
> 
> for future references, the bytecode API's TypeTag class also has a 'width' method that give you the number of slots. In this case, since you already have a basic type, what you did is good.
> 
> http://hg.openjdk.java.net/valhalla/valhalla/jdk/file/tip/src/java.base/share/classes/jdk/experimental/bytecode/TypeTag.java#l63
> 

Thanks, good to know as i was a little unsure if i took the right approach.

FWIW Wrapper.forBasicType knows nothing of Q types, but in this case it’s harmless.

Paul.


More information about the valhalla-dev mailing list