Crash with "assert(number_of_codes <= 256) failed: too many bytecodes"

[Maurizio Cimadamore]

Whohoo - thanks for looking after my breakages :-)

Maurizio


On 28/07/17 13:56, Tobias Hartmann wrote:
> All tests passed. I've pushed the changes.
>
> With Mandy's fix for 8185148, the repo should be stable again.
>
> Best regards,
> Tobias
>
> On 28.07.2017 11:20, Tobias Hartmann wrote:
>> On 28.07.2017 10:57, Tobias Hartmann wrote:
>>> (2) Oop map generation is broken because there is no way to determine if the _getfield bytecode accesses a value type field.
>>> -> I had to temporarily disable verification. See changes in generateOopMap.cpp/hpp. Checking itr->raw_code() == Bytecodes::_vgetfield is not sufficient and also a constant pool lookup does not work in all cases.
>>> Any ideas on how to fix this?
>> Okay, using the 'CellTypeState::refOrValueType' hack should do the job:
>> http://cr.openjdk.java.net/~thartmann/valhalla/vt_prototype/webrev.36.hs/src/share/vm/oops/generateOopMap.cpp.sdiff.html
>>
>> Best regards,
>> Tobias
>>