RFR: Value Array element size / value store fixes...

David Simms david.simms at oracle.com
Mon Mar 13 07:39:14 UTC 2017

On 10/03/2017 5:19 p.m., Frederic Parain wrote:
> Mr Simms,
> Thank you cleaning up the code related to value type payload handling.
> General comment about coding style: HotSpot coding style recommends
> to put the ‘else’ keyword on same line as the closing bracket of the ‘then’
> block, not on the line below.
> src/share/vm/oops/valueKlass.hpp:
>    line 82: I’d like to have some asserts here to check that the return value
>                 is a valid oop
Can do
> src/share/vm/oops/valueKlass.cpp:
>    line 59 int ValueKlass::raw_value_byte_size()
>           I assume support for object references will be added as part of
>           your next push, right?
> Otherwise, looks good.

Cheers, will adjust. Thanks for pointing out the HS style. I will run 
some 32 bit testing before pushing, seeing Roland found some issues with it.


More information about the valhalla-dev mailing list