RFR 8187696: missing ACC_VALUE in inner class attributes

David Simms david.simms at oracle.com
Tue Oct 10 13:58:13 UTC 2017


Looks good, fixes hotspot jtreg ValueOops test (with verifier on)

Thanks Maurizio !

On 10/10/2017 2:04 p.m., Maurizio Cimadamore wrote:
> Hi,
> this patch fixes a problem with javac not generating ACC_VALUE flag 
> for classes in the InnerClasses attribute. The flag was erroneously 
> masked out in ClassWriter, and also not handled uniformly in the 
> adjustFlags routine (which is used to convert javac internal flags 
> into public ones).
>
> Webrev here:
>
> http://cr.openjdk.java.net/~mcimadamore/8187696/
>
> P.S.
>
> The fix also includes a minor javap fix to display ACC_VALUE correctly 
> inside inner classes attributes.
>
> Cheers
> Maurizio
>



More information about the valhalla-dev mailing list