RFR(L): 8185556: [MVT] C2 compiler support for non-flattened value type fields

Tobias Hartmann tobias.hartmann at oracle.com
Thu Sep 28 15:32:31 UTC 2017

[Just noticed that I removed the alias from the recipients, sorry for that]

On 28.09.2017 17:24, Roland Westrelin wrote:
> But then you reset the control to the control that is before the null
> check?
>   442         Node* ctl = map->control();
>   443         arg = ValueTypeNode::make(gvn, ctl, map->memory(), arg);
>   444         map->set_control(ctl);

No, ctl is passed as *reference* (Node*& ctl) and updated in ValueTypeNode::make() and then the map is updated to use 
the new ctl.

That's what I meant by "please note that it's passed as reference, so it can be updated".

Best regards,

More information about the valhalla-dev mailing list