RFR(L): 8206139: [lworld] Re-enable calling convention optimizations

Tobias Hartmann tobias.hartmann at oracle.com
Mon Dec 17 15:44:46 UTC 2018


On 17.12.18 15:33, Tobias Hartmann wrote:
> I've noticed that with Frederic's fix for 8214138 which removed the value type attribute consistency
> checks, we also stopped throwing a NoClassDefFoundError when a value type argument cannot be
> resolved at link time. The calling convention code expects all value type klasses of the signature
> to be loaded at that time (Method::link_method -> ... -> AdapterHandlerLibrary::get_adapter0)
> assuming that we would have failed already if the class could not be found. I've temporarily fixed
> that by some code in method.cpp:1096.

I've found and fixed the root cause of this:
http://hg.openjdk.java.net/valhalla/valhalla/rev/2843104787a7

I've removed my workaround fix and updated the webrev in-place.

Thanks,
Tobias


More information about the valhalla-dev mailing list