RFR(S): JDK-8211026 jdb should not allow to assign null to value type

Frederic Parain frederic.parain at oracle.com
Wed Oct 16 15:02:31 UTC 2019


Thank you for the review.

So far, the goals of this exercise are:
  1 - to provide a Java debugger that works with inlines
  2 - to explore which areas of the JPDA will be impacted by inline types

I’m not considering any serious update to the JPDA specs (JDI/JDWP/JVMTI)
until the JLS and JVMLS updates for inline types have been almost finalized.
There’re too many dependencies and interactions between all these specs to
try to keep them in synch while the user model and the JVMS are still evolving.



> On Oct 15, 2019, at 18:09, Mandy Chung <mandy.chung at oracle.com> wrote:
> On 10/15/19 2:30 PM, Frederic Parain wrote:
>> Please review this small fix preventing assigning null to a local variable
>> with an inline type.
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8211026
>> Webrev:
>> http://cr.openjdk.java.net/~fparain/jdb_null_assignment/webrev.00/index.html
> It looks okay to me.  Perhaps at some point there should be isNullableType in JDI API.
> Mandy
>> The case of preventing assigning null to an inline field has already been
>> fixed in a previous patch.
>> Thank you,
>> Fred

More information about the valhalla-dev mailing list