Review Request: 8238358: Implementation of JEP 371: Hidden Classes

Mandy Chung mandy.chung at
Wed Apr 1 03:01:10 UTC 2020

Thanks to the review feedbacks.

Updated webrev:
Delta between webrev.03 and webrev.04:

Summary of changes is:
1. Update javac to retain the previous behavior when compiling to target 
release <= 14 where lambda proxy class is not a nestmate
2. Rename Class::isHiddenClass to Class::isHidden
3. Address Joe's feedback on the CSR to document the behavior of the 
relevant methods in java.lang.Class for hidden classes
4. Add test case for unloadable class with nest host error
5. Add test cases for hidden classes with different kinds of class or 
6. Update dcmd to drop "weak hidden class" and refer it as "hidden class"
7. Small changes in response to Remi, Coleen, Paul's review comments
8. Fix copyright headers
9. Fix @modules in tests

Most of the changes above have also been reviewed as separate patches.


On 3/26/20 4:57 PM, Mandy Chung wrote:
> Please review the implementation of JEP 371: Hidden Classes. The main 
> changes are in core-libs and hotspot runtime area.  Small changes are 
> made in javac, VM compiler (intrinsification of Class::isHiddenClass), 
> JFR, JDI, and jcmd.  CSR [1]has been reviewed and is in the finalized 
> state (see specdiff and javadoc below for reference).
> Webrev:
> javadoc/specdiff
> JVMS 5.4.4 change:
> CSR:
> Thanks
> Mandy
> [1]
> [2]
> [3]

More information about the valhalla-dev mailing list