[lworld] [Rev 01] RFR: 8243623: [lworld] Syntax and other mechanical changes in langtools tests for JDK-8237072
sadayapalam at openjdk.java.net
Thu Apr 30 07:40:34 UTC 2020
> May I request you to review these changes to langtools tests that anticipate and
> align with JDK-8237072 ? These changes are mechanical in nature and I decided it
> is best to separate them from the RFR for JDK-8237072 itself to help create sharper
> focus on the important pieces there. (Non-mechanical meaningful test changes with
> be included in that RFR itself)
> JDK-8237072 adds supports for the new syntax notation of V.ref and V.val to
> refer to the reference projection of a value type V and its value projection.
> The old syntax of V? is withdrawn. This change also has class file implications
> where the descriptor/signature encodings will now start mentioning $ref in the
> class pool entries. Also every inline type results in two class files now
> one for each projection - with the reference projection class being the superclass
> of the inline class.
> I'll push them after your review and after JDK-8237072 itself is pushed.
> Thanks in advance.
Srikanth Adayapalam has updated the pull request incrementally with one additional commit since the last revision:
Incorporated review comments
- all: https://git.openjdk.java.net/valhalla/pull/29/files
- new: https://git.openjdk.java.net/valhalla/pull/29/files/b9ef3d73..686b791e
- full: https://webrevs.openjdk.java.net/valhalla/29/webrev.01
- incr: https://webrevs.openjdk.java.net/valhalla/29/webrev.00-01
Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
Fetch: git fetch https://git.openjdk.java.net/valhalla pull/29/head:pull/29
More information about the valhalla-dev