[lworld] RFR: 8243625: [lworld] Co-evolve hotspot-compiler tests along with JDK-8237072

Tobias Hartmann thartmann at openjdk.java.net
Thu Apr 30 16:09:33 UTC 2020


On Mon, 27 Apr 2020 06:16:15 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Tobias,
>> 
>> May I request you to review these changes to hotspot-compiler tests that anticipate
>> and align with JDK-8237072 ? These changes are mechanical in nature and I decided it
>> is best to separate them from the RFR for JDK-8237072 itself to help create sharper
>> focus on the important pieces there.
>> 
>> JDK-8237072 adds supports for the new syntax notation of V.ref and V.val to
>> refer to the reference projection of a value type V and its value projection.
>> The old syntax of V? is withdrawn. This change also has class file implications
>> where the descriptor/signature encodings will now start mentioning $ref in the
>> class pool entries. Also every inline type results in two class files now
>> one for each projection - with the reference projection class being the superclass
>> of the inline class.
>> 
>> I'll push them after your review and after JDK-8237072 itself is pushed.
>> Thanks in advance.
>
> Thanks for fixing. Looks good to me!

Here are some more adjustments needed:
[compilerTestFixes.txt](https://github.com/openjdk/valhalla/files/4558969/compilerTestFixes.txt)

All the remaining failures are JIT bugs. I'll work on them next.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/30


More information about the valhalla-dev mailing list