[lworld] RFR: 8244975: [lworld] Investigate if VM can implement Object::hashCode by calling ValueBootstrapMethods for inline types [v3]

Mandy Chung mchung at openjdk.java.net
Tue Aug 11 00:00:35 UTC 2020

On Mon, 10 Aug 2020 10:36:57 GMT, David Simms <dsimms at openjdk.org> wrote:

>> +1 for javac changes, assuming tests are all green
>> +1 for javac changes, assuming tests are all green
> Looks like I did break something:
> `ValueModifierTest.java:16:28: compiler.err.override.meth: (compiler.misc.cant.override: toString(),
> compiler.misc.anonymous.class: ValueModifierTest$3, toString(), value), final`
> rather than .out file:
> `ValueModifierTest.java:16:28: compiler.err.override.meth: (compiler.misc.cant.override: hashCode(),
> compiler.misc.anonymous.class: ValueModifierTest$3, hashCode(), value), final`
> Not sure I completely understand the test...ahh, yeah I do, no longer generate hashCode, but toString was

This looks good to me.  I made a small clean up on javac `Gen::synthesizeValueMethod` method to remove the switch


PR: https://git.openjdk.java.net/valhalla/pull/136

More information about the valhalla-dev mailing list