RFR: 8257776: [valhalla:jep390] Add disclaimer about future changes to value-based classes [v2]

Dan Smith dlsmith at openjdk.java.net
Fri Dec 4 22:33:39 UTC 2020

On Fri, 4 Dec 2020 22:25:05 GMT, Dan Smith <dlsmith at openjdk.org> wrote:

>> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryAddress.java line 44:
>>> 42:  * All implementations of this interface must be <a href="{@docRoot}/java.base/java/lang/doc-files/ValueBased.html">value-based</a>;
>>> 43:  * programmers should treat instances that are {@linkplain #equals(Object) equal} as interchangeable and should not
>>> 44:  * use instances for synchronization, or unpredictable behavior may occur. For example, in a future release, synchronization may fail.
>> Nit: this line is very long and maybe good to wrap this line and the line above..   I understand that the javadoc in this file has long lines and href is an outliner.
> Yeah, it's not conventional, but it's the style in this file, so I decided not to perturb it. This is an incubator module, I assume it will get polished up before becoming final.

Ok, Roger said the same thing, I guess I tweak it.


PR: https://git.openjdk.java.net/valhalla/pull/294

More information about the valhalla-dev mailing list