[lworld] RFR: 8242402: multianewarray is missing checks on the bottom class [v2]

Harold Seigel hseigel at openjdk.java.net
Tue Jul 7 13:43:23 UTC 2020


On Mon, 6 Jul 2020 20:43:02 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Please review this patch which adds a missing check in array class resolution.
>> 
>> When an array class is resolved and the bottom type is not a primitive type, the envelope of the bottom type signature
>> is removed in order to extract the class name and load it. Currently, there's no check that the kind of the loaded
>> class matches the enveloped stripped from the signature.  The patch adds this check and includes an unit test.
>> 
>> Tested on all all platforms with mach5, tiers 1 to 3.
>> 
>> Thank you,
>> 
>> Fred
>
> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add message, copyrights and comments

All the changes look good!

-------------

Marked as reviewed by hseigel (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/105


More information about the valhalla-dev mailing list