[lworld] RFR: rename valhalla runtime tests to 'inline'

Frederic Parain fparain at openjdk.java.net
Wed Jul 29 18:32:03 UTC 2020


On Wed, 29 Jul 2020 12:31:35 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this tiresome change to rename the directory containing the JVM runtime valhalla tests to 'inlinetypes',
> and to rename the tests and their contents as needed.
> Thanks, Harold

Just a few minor comments.
CircularityTest.java and EmptyInlineTest.java appear as deleted/new instead of renamed, I don't know why.
Otherwise, looks good to me.

Thank you,

Fred

test/hotspot/jtreg/runtime/valhalla/inlinetypes/InlineTypeDensity.java line 228:

> 227:         long inlineArraySize = WHITE_BOX.getObjectSize(inlineArray);
> 228:         System.out.println("Object array and elements: " + objectArraySize + " versus Value Array: " +
> inlineArraySize); 229:         Asserts.assertLessThan(inlineArraySize, objectArraySize, "Inline array accounts for more
> heap than object array + elements !");

versus Value Array -> versus Flat Array

test/hotspot/jtreg/runtime/valhalla/inlinetypes/InlineTypeDensity.java line 229:

> 228:         System.out.println("Object array and elements: " + objectArraySize + " versus Value Array: " +
> inlineArraySize); 229:         Asserts.assertLessThan(inlineArraySize, objectArraySize, "Inline array accounts for more
> heap than object array + elements !"); 230:     }

Inline array -> Flat array

test/hotspot/jtreg/runtime/valhalla/inlinetypes/UninitializedInlineFieldsTest.java line 31:

> 30:  * @library /test/lib
> 31:  * @compile -XDemitQtypes -XDenableValueTypes -XDallowWithFieldOperator -XDallowFlattenabilityModifiers Point.java
> JumboInline.java UninitializedInlineFieldsTest.java 32:  * @run main/othervm -Xint -XX:InlineFieldMaxFlatSize=64
> runtime.valhalla.inlinetypes.UninitializedInlineFieldsTest

Do we still need -XDemitQtypes and -XDenableValueTypes options?

-------------

Marked as reviewed by fparain (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/122


More information about the valhalla-dev mailing list