[lworld] RFR: 8248003: [lworld] [lw3] VM crashes when classes with inline type fields are loaded from CDS archive

Ioi Lam ioi.lam at oracle.com
Wed Jun 24 00:49:58 UTC 2020

Hi Fred,

The changes look good to me. For this comment:

// Even if the Point class is not loaded from the CDS archive, make sure 
the WithInlineField class
// can still be loaded successfully, and properly get the rewritten 
version of Point.

[1] spelling of WithInlineField -> WithInlinedField
[2] I think you can add

// The archived version of WithInlinedField must not be loaded, because 
it references the archived
// version of Point, but a different version of Point has been loaded.

- Ioi

On 6/23/20 10:52 AM, Frederic Parain wrote:
> On Mon, 22 Jun 2020 12:46:56 GMT, Frederic Parain <fparain at openjdk.org> wrote:
>> Please review this changeset fixing several issues in CDS related to inline type metadata removal and restoration.
>> Thank you,
>> Fred
> The fix has been updated according to Ioi's review, and a new test has been added with class redefinition.
> Thank you,
> Fred
> -------------
> PR: https://git.openjdk.java.net/valhalla/pull/95

More information about the valhalla-dev mailing list