[lworld] RFR: 8248330: [lworld] [lw3] test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetImplementedInterfaces/getintrf007/TestDescription.java fails because of IdentityObject

Frederic Parain fparain at openjdk.java.net
Thu Jun 25 16:59:12 UTC 2020


On Thu, 25 Jun 2020 15:48:01 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Please review this small fix in JVMTI.
>> 
>> The problem is that GetImplementedInterfaces doesn't return the expected set of interfaces because of the injection of
>> the java.lang.IdentityObject interface by the JVM. The fix simply filters out this interface if it has been injected by
>> the JVM, providing the same behavior as for reflection.  Thank you,
>> 
>> Fred
>
> The changes look good.  Does this also fix the test failures listed in JDK-8247491?

Harold,

Thank you for the review.

I've tested the fix with the tests listed in JDK-8247491:
vmTestbase/nsk/jdi/ClassType/allInterfaces/allinterfaces001/TestDescription.java
vmTestbase/nsk/jdi/ClassType/interfaces/interfaces001/TestDescription.java
vmTestbase/nsk/jdi/InterfaceType/implementors/implementors001/TestDescription.java
vmTestbase/nsk/jdi/InterfaceType/subinterfaces/subinterfaces001/TestDescription.java
vmTestbase/nsk/jdi/InterfaceType/superinterfaces/superinterfaces001/TestDescription.java
vmTestbase/nsk/jvmti/ClassPrepare/classprep001/TestDescription.java

They all pass now.

Fred

-------------

PR: https://git.openjdk.java.net/valhalla/pull/100


More information about the valhalla-dev mailing list