[lworld] [Rev 01] RFR: 8243623: [lworld] Syntax and other mechanical changes in langtools tests for JDK-8237072
github.com+63007666+JimLaskey at openjdk.java.net
Fri May 1 12:01:35 UTC 2020
On Thu, 30 Apr 2020 07:40:34 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:
>> May I request you to review these changes to langtools tests that anticipate and
>> align with JDK-8237072 ? These changes are mechanical in nature and I decided it
>> is best to separate them from the RFR for JDK-8237072 itself to help create sharper
>> focus on the important pieces there. (Non-mechanical meaningful test changes with
>> be included in that RFR itself)
>> JDK-8237072 adds supports for the new syntax notation of V.ref and V.val to
>> refer to the reference projection of a value type V and its value projection.
>> The old syntax of V? is withdrawn. This change also has class file implications
>> where the descriptor/signature encodings will now start mentioning $ref in the
>> class pool entries. Also every inline type results in two class files now
>> one for each projection - with the reference projection class being the superclass
>> of the inline class.
>> I'll push them after your review and after JDK-8237072 itself is pushed.
>> Thanks in advance.
> Srikanth Adayapalam has updated the pull request incrementally with one additional commit since the last revision:
> Incorporated review comments
Marked as reviewed by JimLaskey at github.com (no known OpenJDK username).
More information about the valhalla-dev