[lworld] RFR: 8243623: [lworld] Syntax and other mechanical changes in langtools tests for JDK-8237072

Jim Laskey github.com+63007666+JimLaskey at openjdk.java.net
Fri May 1 12:01:35 UTC 2020

On Mon, 27 Apr 2020 04:42:21 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

> Jim,
> May I request you to review these changes to langtools tests that anticipate and
> align with JDK-8237072 ? These changes are mechanical in nature and I decided it
> is best to separate them from the RFR for JDK-8237072 itself to help create sharper
> focus on the important pieces there. (Non-mechanical meaningful test changes with
> be included in that RFR itself)
> JDK-8237072 adds supports for the new syntax notation of V.ref and V.val to
> refer to the reference projection of a value type V and its value projection.
> The old syntax of V? is withdrawn. This change also has class file implications
> where the descriptor/signature encodings will now start mentioning $ref in the
> class pool entries. Also every inline type results in two class files now
> one for each projection - with the reference projection class being the superclass
> of the inline class.
> I'll push them after your review and after JDK-8237072 itself is pushed.
> Thanks in advance.

    Indentation (tab vs space)
    X.ref[] xa = new Object[10]; should it be X.ref[] xa = new Object.ref[10]; I'm sure it is correct (Object.ref doesn't
    exist) but there is an inconsistency with old code. Maybe add a comment.

Otherwise, good.


PR: https://git.openjdk.java.net/valhalla/pull/29

More information about the valhalla-dev mailing list