[lworld] RFR: 8253113: [lworld] [lw3] C1 should avoid copying element of flattened arrays when reading a sub-element [v2]

Frederic Parain fparain at openjdk.java.net
Tue Sep 15 13:02:35 UTC 2020


On Tue, 15 Sep 2020 07:07:04 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixes from review
>
> src/hotspot/share/c1/c1_LIRGenerator.cpp line 1605:
> 
>> 1603:   assert(flat_array_klass->is_loaded(), "must be");
>> 1604:
>> 1605:   ciInlineKlass* elem_klass = NULL;
> 
> Unused.

Fixed

> src/hotspot/share/c1/c1_LIRGenerator.cpp line 1611:
> 
>> 1609:   BasicType subelt_type = field->type()->basic_type();
>> 1610:
>> 1611:   #ifndef _LP64
> 
> Wrong indentation.

Fixed

-------------

PR: https://git.openjdk.java.net/valhalla/pull/187


More information about the valhalla-dev mailing list