[lworld] RFR: 8253416: [lworld] C1: incorrect nestmate access to flattened field if nest-host is not loaded

Tobias Hartmann thartmann at openjdk.java.net
Mon Sep 28 09:10:09 UTC 2020


On Fri, 25 Sep 2020 14:17:28 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>>> So, did you keep the needs_patching argument in the copy_inline_content() method only for verification purpose?
>> 
>> Yes, but we could also move the assert into the caller. What do you prefer?
>
> I'm fine with both approaches (assert in the caller or in copy_inline_content()), just pick the solution you think is
> the safest (I don't think it makes a lot of difference from a performance point of view).
> Fred

Thanks. I'll go with the current version and think about refactoring with JDK-8228634.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/198


More information about the valhalla-dev mailing list