[lworld] RFR: 8244313: [lworld] Evolve javac's code generation to match scheme documented in SoV

Srikanth Adayapalam sadayapalam at openjdk.java.net
Fri Apr 16 12:23:49 UTC 2021

On Fri, 16 Apr 2021 12:12:32 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

> Generate code according to the scheme outlined in the Members section of https://cr.openjdk.java.net/~briangoetz/valhalla/sov/04-translation.html

Hotspot compiler folk,

This change set is failing a bunch of tests compiler/valhalla/inlinetypes. I believe this is due to problems in the hotspot compiler.
Analysis here: 

1. These three tests generate SIGSEGV:
        - TestBasicFunctionality.java
        - TestC2CCalls.java
        - TestLWorld.java
2. These two tests trigger a RuntimeException: Unexpected compilation level for ...
        - TestCallingConvention.java
        - TestOnStackReplacement.java 
3. This test generates a CCE in compiled code, bytecode looks reasonable:
        - TestCallingConventionC1.java
4. This test triggers a runtime assertion: "RuntimeException: assertEquals: expected [compiler.valhalla.inlinetypes.TestNullableArrays$Complex re=291.0 im=291.0] to equal [compiler.valhalla.inlinetypes.TestNullableArrays$Complex re=291.0 im=169653.0]"
        - TestNullableArrays.java

Thanks for looking into these. If you can provide a fix in time, I can include it in the integration.


PR: https://git.openjdk.java.net/valhalla/pull/386

More information about the valhalla-dev mailing list