[lworld] RFR: 8272306: [lworld] Fix incorrectly merged code in classListParser.cpp

Ioi Lam iklam at openjdk.java.net
Mon Aug 23 21:11:59 UTC 2021

On Mon, 23 Aug 2021 12:18:10 GMT, David Simms <dsimms at openjdk.org> wrote:

>> Please review this simple fix (and small clean up) for incorrectly merged code in classListParser.cpp.
>> This following shows the difference between valhalla and the JDK mainline after this PR:
>> $ wget https://raw.githubusercontent.com/iklam/valhalla/4da52eaf53e531e96e1e6eac460d6209916d6f2f/src/hotspot/share/cds/classListParser.cpp
>> $ wget https://raw.githubusercontent.com/iklam/valhalla/a977e73076022958f9da874d029b1bfdba92f7af/src/hotspot/share/cds/classListParser.cpp
>> $ diff classListParser.cpp classListParser.cpp.1
> Thanks Ioi, this would be my mess you cleaned up here, much appreciated. Changes look good

@MrSimms thanks for the review.


PR: https://git.openjdk.java.net/valhalla/pull/538

More information about the valhalla-dev mailing list