[lworld] RFR: 8261019: [lworld] valhalla/valuetypes/QTypeDescriptorTest.java "Illegal class name "QLine; " in class file $Proxy5" [v2]
Yang Yi
github.com+5010047+kelthuzadx at openjdk.java.net
Fri Feb 5 02:33:11 UTC 2021
On Thu, 4 Feb 2021 18:12:05 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> Yang Yi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update full name
>
> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 456:
>
>> 454: */
>> 455: private byte[] generateClassFile() {
>> 456: visit(V17, accessFlags, dotToSlash(className), null,
>
> Alternatively, we can use the value of the system property `java.class.version` to prepare for future class file version change. But this requires parsing it to extract the major version.
>
> I'm okay with this simple approach and remember to update it if the class file version is bumped.
It seems reasonable. When I fix another related fail, I can tweak this part.
-------------
PR: https://git.openjdk.java.net/valhalla/pull/320
More information about the valhalla-dev
mailing list