[lworld] RFR: 8260283: [lworld] C1's EliminateFieldAccess optimization fails with "wrong types" [v3]
fparain at openjdk.java.net
Fri Jan 22 17:56:54 UTC 2021
On Fri, 22 Jan 2021 13:14:25 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> C1's delayed field access optimization ([JDK-8229897](https://bugs.openjdk.java.net/browse/JDK-8229897)) does not update the field when updating a `LoadField`. The `EliminateFieldAccess` optimization then uses the wrong field (offset) to look up the loaded value in the `MemoryBuffer`. We hit an assert because the field types do not match.
> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
> We don't even need to keep track of the field, holder is sufficient
Looks good to me.
Marked as reviewed by fparain (Committer).
More information about the valhalla-dev