[lworld] RFR: 8271309: [lworld] FieldModification event: new_value is invalid for Q objects
Alex Menkov
amenkov at openjdk.java.net
Wed Jul 28 00:00:08 UTC 2021
On Tue, 27 Jul 2021 23:55:54 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> test/hotspot/jtreg/serviceability/jvmti/Valhalla/FieldAccessModify/libFieldAccessModify.cpp line 139:
>>
>>> 137: // For FieldModification event print current value.
>>> 138: // Note: this will cause FieldAccess event.
>>> 139: if (modified) {
>>
>> It would be cleaner to have modified be declared as a bool, or to re-write the test to modified == 1.
>
>> Many of the tests related to the FieldModification event are still not working (they are commented with a KNOWN ISSUE comment) because the withfield bytecode still doesn't support JVMTI FieldModification event. Do you have a CR to track this issue?
>
> Filed JDK-8271355
> It would be cleaner to have modified be declared as a bool, or to re-write the test to modified == 1.
C-style detected :)
Will fix it.
-------------
PR: https://git.openjdk.java.net/valhalla/pull/499
More information about the valhalla-dev
mailing list