RFR: 8269536: Fix verifier withfield test

Frederic Parain fparain at openjdk.java.net
Wed Jun 30 20:27:20 UTC 2021


On Tue, 29 Jun 2021 20:38:32 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this small change to fix test VerifierInlineTypes.java. The fix removes from the jcod classes improper and unneeded methods that were causing unwanted ClassFormatError exceptions. The change also removes tests that are no longer applicable. Finally, it merges NoNullVT.jcod into verifierTests.jcod.
> 
> The changes were tested by running Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows.
> 
> Thanks, Harold

Looks good to me.
However, we should re-implement those tests for the runtime (instead of the verifier) because this is where checks are performed now (could be a follow-up CR).

Fred

-------------

Marked as reviewed by fparain (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/470


More information about the valhalla-dev mailing list