RFR: L/Q again, step two [v4]

Tobias Hartmann thartmann at openjdk.java.net
Wed May 19 13:56:11 UTC 2021

On Wed, 19 May 2021 13:15:19 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Please review this second set of fixes for the L/Q transition.
>> A few changes in C1, most changes in CI.
>> CI always delegates to the runtime to know if a null-free array is flattened or not (to avoid duplication of the flattening decision code).
>> With those changes, all tests in runtime/valhalla/inlinetypes now pass with -Xcomp -XX:TieredStopAtLevel=1 (at least on Linux x64).
>> Some tests in compiler/valhalla/inlinetypes still fail but they will require more time to be investigated (some tests force use of C2 or expect code to be C2 compiled, but C2 is not fixed yet).
>> Thank you,
>> Fred
> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
>   Refactor ciArrayKlass::make()

Thanks for updating, looks good to me (added one minor suggestion).

src/hotspot/share/ci/ciArrayKlass.cpp line 121:

> 120:       } else {
> 121:         if (ak != NULL && ak->is_flatArray_klass()) {

`else` and `if` can be merged


Marked as reviewed by thartmann (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/414

More information about the valhalla-dev mailing list