From georges.saab at oracle.com Fri Apr 1 22:45:36 2011 From: georges.saab at oracle.com (Georges Saab) Date: Fri, 1 Apr 2011 22:45:36 -0700 Subject: OpenJDK Bug Tracking Project Requirements, consolidated list In-Reply-To: References: <4D92B17E.8000308@oracle.com> Message-ID: If the requirements are met by both, the obvious choice is Jira, given that it is written in Java. :) On 30 mar 2011, at 05.27, Dr Andrew John Hughes wrote: > On 30 March 2011 05:28, Roger Lewis wrote: >> Hello, >> >> What we want to start to do now is to map the requirements to candidate >> systems; the two options we are looking at are Bugzilla[3] and JIRA[4]. We >> are starting with these two as from our initial discussions they are the >> most common choices for open source projects. From our analysis so far >> either system would meet the majority of our needs but we would like to get >> input from other projects that are using these systems, and will also be >> talking over the next couple of week to consultants with experience setting >> up these systems. >> >> >> > > If the requirements are met by both, then the obvious choice is > Bugzilla, given you already have it setup on bugs.openjdk.java.net and > it's Free Software. > -- > Andrew :-) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and the OpenJDK > http://www.gnu.org/software/classpath > http://openjdk.java.net > > PGP Key: F5862A37 (https://keys.indymedia.org/) > Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37 From gnu_andrew at member.fsf.org Sat Apr 2 16:59:55 2011 From: gnu_andrew at member.fsf.org (Dr Andrew John Hughes) Date: Sun, 3 Apr 2011 00:59:55 +0100 Subject: OpenJDK Bug Tracking Project Requirements, consolidated list In-Reply-To: References: <4D92B17E.8000308@oracle.com> Message-ID: On 02/04/2011, Georges Saab wrote: > If the requirements are met by both, the obvious choice is Jira, given that > it is written in Java. :) > What relevance does that have? Given it's proprietary software and being run on someone's else server, it could be written in hand-crafted assembly language for it all it matters. On the other hand, there's a Bugzilla instance already up and running, with users having already established accounts. It is Free Software and apparently fulfils all the technical requirements. So just get on with making it useful already. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From roger.yeung at oracle.com Sun Apr 3 15:22:25 2011 From: roger.yeung at oracle.com (Roger Yeung) Date: Sun, 03 Apr 2011 15:22:25 -0700 Subject: OpenJDK Bug Tracking Project Requirements, consolidated list In-Reply-To: References: <4D92B17E.8000308@oracle.com> Message-ID: <4D98F321.5080303@oracle.com> On 4/2/11 4:59 PM, Dr Andrew John Hughes wrote: > On 02/04/2011, Georges Saab wrote: >> If the requirements are met by both, the obvious choice is Jira, given that >> it is written in Java. :) >> > What relevance does that have? Given it's proprietary software and > being run on someone's else server, it could be written in > hand-crafted assembly language for it all it matters. JIRA can be deployed as a WAR file and run on other App Servers. I don't think there's a constraint to run on someone's else servers in order to work. > On the other hand, there's a Bugzilla instance already up and running, > with users having already established accounts. When mapping the features of the 2 systems to our requirements, I compared the latest versions (Bugzilla: 4.0, 4.1.1 and JIRA 4.3). The Bugzilla instance that we have is old (3.2.9); therefore, it does not have all features we need [1]. There are a lot of new enhancements in the WebServices and hook area since Bugzilla 4.0 which are listed in our requirements. I'd imagine if we choose Bugzilla, we won't be using the same instance that is running. Therefore, reusing the same instances isn't a big incentive from my perspective. > It is Free Software > and apparently fulfils all the technical requirements. So just get on > with making it useful already. Just a reference: the Lucene project on ASF uses JIRA also[2]. [1] http://www.bugzilla.org/releases/4.0/release-notes.html#v40_feat [2] https://issues.apache.org/jira/browse/LUCENE Regards, Roger Y. From georges.saab at oracle.com Sun Apr 3 23:20:55 2011 From: georges.saab at oracle.com (Georges Saab) Date: Sun, 3 Apr 2011 23:20:55 -0700 Subject: OpenJDK Bug Tracking Project Requirements, consolidated list In-Reply-To: References: <4D92B17E.8000308@oracle.com> Message-ID: <83980AF6-252D-4D6A-AA28-F9BA3E8923F6@oracle.com> On 2 apr 2011, at 16.59, Dr Andrew John Hughes wrote: > On 02/04/2011, Georges Saab wrote: >> If the requirements are met by both, the obvious choice is Jira, given that >> it is written in Java. :) >> > > What relevance does that have? Given it's proprietary software and > being run on someone's else server, it could be written in > hand-crafted assembly language for it all it matters. Actually I think it matters because of the alignment of incentive it creates: 1. JIRA developers have an incentive to help us by fixing bugs which affect OpenJDK because they get the benefit of OpenJDK being great 2. We have the incentive (and capability) to fix bugs in Java which affect JIRA The same incentives do not exist if the system is written in hand-crafted assembly language. Symbiosis can be a beautiful thing and need not always observe boundaries of software license classification. In your comment about "someone else's server", I am not sure I follow? In particular, by "Server" do you mean app server or HW and by "someone else" do you mean as opposed to 'the OpenJDK community' or 'Dr Andrew John Hughes'? From David.Holmes at oracle.com Mon Apr 4 21:01:50 2011 From: David.Holmes at oracle.com (David Holmes) Date: Tue, 05 Apr 2011 14:01:50 +1000 Subject: Understanding and navigating the repositories on hg.openjdk.java.net Message-ID: <4D9A942E.2040507@oracle.com> Is there any kind of manual/user-guide that describes the mercurial web interface that we see on hg.openjdk.java.net? I'm finding the interface totally bemusing. I'm trying to see, for example, whether a bunch of fixes I put into jdk7/tl/jdk have made their way into jdk7/jdk7/jdk - should be simple right? ;-) But I can't even find my fixes where I would expect to find them. For example, if you look at: http://hg.openjdk.java.net/jdk7/tl/jdk/shortlog there are changesets listed from 8 hours ago through to 5 weeks ago (though the order is also bemusing). Yet my last push was on March 30 and I can't see it listed on this page. Yet if I click on the "-60" link (what the heck does that mean anyway???) I find my last push on that page - a page which contains changesets from 4 days ago through to 5 weeks ago. So whatever ordering is being used here it sure isn't anything intuitively obvious. Can someone enlighten me please or point me to the manual. Thanks, David Holmes From kelly.ohair at oracle.com Mon Apr 4 21:47:38 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 4 Apr 2011 21:47:38 -0700 Subject: Understanding and navigating the repositories on hg.openjdk.java.net In-Reply-To: <4D9A942E.2040507@oracle.com> References: <4D9A942E.2040507@oracle.com> Message-ID: <6F485896-3F46-467E-85DF-5E128E66CC11@oracle.com> The time on a changeset is when the changeset was created, doesn't have much to do with the 'push' event. The changesets represent a graph from the rev 0 changeset to the tip, but the changesets also have an order as to when they showed up in a repository, the decimal number is the local order that a changeset first appeared in a repository, I think the -60 refers to that order. But that local order could be different for each repository so be careful with that local number. The hg book at http://hgbook.red-bean.com/read/ might provide more help. When we upgrade the Mercurial server to a newer version, we will probably get the "Graph" feature. If you have a newer Mercurial on your machine, you can try doing a 'hg serve -v' and browse your own repository, the Graph might help. -kto On Apr 4, 2011, at 9:01 PM, David Holmes wrote: > Is there any kind of manual/user-guide that describes the mercurial web interface that we see on hg.openjdk.java.net? > > I'm finding the interface totally bemusing. I'm trying to see, for example, whether a bunch of fixes I put into jdk7/tl/jdk have made their way into jdk7/jdk7/jdk - should be simple right? ;-) But I can't even find my fixes where I would expect to find them. For example, if you look at: > > http://hg.openjdk.java.net/jdk7/tl/jdk/shortlog > > there are changesets listed from 8 hours ago through to 5 weeks ago (though the order is also bemusing). Yet my last push was on March 30 and I can't see it listed on this page. Yet if I click on the "-60" link (what the heck does that mean anyway???) I find my last push on that page - a page which contains changesets from 4 days ago through to 5 weeks ago. So whatever ordering is being used here it sure isn't anything intuitively obvious. > > Can someone enlighten me please or point me to the manual. > > Thanks, > David Holmes From David.Holmes at oracle.com Mon Apr 4 22:12:10 2011 From: David.Holmes at oracle.com (David Holmes) Date: Tue, 05 Apr 2011 15:12:10 +1000 Subject: Understanding and navigating the repositories on hg.openjdk.java.net In-Reply-To: <6F485896-3F46-467E-85DF-5E128E66CC11@oracle.com> References: <4D9A942E.2040507@oracle.com> <6F485896-3F46-467E-85DF-5E128E66CC11@oracle.com> Message-ID: <4D9AA4AA.9090104@oracle.com> Hi Kelly, Kelly O'Hair said the following on 04/05/11 14:47: > The time on a changeset is when the changeset was created, doesn't have much to do with the > 'push' event. So if I undertand this right the timestamp is almost completely useless. For example, I could create a changeset today, wait three weeks, do a merge (the merge changset would have todays timestamp), then push and I would see the merge changeset listed on the tip page and the real changset would be where? Pages back depending on how many other changsets were done in between ??? > The changesets represent a graph from the rev 0 changeset to the tip, but the changesets also have an order > as to when they showed up in a repository, the decimal number is the local order that a changeset first appeared > in a repository, I think the -60 refers to that order. But that local order could be different for each repository > so be careful with that local number. So there's no way to discern the tree from the flat listing on the webpage. So basically all I can do is hunt through all the listings (or search) for my changset. > The hg book at http://hgbook.red-bean.com/read/ might provide more help. No, I tried there first - there's no mention that I can see of the web interface. > When we upgrade the Mercurial server to a newer version, we will probably get the "Graph" feature. > If you have a newer Mercurial on your machine, you can try doing a 'hg serve -v' and browse your > own repository, the Graph might help. Thanks I'll see if I can give that try ... just got to dredge up the "how to install hg on solaris x86" emails ... David > -kto > > On Apr 4, 2011, at 9:01 PM, David Holmes wrote: > >> Is there any kind of manual/user-guide that describes the mercurial web interface that we see on hg.openjdk.java.net? >> >> I'm finding the interface totally bemusing. I'm trying to see, for example, whether a bunch of fixes I put into jdk7/tl/jdk have made their way into jdk7/jdk7/jdk - should be simple right? ;-) But I can't even find my fixes where I would expect to find them. For example, if you look at: >> >> http://hg.openjdk.java.net/jdk7/tl/jdk/shortlog >> >> there are changesets listed from 8 hours ago through to 5 weeks ago (though the order is also bemusing). Yet my last push was on March 30 and I can't see it listed on this page. Yet if I click on the "-60" link (what the heck does that mean anyway???) I find my last push on that page - a page which contains changesets from 4 days ago through to 5 weeks ago. So whatever ordering is being used here it sure isn't anything intuitively obvious. >> >> Can someone enlighten me please or point me to the manual. >> >> Thanks, >> David Holmes > From Alan.Bateman at oracle.com Tue Apr 5 01:12:06 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 05 Apr 2011 09:12:06 +0100 Subject: Understanding and navigating the repositories on hg.openjdk.java.net In-Reply-To: <4D9A942E.2040507@oracle.com> References: <4D9A942E.2040507@oracle.com> Message-ID: <4D9ACED6.4010004@oracle.com> David Holmes wrote: > Is there any kind of manual/user-guide that describes the mercurial > web interface that we see on hg.openjdk.java.net? > > I'm finding the interface totally bemusing. I'm trying to see, for > example, whether a bunch of fixes I put into jdk7/tl/jdk have made > their way into jdk7/jdk7/jdk - should be simple right? ;-) But I can't > even find my fixes where I would expect to find them. For example, if > you look at: > > http://hg.openjdk.java.net/jdk7/tl/jdk/shortlog > > there are changesets listed from 8 hours ago through to 5 weeks ago > (though the order is also bemusing). Yet my last push was on March 30 > and I can't see it listed on this page. Yet if I click on the "-60" > link (what the heck does that mean anyway???) I find my last push on > that page - a page which contains changesets from 4 days ago through > to 5 weeks ago. So whatever ordering is being used here it sure isn't > anything intuitively obvious. > > Can someone enlighten me please or point me to the manual. > The search (upper right) can very useful for this kind of thing. You can search on the bugID or changeset ID to quickly locate and browse changeset. For the problem at hand, then you can search jdk7/jdk7/jdk to see if the changeset is present. -Alan. From kelly.ohair at oracle.com Tue Apr 5 11:52:41 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 5 Apr 2011 11:52:41 -0700 Subject: Understanding and navigating the repositories on hg.openjdk.java.net In-Reply-To: <4D9AA4AA.9090104@oracle.com> References: <4D9A942E.2040507@oracle.com> <6F485896-3F46-467E-85DF-5E128E66CC11@oracle.com> <4D9AA4AA.9090104@oracle.com> Message-ID: On Apr 4, 2011, at 10:12 PM, David Holmes wrote: > Hi Kelly, > > Kelly O'Hair said the following on 04/05/11 14:47: >> The time on a changeset is when the changeset was created, doesn't have much to do with the >> 'push' event. > > So if I undertand this right the timestamp is almost completely useless. For example, I could create a changeset today, wait three weeks, do a merge (the merge changset would have todays timestamp), then push and I would see the merge changeset listed on the tip page and the real changset would be where? Pages back depending on how many other changsets were done in between ??? The timestamp is actually quite valuable, but I can see that it may appear useless to most people. But the order you see the changesets, e.g. http://hg.openjdk.java.net/jdk7/jdk7/jdk/shortlog is the order that they were pushed in. When I look for a changeset, I use the search box in the upper right, with a username, bugid, or filename. Otherwise I scan the shortlog. > >> The changesets represent a graph from the rev 0 changeset to the tip, but the changesets also have an order >> as to when they showed up in a repository, the decimal number is the local order that a changeset first appeared >> in a repository, I think the -60 refers to that order. But that local order could be different for each repository >> so be careful with that local number. > > So there's no way to discern the tree from the flat listing on the webpage. So basically all I can do is hunt through all the listings (or search) for my changset. Right now, without the "Graph" option, yes. -kto > >> The hg book at http://hgbook.red-bean.com/read/ might provide more help. > > No, I tried there first - there's no mention that I can see of the web interface. > >> When we upgrade the Mercurial server to a newer version, we will probably get the "Graph" feature. >> If you have a newer Mercurial on your machine, you can try doing a 'hg serve -v' and browse your >> own repository, the Graph might help. > > Thanks I'll see if I can give that try ... just got to dredge up the "how to install hg on solaris x86" emails ... > > David > >> -kto >> On Apr 4, 2011, at 9:01 PM, David Holmes wrote: >>> Is there any kind of manual/user-guide that describes the mercurial web interface that we see on hg.openjdk.java.net? >>> >>> I'm finding the interface totally bemusing. I'm trying to see, for example, whether a bunch of fixes I put into jdk7/tl/jdk have made their way into jdk7/jdk7/jdk - should be simple right? ;-) But I can't even find my fixes where I would expect to find them. For example, if you look at: >>> >>> http://hg.openjdk.java.net/jdk7/tl/jdk/shortlog >>> >>> there are changesets listed from 8 hours ago through to 5 weeks ago (though the order is also bemusing). Yet my last push was on March 30 and I can't see it listed on this page. Yet if I click on the "-60" link (what the heck does that mean anyway???) I find my last push on that page - a page which contains changesets from 4 days ago through to 5 weeks ago. So whatever ordering is being used here it sure isn't anything intuitively obvious. >>> >>> Can someone enlighten me please or point me to the manual. >>> >>> Thanks, >>> David Holmes From Roger.Calnan at oracle.COM Thu Apr 7 22:30:43 2011 From: Roger.Calnan at oracle.COM (Roger Calnan) Date: Thu, 7 Apr 2011 22:30:43 -0700 Subject: OpenJDK Bug Tracking Project Requirements, consolidated list In-Reply-To: <4D92B17E.8000308@oracle.com> References: <4D92B17E.8000308@oracle.com> Message-ID: <02A33077-80AF-4C54-A587-483A022AD5D3@oracle.COM> there have been questions raised around the requirements that refer to the bugs.sun.com infrastructure and if/how we will move it forward. The following provides some background to that and the changes that are being considered: http://cr.openjdk.java.net/~rlewis/BugTracking/JDK%2bDefect%2bTracking.html it also provides some more background around what we need from a release production point of view, Roger From mohan.pakkurti at oracle.com Thu Apr 14 11:06:01 2011 From: mohan.pakkurti at oracle.com (Mohan Pakkurti) Date: Thu, 14 Apr 2011 20:06:01 +0200 Subject: OpenJDK Code review system - Request for use cases and requirements Message-ID: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> Hello I am looking at undertaking some projects to help improve the infrastructure for OpenJDK. One of the systems that is often requested is an open code review system, and I want to understand what we would want from this. I came across this blog entry http://blogs.sun.com/mr/entry/open_webrevs and want to get this discussion started again by asking you for input. What use cases would you have for this system? What features would you like to see in this system? What other systems and processes do you see the code review system integrate with? Any suggestions for systems we should consider for this? Do you have any other comments on this topic? Cheers Mohan From weijun.wang at oracle.com Thu Apr 14 18:41:24 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 15 Apr 2011 09:41:24 +0800 Subject: OpenJDK Code review system - Request for use cases and requirements In-Reply-To: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> References: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> Message-ID: <4DA7A244.3080409@oracle.com> On 04/15/2011 02:06 AM, Mohan Pakkurti wrote: > Hello > > I am looking at undertaking some projects to help improve the infrastructure for OpenJDK. > > One of the systems that is often requested is an open code review system, and I want to understand what we would want from this. > > I came across this blog entry http://blogs.sun.com/mr/entry/open_webrevs and want to get this discussion started again by asking you for input. > > What use cases would you have for this system? Upload code changes and view webrevs > What features would you like to see in this system? 1. Web based, just upload your diff (in a single file or in a TEXTAREA box) and the hg changeset URL it's based on. (Please don't ask me to upload a whole bunch of files). 2. All current webrev diff styles available for view 3. Nice URL to any single line within the webrev > What other systems and processes do you see the code review system integrate with? It might be useful to add a comment system below each webrev, but please make sure comments are sent by email also. And that means a user management system, which might be complicated. Thanks Max > Any suggestions for systems we should consider for this? > Do you have any other comments on this topic? > > Cheers > Mohan From anthony.petrov at oracle.com Fri Apr 15 03:13:21 2011 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 15 Apr 2011 14:13:21 +0400 Subject: OpenJDK Code review system - Request for use cases and requirements In-Reply-To: <4DA7A244.3080409@oracle.com> References: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> <4DA7A244.3080409@oracle.com> Message-ID: <4DA81A41.4040306@oracle.com> On 4/15/2011 5:41 AM, Weijun Wang wrote: >> What features would you like to see in this system? > > 1. Web based, just upload your diff (in a single file or in a TEXTAREA > box) and the hg changeset URL it's based on. (Please don't ask me to > upload a whole bunch of files). Being able to upload webrev.zip files generated by the webrev utility would be nice to have as well. The system should be able to display all submitted versions of a fix, and all the comments/discussions surrounding transitioning from one version to another. Also, the system should support keeping separate review processes of the same fix for several releases (e.g. in JDK 7 and 8). Ideally, the system should also support an email gate so that a webrev.zip or a diff file could be submitted as an attachment, and sending such an email would initiate a reviewing process (by notifying the reviewers, etc.) Being able to reply to such notifications and generally proceed with reviewing/commenting over email w/o the need to access the system via the web interface would be great as well. Also, it would be nice to be able to opt in for receiving all email notifications for a particular review, even though the person has not been chosen as a reviewer. Perhaps some people would prefer to use RSS rather than email for this purpose though. We should also think what should be a trigger for the "fix is now approved" action. When we choose particular reviewers this is somewhat obvious - when everyone has approved the fix, the fix is finally approved. However, I realize that often we want to have an open list of reviewers, so it's unclear when to mark a fix as approved in this case. Should this be done by the author of the fix? Or..? -- best regards, Anthony From jonathan.gibbons at oracle.com Fri Apr 15 07:58:36 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 15 Apr 2011 07:58:36 -0700 Subject: OpenJDK Code review system - Request for use cases and requirements In-Reply-To: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> References: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> Message-ID: <4DA85D1C.4020405@oracle.com> On 04/14/2011 11:06 AM, Mohan Pakkurti wrote: > Hello > > I am looking at undertaking some projects to help improve the infrastructure for OpenJDK. > > One of the systems that is often requested is an open code review system, and I want to understand what we would want from this. > > I came across this blog entry http://blogs.sun.com/mr/entry/open_webrevs and want to get this discussion started again by asking you for input. > > What use cases would you have for this system? > What features would you like to see in this system? Ability to see diffs "side by side" as in webrev output or "meld" or other GUI diff tools. Raw diff listings are not enough. Ability to see diffs since the last review, as well as diffs since the repo baseline. We occasionally create huge changesets, and have to wade through thousands or lines of diffs, and need to suggest a few changes. When the followup review is presented, I don't want to wade through all those thousands of lines of changes checking that stuff hasn't changed since the last review. [[ Although this is not directly supported by webrev, I note that you can write scripts to add extra files, such as a "delta-webrev", into a webrev directory or webrev.zip file. Ugly, but it works. ]] Ability to nominate reviewers. Tracking system: what reviews do I have outstanding, who has approved my outstanding reviews so far, etc. Email notification of updates, nag mail, etc. Archive of review comments. > What other systems and processes do you see the code review system integrate with? Bug tracking system, and/or Mercurial. Reviews should be identified (in part) by bug number. Reviews should disappear off the radar when a changeset has been committed and the bug status updated. > Any suggestions for systems we should consider for this? Without necessarily suggesting them as candidates, I'd suggest looking at Review Board and the internal sa.sfbay "webrev robot" for features of interest. > Do you have any other comments on this topic? > > Cheers > Mohan From sowmya.kannan at oracle.com Fri Apr 15 08:13:46 2011 From: sowmya.kannan at oracle.com (Sowmya Kannan) Date: Fri, 15 Apr 2011 08:13:46 -0700 Subject: OpenJDK Code review system - Request for use cases and requirements In-Reply-To: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> References: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> Message-ID: <4DA860AA.6080809@oracle.com> The following would be great: - ability to add comments in specific sections of code or an HTML document. For example, instead of saying "in the line Character.toChars(codePoint)" or "in the 3rd line of the second paragraph", it would be nice to just put a (virtual) sticky note in a particular line of code or a sentence in HTML. - ability to track which comments have been addressed and which have not by the owner of the code/content - ability to view HTML markup as well as formatted HTML page for content - ability to re-publish reviews. Re-publishing reviews should preserve old comment history - the commenting system would ideally be entirely web-based without the need to install additional client software Thanks Sowmya On 4/14/2011 11:06 AM, Mohan Pakkurti wrote: > Hello > > I am looking at undertaking some projects to help improve the infrastructure for OpenJDK. > > One of the systems that is often requested is an open code review system, and I want to understand what we would want from this. > > I came across this blog entry http://blogs.sun.com/mr/entry/open_webrevs and want to get this discussion started again by asking you for input. > > What use cases would you have for this system? > What features would you like to see in this system? > What other systems and processes do you see the code review system integrate with? > Any suggestions for systems we should consider for this? > Do you have any other comments on this topic? > > Cheers > Mohan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/web-discuss/attachments/20110415/9ed00596/attachment.html From jonathan.gibbons at oracle.com Fri Apr 15 08:35:09 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 15 Apr 2011 08:35:09 -0700 Subject: OpenJDK Code review system - Request for use cases and requirements In-Reply-To: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> References: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> Message-ID: <4DA865AD.30903@oracle.com> On 04/14/2011 11:06 AM, Mohan Pakkurti wrote: > What features would you like to see in this system? The ability to download a patch for the proposed change, so that I can use additional tools -- for example, build and test the change for myself. -- Jon From kelly.ohair at oracle.com Fri Apr 15 09:39:50 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 15 Apr 2011 09:39:50 -0700 Subject: OpenJDK Code review system - Request for use cases and requirements In-Reply-To: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> References: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> Message-ID: <3D7B8C5A-65C3-4C1D-B74F-D71524C6EE93@oracle.com> On Apr 14, 2011, at 11:06 AM, Mohan Pakkurti wrote: > Hello > > I am looking at undertaking some projects to help improve the infrastructure for OpenJDK. > > One of the systems that is often requested is an open code review system, and I want to understand what we would want from this. > > I came across this blog entry http://blogs.sun.com/mr/entry/open_webrevs and want to get this discussion started again by asking you for input. > > What use cases would you have for this system? I generally just need to get one or two people, usually fairly arbitrary openjdk people, to review changes prior to a changeset being created. Making this process easy and quick is paramount. > What features would you like to see in this system? I'm an old webrev user, so I need a review system that provides a variety of different views on the changes. It never obvious at times what kind of view works best with different types of files or changes. So my primary #1 feature would be to provide different views on the change being made. > What other systems and processes do you see the code review system integrate with? Although it might be nice to see a connection between a changeset and a webrev, or a CR number and a webrev, the actual act of doing a code review often changes what CRs are involved and what the final changesets will be created. And since the final changesets contain the final patch, the webrevs are simply preliminary diffs, not the final change. A webrev should probably include a reference to the public repository the change is based on, and the parent changesetID that the changes are based on. That is currently missing from the existing webrev script. A webrev is a "proposed change", not a final change in my view. > Any suggestions for systems we should consider for this? If the system chosen does not work with or adapt to a Distributed SCM like Mercurial/Git, it may not be a good system choice. > Do you have any other comments on this topic? Some additional background information: The current cr.openjdk.java.net community server is described at http://openjdk.java.net/guide/codeReview.html I think this simple storage server was created after Mark's original email. The webrev.ksh script is now at http://hg.openjdk.java.net/jdk7/jdk7/file/tip/make/scripts/webrev.ksh or in the top repository as ./make/scripts/webrev.ksh. Webrev help information is now at http://openjdk.java.net/guide/webrevHelp.html This script and the use of webrevs has been around for a long time. I think most of us that have used webrevs over the years have found them extremely valuable and the webrev script has evolved over time. Speaking for myself, I have found ReviewBoard overly complicated, incomplete in it's views on the differences, and frustrating to use. I would probably continue to use webrevs over ReviewBoard, at least until it provided a better set of views on the change. -kto > > Cheers > Mohan From Alan.Bateman at oracle.com Mon Apr 18 03:32:07 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 18 Apr 2011 11:32:07 +0100 Subject: OpenJDK Code review system - Request for use cases and requirements In-Reply-To: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> References: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> Message-ID: <4DAC1327.8080107@oracle.com> Mohan Pakkurti wrote: > Hello > > I am looking at undertaking some projects to help improve the infrastructure for OpenJDK. > > One of the systems that is often requested is an open code review system, and I want to understand what we would want from this. > > I came across this blog entry http://blogs.sun.com/mr/entry/open_webrevs and want to get this discussion started again by asking you for input. > > What use cases would you have for this system? > What features would you like to see in this system? > What other systems and processes do you see the code review system integrate with? > Any suggestions for systems we should consider for this? > Do you have any other comments on this topic? > > Cheers > Mohan I see all the replies so far are from Oracle folks and it would be good to get input from others too. It may also be useful to see what other open projects are using, if anything. One thing about cr.openjdk.java.net is that it's usefulness is broader than just hosting webrevs so it would be good to keep it as it's a very handy place to push preliminary webrevs, documents, and other items for discussions on the lists. Another thing that isn't clear from this mail is whether this is just infrastructure or whether it implies process too. I've no doubt that many areas will want to continue to discuss patches and changes via the mailing lists even if there is a ReviewBoard/equivalent available. One could envisage a discussion about a bug or area of code on the mailing list before the ready-to-be-reviewed changes are published to the review system. You asked about integration with other systems and being able to link to prior discussions in the archives or in the (new) bug database would be useful. I didn't see command line access mentioned in any of the comments so far. Many of us keep our repositories on servers and it would be be great to be able to run a shell command to publish a change for review. On the review side then having the ability to wget the patch file without authentication would be useful too as sometimes it's easier to just grab the patch and try out the changes. On the diffs then I think Jon summarized it well and being able to support delta webrevs/equivalent would be very useful as we often go through many iterations where the bulk of the changes are reviewed and we're spinning on a final few issues. I don't have any comments on the workflow side of this except that folks interested in an area should be able to subscribe so that they get notifications of reviews and discussion for the areas that they are interested in. Also the person seeking a review should be able to accept reviews from folks that he/she didn't originally nominate to review. -Alan. From spoole at linux.vnet.ibm.com Mon Apr 18 08:11:12 2011 From: spoole at linux.vnet.ibm.com (Steve Poole) Date: Mon, 18 Apr 2011 16:11:12 +0100 Subject: OpenJDK Code review system - Request for use cases and requirements In-Reply-To: <4DAC1327.8080107@oracle.com> References: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> <4DAC1327.8080107@oracle.com> Message-ID: <4DAC5490.5010809@linux.vnet.ibm.com> On 18/04/11 11:32, Alan Bateman wrote: > Mohan Pakkurti wrote: >> Hello >> >> I am looking at undertaking some projects to help improve the >> infrastructure for OpenJDK. >> One of the systems that is often requested is an open code review >> system, and I want to understand what we would want from this. >> >> I came across this blog entry >> http://blogs.sun.com/mr/entry/open_webrevs and want to get this >> discussion started again by asking you for input. >> >> What use cases would you have for this system? >> What features would you like to see in this system? What other >> systems and processes do you see the code review system integrate with? >> Any suggestions for systems we should consider for this? >> Do you have any other comments on this topic? >> >> Cheers >> Mohan > I see all the replies so far are from Oracle folks and it would be > good to get input from others too. It may also be useful to see what > other open projects are using, if anything. > I'm asking around in my team to see what we think. So either via me or directly we'll post our responses soon. A couple of interesting questions about a review system is whether its pre or post commit, and if it's pre - is it intended to be the gate into the repository. By that I mean that an authorised person could press a button and the changeset is commited to the repository. I like having the review system be the gate into the repo. That way you know that the code for review is the change that will be made. A good example of a review tool that works that way is gerrit. Having used reviewboard and gerrit I have to say I like gerrit better but it has its own issues - and of course its for git not mercurial. > One thing about cr.openjdk.java.net is that it's usefulness is broader > than just hosting webrevs so it would be good to keep it as it's a > very handy place to push preliminary webrevs, documents, and other > items for discussions on the lists. > > Another thing that isn't clear from this mail is whether this is just > infrastructure or whether it implies process too. I've no doubt that > many areas will want to continue to discuss patches and changes via > the mailing lists even if there is a ReviewBoard/equivalent available. > One could envisage a discussion about a bug or area of code on the > mailing list before the ready-to-be-reviewed changes are published to > the review system. You asked about integration with other systems and > being able to link to prior discussions in the archives or in the > (new) bug database would be useful. > > I didn't see command line access mentioned in any of the comments so > far. Many of us keep our repositories on servers and it would be be > great to be able to run a shell command to publish a change for > review. On the review side then having the ability to wget the patch > file without authentication would be useful too as sometimes it's > easier to just grab the patch and try out the changes. > > On the diffs then I think Jon summarized it well and being able to > support delta webrevs/equivalent would be very useful as we often go > through many iterations where the bulk of the changes are reviewed and > we're spinning on a final few issues. > > I don't have any comments on the workflow side of this except that > folks interested in an area should be able to subscribe so that they > get notifications of reviews and discussion for the areas that they > are interested in. Also the person seeking a review should be able to > accept reviews from folks that he/she didn't originally nominate to > review. > > -Alan. From swingler at apple.com Mon Apr 18 09:05:01 2011 From: swingler at apple.com (Mike Swingler) Date: Mon, 18 Apr 2011 09:05:01 -0700 Subject: OpenJDK Code review system - Request for use cases and requirements In-Reply-To: <4DAC1327.8080107@oracle.com> References: <0B2ED9E1-482E-47BB-8127-060E0F475687@oracle.com> <4DAC1327.8080107@oracle.com> Message-ID: On Apr 18, 2011, at 3:32 AM, Alan Bateman wrote: > Mohan Pakkurti wrote: > >> Hello >> >> I am looking at undertaking some projects to help improve the infrastructure for OpenJDK. >> One of the systems that is often requested is an open code review system, and I want to understand what we would want from this. >> >> I came across this blog entry http://blogs.sun.com/mr/entry/open_webrevs and want to get this discussion started again by asking you for input. >> >> What use cases would you have for this system? >> What features would you like to see in this system? What other systems and processes do you see the code review system integrate with? >> Any suggestions for systems we should consider for this? >> Do you have any other comments on this topic? >> >> Cheers >> Mohan > > I see all the replies so far are from Oracle folks and it would be good to get input from others too. It may also be useful to see what other open projects are using, if anything. We use ReviewBoard internally on the Java team at Apple, and are fairly pleased with it's simplicity to post, comment, comment on diffs, revise diffs, and re-comment on other comments. It has easily handled our custom bug tracking system URL format, and my only complaint is that our commits don't auto-close open reviews (but that's not really ReviewBoard's problem). Regards, Mike Swingler Java Engineering Apple Inc. From dalibor.topic at oracle.com Tue Apr 26 15:48:20 2011 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Wed, 27 Apr 2011 00:48:20 +0200 Subject: FYI: OpenJDK license file rebranding patch applied to the copy on web Message-ID: <4DB74BB4.5070000@oracle.com> Hi, I've applied the rebranding patch from [1] to the "GNU General Public License, version 2, with the Classpath Exception license" file on the OpenJDK website located at [2]. cheers, dalibor topic [1] "7013964: openjdk LICENSE file needs rebranding" at http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7013964 [2] http://openjdk.java.net/legal/gplv2+ce.html -- Oracle Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 | Mobile: +491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: J?rgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle Oracle is committed to developing practices and products that help protect the environment From Ulf.Zibis at gmx.de Wed Apr 27 01:15:14 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Wed, 27 Apr 2011 10:15:14 +0200 Subject: Wrong dates in mailing list ? Message-ID: <4DB7D092.8050000@gmx.de> Today I received about more than 50 posts from different *@openjdk.java.net mailing lists, dates spread over the last ~8 weeks. Are the as such old, or do they have wrong dates? Please refer to the screen shot in the attachment. -Ulf -------------- next part -------------- A non-text attachment was scrubbed... Name: Wrong dates in mailing list.png Type: image/png Size: 63732 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/web-discuss/attachments/20110427/5a8b869d/attachment-0001.png From David.Holmes at oracle.com Wed Apr 27 01:20:40 2011 From: David.Holmes at oracle.com (David Holmes) Date: Wed, 27 Apr 2011 18:20:40 +1000 Subject: Wrong dates in mailing list ? In-Reply-To: <4DB7D092.8050000@gmx.de> References: <4DB7D092.8050000@gmx.de> Message-ID: <4DB7D1D8.2090504@oracle.com> Hi Ulf Ulf Zibis said the following on 04/27/11 18:15: > Today I received about more than 50 posts from different > *@openjdk.java.net mailing lists, dates spread over the last ~8 weeks. > > Are the as such old, or do they have wrong dates? They are old. We (inside Oracle) have been complaining about missing emails to/from the openjdk lists for a few weeks. It seems that today someone finally found out where the blockage was and all those emails flooded out. We had initially thought it was restricted to oracle.com addresses but that is not the case. That said some of the emails I got today (and it was dozens dating back to early March) were ones I had seen before. David > Please refer to the screen shot in the attachment. > > -Ulf > > > ------------------------------------------------------------------------ > From weijun.wang at oracle.com Wed Apr 27 01:24:55 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 27 Apr 2011 16:24:55 +0800 Subject: Wrong dates in mailing list ? In-Reply-To: <4DB7D1D8.2090504@oracle.com> References: <4DB7D092.8050000@gmx.de> <4DB7D1D8.2090504@oracle.com> Message-ID: <4DB7D2D7.1070401@oracle.com> I even see some mails from myself. But I have no idea if they are old mails resent, or lost mails finally appear. Probably the latter. Too bad my iPod Touch thinks they are new mails and use the current date. -Max On 04/27/2011 04:20 PM, David Holmes wrote: > Hi Ulf > > Ulf Zibis said the following on 04/27/11 18:15: >> Today I received about more than 50 posts from different >> *@openjdk.java.net mailing lists, dates spread over the last ~8 weeks. >> >> Are the as such old, or do they have wrong dates? > > They are old. We (inside Oracle) have been complaining about missing > emails to/from the openjdk lists for a few weeks. It seems that today > someone finally found out where the blockage was and all those emails > flooded out. We had initially thought it was restricted to oracle.com > addresses but that is not the case. That said some of the emails I got > today (and it was dozens dating back to early March) were ones I had > seen before. > > David > >> Please refer to the screen shot in the attachment. >> >> -Ulf >> >> >> ------------------------------------------------------------------------ >> From Ulf.Zibis at gmx.de Wed Apr 27 01:44:38 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Wed, 27 Apr 2011 10:44:38 +0200 Subject: Wrong dates in mailing list ? In-Reply-To: <4DB7D1D8.2090504@oracle.com> References: <4DB7D092.8050000@gmx.de> <4DB7D1D8.2090504@oracle.com> Message-ID: <4DB7D776.6050209@gmx.de> In some lists I get *lost* mails, e.g. build-dev, in other I get *duplicates* for 80 % for the mails from last 8 weeks, e.g. compiler-dev See attachment... -Ulf Am 27.04.2011 10:20, schrieb David Holmes: > Hi Ulf > > Ulf Zibis said the following on 04/27/11 18:15: >> Today I received about more than 50 posts from different *@openjdk.java.net mailing lists, dates >> spread over the last ~8 weeks. >> >> Are the as such old, or do they have wrong dates? > > They are old. We (inside Oracle) have been complaining about missing emails to/from the openjdk > lists for a few weeks. It seems that today someone finally found out where the blockage was and > all those emails flooded out. We had initially thought it was restricted to oracle.com addresses > but that is not the case. That said some of the emails I got today (and it was dozens dating back > to early March) were ones I had seen before. > > David > >> Please refer to the screen shot in the attachment. >> >> -Ulf >> >> >> ------------------------------------------------------------------------ >> > -------------- next part -------------- A non-text attachment was scrubbed... Name: Duplcates in mailing list.png Type: image/png Size: 66747 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/web-discuss/attachments/20110427/4277c941/attachment-0001.png