January 2012 - core-libs-dev

Code Review - CR# 7030573 insufficient disk space for large file test
by Gary Adams 09 Jan '12

09 Jan '12

The LargeFileAvailable regression test had intermittent failures when there was not sufficient space available to create a 7G temp file. This webrev presents a simple check to see if the available usable space is less than 7G and scales the test back accordingly. The original bug report suggests that the test be switched to use the current working directory rather than a temp file. I think that could be the wrong choice for an embedded system that might have the tests mounted from a remote file system. In that scenario, using the local temp file space provides a better solution for what this test is designed to check. http://cr.openjdk.java.net/~gadams/7030573/

2 5

hg: jdk8/tl/jdk: 7123649: Remove public modifier from Math.powerOfTwoF.
by joe.darcy＠oracle.com 07 Jan '12

07 Jan '12

Changeset: 2050ff9dfc92 Author: darcy Date: 2012-01-06 18:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2050ff9dfc92 7123649: Remove public modifier from Math.powerOfTwoF. Reviewed-by: smarks, alanb ! src/share/classes/java/lang/Math.java

1 0

hg: jdk8/tl/jdk: 7033170: Cipher.getMaxAllowedKeyLength(String) throws NoSuchAlgorithmException
by valerie.peng＠oracle.com 07 Jan '12

07 Jan '12

Changeset: 6720ae7b1448 Author: valeriep Date: 2012-01-06 16:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6720ae7b1448 7033170: Cipher.getMaxAllowedKeyLength(String) throws NoSuchAlgorithmException Summary: Changed to always use full transformation as provider properties. Reviewed-by: mullan ! src/share/classes/sun/security/pkcs11/SunPKCS11.java ! test/javax/crypto/Cipher/GetMaxAllowed.java

1 0

hg: jdk8/tl/jdk: 2 new changesets
by valerie.peng＠oracle.com 06 Jan '12

06 Jan '12

Changeset: cdc128128044 Author: valeriep Date: 2012-01-05 18:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdc128128044 6414899: P11Digest should support cloning Summary: Enhanced the PKCS11 Digest implementation to support cloning Reviewed-by: vinnie ! make/sun/security/pkcs11/mapfile-vers ! src/share/classes/sun/security/pkcs11/P11Digest.java ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java ! src/share/lib/security/sunpkcs11-solaris.cfg ! src/share/native/sun/security/pkcs11/wrapper/pkcs11wrapper.h + test/sun/security/pkcs11/MessageDigest/TestCloning.java Changeset: e6ef778c1df4 Author: valeriep Date: 2012-01-06 11:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6ef778c1df4 Merge

1 0

hg: jdk8/tl/jdk: 7127235: (fs) NPE in Files.walkFileTree if cached attributes are GC'ed
by alan.bateman＠oracle.com 06 Jan '12

06 Jan '12

Changeset: 400cc379adb5 Author: alanb Date: 2012-01-06 15:00 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/400cc379adb5 7127235: (fs) NPE in Files.walkFileTree if cached attributes are GC'ed Reviewed-by: forax, chegar ! src/share/classes/java/nio/file/FileTreeWalker.java

1 0

Known issue? java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java
by Kelly O'Hair 05 Jan '12

05 Jan '12

Just wondering if anyone has seen this testcase failure. I'm using Fedora 9 x86. -kto -------------------------------------------------- TEST: java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java JDK under test: (/tmp/jprt/P1/143001.jprovino/testproduct/linux_i586_2.6-product) openjdk version "1.8.0-internal" OpenJDK Runtime Environment (build 1.8.0-internal-201112301430.jprovino.jprovino-ref-51-b00) OpenJDK Client VM (build 23.0-b08, mixed mode, sharing) ACTION: build -- Passed. Build successful REASON: User specified action: run build MulticastSendReceiveTests NetworkConfiguration TIME: 0.086 seconds messages: command: build MulticastSendReceiveTests NetworkConfiguration reason: User specified action: run build MulticastSendReceiveTests NetworkConfiguration elapsed time (seconds): 0.086 ACTION: compile -- Passed. Compilation successful REASON: .class file out of date or does not exist TIME: 0.085 seconds messages: command: compile /tmp/jprt/P1/143001.jprovino/source/jdk/test/java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java reason: .class file out of date or does not exist elapsed time (seconds): 0.085 ACTION: build -- Passed. All files up to date REASON: Named class compiled on demand TIME: 0.0 seconds messages: command: build MulticastSendReceiveTests reason: Named class compiled on demand elapsed time (seconds): 0.0 ACTION: main -- Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Expected message not recieved REASON: User specified action: run main MulticastSendReceiveTests TIME: 5.056 seconds messages: command: main MulticastSendReceiveTests reason: User specified action: run main MulticastSendReceiveTests elapsed time (seconds): 5.056 STDOUT: Test DatagramChannel to INET socket join 225.4.5.6 @ virbr0 Send message from 192.168.122.1 -> group 225.4.5.6 (id=0x23b98c4a) Waiting to receive message STDERR: java.lang.RuntimeException: Expected message not recieved at MulticastSendReceiveTests.receiveDatagram(MulticastSendReceiveTests.java:99) at MulticastSendReceiveTests.test(MulticastSendReceiveTests.java:171) at MulticastSendReceiveTests.main(MulticastSendReceiveTests.java:229) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:474) at com.sun.javatest.regtest.MainAction$SameVMRunnable.run(MainAction.java:680) at java.lang.Thread.run(Thread.java:722) JavaTest Message: Test threw exception: java.lang.RuntimeException JavaTest Message: shutting down test TEST RESULT: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Expected message not recieved --------------------------------------------------

2 3

Code review request for #6469160, #7088271
by Brandon Passanisi 04 Jan '12

04 Jan '12

Resending... Hello core-libs. I was wondering of somebody could be please review the following fix for #6469160 and #7088271. The changes in the webrev fix both bugs. Information is below: Webrev URL: http://cr.openjdk.java.net/~bpassani/6469160_7088271/1/ <http://cr.openjdk.java.net/%7Ebpassani/6469160_7088271/1/> Bug #6469160: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6469160 Bug #7088271: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7088271 Both bugs uncover the current behavior where using a 0 or 1 precision value with a float zero causes an ArrayIndexOutOfBoundsException. The current code in FormattedFloatingDecimal.java interprets the float zero as "0.0" in the case where precision is 0 or 1 and returns the length of it's characters as 3. Later in Formatter.addZeros(), the character array "0.0" is passed in, but a new array of only 1 character is allocated. When an System.arraycopy() is performed, the ArrayIndexOutOfBoundsException occurs. In fact, when run with "-esa" an AssertionError occurs at "assert (outPrec <= prec);" on line 3393 of Formatter.java. The fix is for FormatedFloatingDecimal.java to interpret the float zero as a single "0" because of the precision being set to 0 or 1. Since java has been throwing exceptions in these cases, I consulted with the output of C's printf to make sure that the outputted strings are the same. I updated the Formatter's Basic-X template of tests with a little over 20 test format strings that were causing exceptions without the change and the output of each is compared with the output from C's printf with the same format string. And, I ran all of the Basic-X tests to make sure there weren't any regressions in behavior. Thanks. -- Oracle <http://www.oracle.com> Brandon Passanisi | Principle Member of Technical Staff Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment

1 0

Review request for #6783209
by Brandon Passanisi 04 Jan '12

04 Jan '12

Hello core-libs-dev. Can someone please do a code review of the following proposed fix for 6783209 : (fmt)Formatter doesn't support width for %%. Webrev : http://cr.openjdk.java.net/~bpassani/6783209/0/webrev/ Bug URL: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6783209 The fix is to use justify() within Formatter.java to do the proper padding when using the '%' conversion. I have included a new test program to test instances of format specifiers that use the '%' conversion with a width value. The test also includes the testing of '%' without a width to ensure there aren't regressions. Thanks. -- Oracle <http://www.oracle.com> Brandon Passanisi | Principle Member of Technical Staff Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment

4 5

hg: jdk8/tl/jdk: 7104647: Adding a diagnostic command framework
by frederic.parain＠oracle.com 04 Jan '12

04 Jan '12

Changeset: 0194fe5ca404 Author: fparain Date: 2012-01-04 03:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0194fe5ca404 7104647: Adding a diagnostic command framework Reviewed-by: mchung, dholmes ! make/common/Release.gmk ! make/java/management/mapfile-vers ! make/launchers/Makefile ! make/sun/tools/Makefile + src/linux/doc/man/jcmd.1 + src/share/classes/com/sun/management/DiagnosticCommandArgumentInfo.java + src/share/classes/com/sun/management/DiagnosticCommandInfo.java ! src/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java ! src/share/classes/sun/management/HotSpotDiagnostic.java ! src/share/classes/sun/tools/attach/HotSpotVirtualMachine.java + src/share/classes/sun/tools/jcmd/Arguments.java + src/share/classes/sun/tools/jcmd/JCmd.java ! src/share/javavm/export/jmm.h ! src/share/native/sun/management/HotSpotDiagnostic.c + src/solaris/doc/sun/man/man1/jcmd.1 + test/com/sun/management/HotSpotDiagnosticMXBean/ExecuteDiagnosticCommand.java + test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommandInfo.java + test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommands.java ! test/sun/tools/common/CommonSetup.sh + test/sun/tools/jcmd/dcmd-script.txt + test/sun/tools/jcmd/help_help.out + test/sun/tools/jcmd/jcmd-Defaults.sh + test/sun/tools/jcmd/jcmd-f.sh + test/sun/tools/jcmd/jcmd-help-help.sh + test/sun/tools/jcmd/jcmd-help.sh + test/sun/tools/jcmd/jcmd-pid.sh + test/sun/tools/jcmd/jcmd_Output1.awk + test/sun/tools/jcmd/jcmd_pid_Output1.awk + test/sun/tools/jcmd/jcmd_pid_Output2.awk + test/sun/tools/jcmd/usage.out

1 0

hg: jdk8/tl/langtools: 7046929: tools/javac/api/T6397104.java fails
by jim.holmlund＠sun.com 04 Jan '12

04 Jan '12

Changeset: a07eef109532 Author: jjh Date: 2012-01-03 17:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a07eef109532 7046929: tools/javac/api/T6397104.java fails Reviewed-by: jjg ! test/tools/javac/api/T6397104.java

1 0