January 2012 - core-libs-dev

hg: jdk8/tl/jdk: 7068856: (fs) Typo in Files.isSameFile() javadoc; ...
by alan.bateman＠oracle.com 11 Jan '12

11 Jan '12

Changeset: 82144054d2d8 Author: alanb Date: 2012-01-11 13:07 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82144054d2d8 7068856: (fs) Typo in Files.isSameFile() javadoc 7099208: (fs) Files.newBufferedReader has typo in javadoc Reviewed-by: forax ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/Path.java

1 0

hg: jdk8/tl/jdk: 7128648: HttpURLConnection.getHeaderFields should return an unmodifiable Map
by chris.hegarty＠oracle.com 11 Jan '12

11 Jan '12

Changeset: 31a1fc60a895 Author: chegar Date: 2012-01-11 10:52 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31a1fc60a895 7128648: HttpURLConnection.getHeaderFields should return an unmodifiable Map Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/java/net/HttpURLConnection/UnmodifiableMaps.java

1 0

Code review request for trivial javadoc issue in Throwable
by Joe Darcy 11 Jan '12

11 Jan '12

Hello, Please review this simple fix to the javadoc of java.lang.Throwable; use of "<" and ">" rather than "<" and ">" currently causes malformed HTML to be generated. --- a/src/share/classes/java/lang/Throwable.java Tue Jan 10 17:12:11 2012 -0800 +++ b/src/share/classes/java/lang/Throwable.java Tue Jan 10 17:17:27 2012 -0800 @@ -625,7 +625,7 @@ * at Resource2.close(Resource2.java:20) * at Foo4.main(Foo4.java:5) * Caused by: java.lang.Exception: Rats, you caught me - * at Resource2$CloseFailException.<init>(Resource2.java:45) + * at Resource2$CloseFailException.<init>(Resource2.java:45) * ... 2 more * </pre> */ After the review, I'll file a bug and do the push, etc. Thanks, -Joe

4 3

hg: jdk8/tl/jdk: 7128931: Bad HTML escaping in java.lang.Throwable javadoc
by joe.darcy＠oracle.com 11 Jan '12

11 Jan '12

Changeset: 62dbcbe4c446 Author: darcy Date: 2012-01-10 17:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62dbcbe4c446 7128931: Bad HTML escaping in java.lang.Throwable javadoc Reviewed-by: mduigou ! src/share/classes/java/lang/Throwable.java

1 0

Please review: 7125442
by Kumar Srinivasan 11 Jan '12

11 Jan '12

Hi, Please review: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125442 Webrev: http://cr.openjdk.java.net/~ksrini/7124443/ Thanks Kumar

4 6

hg: jdk8/tl/jdk: 7112008: Javadoc for j.l.Object.finalize() vs JLS 12.6 Finalization of Class Instances
by joe.darcy＠oracle.com 11 Jan '12

11 Jan '12

Changeset: 49e64a8fc18f Author: darcy Date: 2012-01-10 17:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49e64a8fc18f 7112008: Javadoc for j.l.Object.finalize() vs JLS 12.6 Finalization of Class Instances Reviewed-by: mduigou ! src/share/classes/java/lang/Object.java

1 0

CFV: New core-libs Group Member: David Holmes
by Alan Bateman 10 Jan '12

10 Jan '12

I hereby nominate David Holmes to membership of the core-libs group. David doesn't need too much introduction. He is a reviewer on several OpenJDK projects, including the HotSpot Express project, JDK 7 and JDK 8. He is a prolific reviewer, particularly for library changes discussed on the core-libs mailing list. He's also a committer for the Lambda Project and well known from his membership of JSR-166 that brought us java.util.concurrent and more. Votes are due by Jan 18, 2012, 23.59 PST. Only current members of the core-libs group [1] are eligible to vote on this nomination. For lazy consensus voting instructions, see [2]. -Alan. [1] http://openjdk.java.net/census#core-libs [2] http://openjdk.java.net/groups/#member-vote

9 8

CFV: New core-libs Group Member: Brian Goetz
by Alan Bateman 10 Jan '12

10 Jan '12

I hereby nominate Brian Goetz to membership of the core-libs group. Brian doesn't need too much introduction. He's lead for OpenJDK's Project Lambda, and while this project is sponsored by the compiler group, is all about the libraries and their evolution too. He's an existing committer on the JDK 7 and JDK 8 projects and well known from his membership of JSR-166 that brought us java.util.concurrent and more. Votes are due by Jan 18, 2012, 23.59 PST. Only current members of the core-libs group [1] are eligible to vote on this nomination. For lazy consensus voting instructions, see [2]. -Alan. [1] http://openjdk.java.net/census#core-libs [2] http://openjdk.java.net/groups/#member-vote

8 7

JDK 8 code review request for 7112008 Javadoc for j.l.Object.finalize() vs JLS 12.6 Finalization of Class Instances
by Joe Darcy 10 Jan '12

10 Jan '12

Hello, Please review this small doc cleanup of java.lang.Object: 7112008 Javadoc for j.l.Object.finalize() vs JLS 12.6 Finalization of Class Instances http://cr.openjdk.java.net/~darcy/7112008.0/ Full patch below inline. Thanks, -Joe --- old/src/share/classes/java/lang/Object.java 2012-01-10 13:04:42.000000000 -0800 +++ new/src/share/classes/java/lang/Object.java 2012-01-10 13:04:42.000000000 -0800 @@ -58,8 +58,7 @@ * * @return The {@code Class} object that represents the runtime * class of this object. - * @see Class Literals, section 15.8.2 of - * <cite>The Java™ Language Specification</cite>. + * @jls 15.8.2 Class Literals */ public final native Class<?> getClass(); @@ -92,7 +91,7 @@ * objects. (This is typically implemented by converting the internal * address of the object into an integer, but this implementation * technique is not required by the - * JavaTM programming language.) + * Java™ programming language.) * * @return a hash code value for this object. * @see java.lang.Object#equals(java.lang.Object) @@ -203,7 +202,7 @@ * exception at run time. * * @return a clone of this instance. - * @exception CloneNotSupportedException if the object's class does not + * @throws CloneNotSupportedException if the object's class does not * support the {@code Cloneable} interface. Subclasses * that override the {@code clone} method can also * throw this exception to indicate that an instance cannot @@ -264,7 +263,7 @@ * * Only one thread at a time can own an object's monitor. * - * @exception IllegalMonitorStateException if the current thread is not + * @throws IllegalMonitorStateException if the current thread is not * the owner of this object's monitor. * @see java.lang.Object#notifyAll() * @see java.lang.Object#wait() @@ -288,7 +287,7 @@ * description of the ways in which a thread can become the owner of * a monitor. * - * @exception IllegalMonitorStateException if the current thread is not + * @throws IllegalMonitorStateException if the current thread is not * the owner of this object's monitor. * @see java.lang.Object#notify() * @see java.lang.Object#wait() @@ -368,11 +367,11 @@ * a monitor. * * @param timeout the maximum time to wait in milliseconds. - * @exception IllegalArgumentException if the value of timeout is + * @throws IllegalArgumentException if the value of timeout is * negative. - * @exception IllegalMonitorStateException if the current thread is not + * @throws IllegalMonitorStateException if the current thread is not * the owner of the object's monitor. - * @exception InterruptedException if any thread interrupted the + * @throws InterruptedException if any thread interrupted the * current thread before or while the current thread * was waiting for a notification. The interrupted * status of the current thread is cleared when @@ -433,12 +432,12 @@ * @param timeout the maximum time to wait in milliseconds. * @param nanos additional time, in nanoseconds range * 0-999999. - * @exception IllegalArgumentException if the value of timeout is + * @throws IllegalArgumentException if the value of timeout is * negative or the value of nanos is * not in the range 0-999999. - * @exception IllegalMonitorStateException if the current thread is not + * @throws IllegalMonitorStateException if the current thread is not * the owner of this object's monitor. - * @exception InterruptedException if any thread interrupted the + * @throws InterruptedException if any thread interrupted the * current thread before or while the current thread * was waiting for a notification. The interrupted * status of the current thread is cleared when @@ -489,9 +488,9 @@ * description of the ways in which a thread can become the owner of * a monitor. * - * @exception IllegalMonitorStateException if the current thread is not + * @throws IllegalMonitorStateException if the current thread is not * the owner of the object's monitor. - * @exception InterruptedException if any thread interrupted the + * @throws InterruptedException if any thread interrupted the * current thread before or while the current thread * was waiting for a notification. The interrupted * status of the current thread is cleared when @@ -510,7 +509,7 @@ * system resources or to perform other cleanup. * * The general contract of {@code finalize} is that it is invoked - * if and when the JavaTM virtual + * if and when the Java™ virtual * machine has determined that there is no longer any * means by which this object can be accessed by any thread that has * not yet died, except as a result of an action taken by the @@ -549,6 +548,9 @@ * ignored. * * @throws Throwable the {@code Exception} raised by this method + * @see java.lang.ref.WeakReference + * @see java.lang.ref.PhantomReference + * @jls 12.6 Finalization of Class Instances */ protected void finalize() throws Throwable { } }

1 0

hg: jdk8/tl/jdk: 7128584: Typo in sun.misc.VM's private directMemory field comment
by chris.hegarty＠oracle.com 10 Jan '12

10 Jan '12

Changeset: bba276a6aa0d Author: chegar Date: 2012-01-10 12:48 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bba276a6aa0d 7128584: Typo in sun.misc.VM's private directMemory field comment Reviewed-by: forax, chegar Contributed-by: Krystal Mok <sajia(a)taobao.com> ! src/share/classes/sun/misc/VM.java

1 0