October 2012 - core-libs-dev

hg: jdk8/tl/jdk: 8000806: Implement runtime lambda metafactory
by robert.field＠oracle.com 26 Oct '12

26 Oct '12

Changeset: 6302932b7380 Author: rfield Date: 2012-10-25 17:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6302932b7380 8000806: Implement runtime lambda metafactory Summary: Implement lambda invokedynamic bootstrap by generating at runtime an inner class that implements the functional interface Reviewed-by: twisti + src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java + src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java + src/share/classes/java/lang/invoke/LambdaConversionException.java + src/share/classes/java/lang/invoke/LambdaMetafactory.java + src/share/classes/java/lang/invoke/MagicLambdaImpl.java + src/share/classes/java/lang/invoke/TypeConvertingMethodAdapter.java

1 0

hg: jdk8/tl/jdk: 8001565: (fs) Typo Path.endsWith(String) javadoc
by mandy.chung＠oracle.com 25 Oct '12

25 Oct '12

Changeset: 27677928a937 Author: dxu Date: 2012-10-25 15:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27677928a937 8001565: (fs) Typo Path.endsWith(String) javadoc Reviewed-by: mchung, jgish, lancea ! src/share/classes/java/nio/file/Path.java

1 0

Review Request: JDK-8001565, (fs) Typo Path.endsWith(String) javadoc
by Dan Xu 25 Oct '12

25 Oct '12

Hi, Please help review the javadoc typo fix at, http://cr.openjdk.java.net/~dxu/8001565/webrev/. Thanks! -Dan

4 5

hg: jdk8/tl/jdk: 7159567: inconsistent configuration of MemoryHandler
by mandy.chung＠oracle.com 25 Oct '12

25 Oct '12

Changeset: 37a4b4892e8e Author: jgish Date: 2012-10-25 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37a4b4892e8e 7159567: inconsistent configuration of MemoryHandler Reviewed-by: mchung, alanb ! src/share/classes/java/util/logging/ConsoleHandler.java ! src/share/classes/java/util/logging/FileHandler.java ! src/share/classes/java/util/logging/MemoryHandler.java ! src/share/classes/java/util/logging/SocketHandler.java ! src/share/classes/java/util/logging/StreamHandler.java + test/java/util/logging/MemoryHandlerTest.java + test/java/util/logging/MemoryHandlerTest.props

1 0

hg: jdk8/tl/langtools: 6725230: Java Compilation with Jsr199 ignores Class-Path in manifest
by jonathan.gibbons＠oracle.com 25 Oct '12

25 Oct '12

Changeset: ea2616a6bd01 Author: jjg Date: 2012-10-25 13:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ea2616a6bd01 6725230: Java Compilation with Jsr199 ignores Class-Path in manifest Reviewed-by: jjg, mcimadamore Contributed-by: vicente.romero(a)oracle.com ! src/share/classes/com/sun/tools/javac/file/Locations.java + test/tools/javac/Paths/TestCompileJARInClassPath.java

1 0

hg: jdk8/tl/langtools: 7200915: convert TypeTags from a series of small ints to an enum
by jonathan.gibbons＠oracle.com 25 Oct '12

25 Oct '12

Changeset: c002fdee76fd Author: jjg Date: 2012-10-25 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c002fdee76fd 7200915: convert TypeTags from a series of small ints to an enum Reviewed-by: jjg, mcimadamore Contributed-by: vicente.romero(a)oracle.com ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Type.java + src/share/classes/com/sun/tools/javac/code/TypeTag.java - src/share/classes/com/sun/tools/javac/code/TypeTags.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/ConstFold.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/UninitializedType.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/util/Constants.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterizedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! test/tools/javac/6889255/T6889255.java ! test/tools/javac/tree/MakeLiteralTest.java

1 0

RFR: 7159567 - inconsistent configuration of MemoryHandler
by Jim Gish 25 Oct '12

25 Oct '12

Please review http://cr.openjdk.java.net/~jgish/Bug7159567-set-MemoryHandler-target/ <http://cr.openjdk.java.net/%7Ejgish/Bug7159567-set-MemoryHandler-target/> Overview - currently you can sub-class java.util.logging.MemoryHandler and specify its configuration in a logging.properties file via the classname. For example, if com.foo.MyMemoryHandler extends MemoryHandler, you can have: logging.properties: com.foo.MyMemoryHandler.push=WARNING com.foo.MyMemoryHandler.level=FINEST .... etc. However, the only way to specify target is by using the global property, java.util.logging.MemoryHandler.target. For example, java.util.logging.MemoryHandler.target=java.util.logging.ConsoleHandler This is clearly broken. This bug fix allows you to say: com.foo.MyMemoryHandler.target=java.util.logging.ConsoleHandler Thanks, Jim -- Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304 Oracle Java Platform Group | Core Libraries Team 35 Network Drive Burlington, MA 01803 jim.gish(a)oracle.com

3 17

Request for review : 7088913 :
by Mike Duigou 25 Oct '12

25 Oct '12

A long, long time ago (2011) there was a review request[1] for CR#7088913 : Add compatible static hashCode(primitive) to primitive wrapper classes The change was approved by the three cc:ed reviewers. At that time the webrev was co-mingled with another changeset that had more controversial changes. Neither changeset was committed and 7088913 got ignored and eventually forgotten. Until now. Since so much time has passed I am asking for review again so that the commit is not a surprise to anyone. The webrev incorporates Joe's suggestions from long ago and now including an expanded (though probably not complete) unit test. http://cr.openjdk.java.net/~mduigou/7088913/1/webrev/ Mike [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-September/007733.…

3 2

hg: jdk8/tl/jdk: 8000203: File descriptor leak in src/solaris/native/java/net/net_util_md.c
by chris.hegarty＠oracle.com 24 Oct '12

24 Oct '12

Changeset: 909676adaefd Author: chegar Date: 2012-10-24 21:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/909676adaefd 8000203: File descriptor leak in src/solaris/native/java/net/net_util_md.c Reviewed-by: dsamersoff, khazra, chegar Contributed-by: John Zavgren <john.zavgren(a)oracle.com> ! src/solaris/native/java/net/net_util_md.c

1 0

hg: jdk8/tl/jdk: 6976971: TEST: javax/management/remote/mandatory/URLTest.java should be re-integrated
by alan.bateman＠oracle.com 24 Oct '12

24 Oct '12

Changeset: 8e8fcd44b963 Author: jbachorik Date: 2012-10-24 20:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e8fcd44b963 6976971: TEST: javax/management/remote/mandatory/URLTest.java should be re-integrated Reviewed-by: alanb ! test/javax/management/remote/mandatory/URLTest.java

1 0