October 2012 - core-libs-dev

hg: jdk8/tl/jdk: 8001046: java/util/PluggableLocale/LocaleNameProviderTest.sh failing
by naoto.sato＠oracle.com 17 Oct '12

17 Oct '12

Changeset: 60994591be6b Author: naoto Date: 2012-10-17 13:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60994591be6b 8001046: java/util/PluggableLocale/LocaleNameProviderTest.sh failing Reviewed-by: okutsu ! test/java/util/PluggableLocale/barprovider.jar

1 0

hg: jdk8/tl/jdk: 8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods
by alan.bateman＠oracle.com 17 Oct '12

17 Oct '12

Changeset: b265ead7f331 Author: alanb Date: 2012-10-17 21:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b265ead7f331 8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods Reviewed-by: lancea, chegar, mchung, ksrini ! src/share/classes/java/util/jar/Pack200.java

1 0

hg: jdk8/tl/jdk: 7198496: (sl) ServiceLoader.load(Class, null) behavior differs from spec
by alan.bateman＠oracle.com 17 Oct '12

17 Oct '12

Changeset: 586028bbf885 Author: psandoz Date: 2012-10-17 20:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/586028bbf885 7198496: (sl) ServiceLoader.load(Class, null) behavior differs from spec Reviewed-by: dholmes, alanb ! src/share/classes/java/util/ServiceLoader.java ! test/java/util/ServiceLoader/Basic.java ! test/java/util/ServiceLoader/basic.sh

1 0

hg: jdk8/tl/jdk: 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false
by mandy.chung＠oracle.com 17 Oct '12

17 Oct '12

Changeset: 6156b9235758 Author: mchung Date: 2012-10-17 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6156b9235758 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false Reviewed-by: alanb, ohair ! make/common/internal/Defs-jaxws.gmk

1 0

RFR (S): 8000999: backport of JSR 292 to 7u
by Christian Thalinger 17 Oct '12

17 Oct '12

http://cr.openjdk.java.net/~twisti/8000999 8000999: backport of JSR 292 to 7u Reviewed-by: This is an umbrella bug for these changes (which are backported in one changeset): 6983728: JSR 292 remove argument count limitations 7128512: Javadoc typo in java.lang.invoke.MethodHandle 7117167: Misc warnings in java.lang.invoke and sun.invoke.* 7129034: VM crash with a field setter method with a filterArguments 7087658: MethodHandles.Lookup.findVirtual is confused by interface methods that are multiply inherited 7127687: MethodType leaks memory due to interning 7023639: JSR 292 method handle invocation needs a fast path for compiled code 7188911: nightly failures after JSR 292 lazy method handle update (round 2) 7190416: JSR 292: typo in InvokerBytecodeGenerator.getConstantPoolSize 7191102: nightly failures after JSR 292 lazy method handle update (round 3) 7194612: api/java_lang/invoke/MethodHandles/Lookup/index.html#ExceptionsTests[findVirtualNSME] fails w/ -esa 7194662: JSR 292: PermuteArgsTest times out in nightly test runs The backport is just copying over the files from JDK 8. That's why the webrev is so big and pretty useless. The real changes between 8 and 7 are these: diff -Nur jdk8/src/share/classes/java/lang/invoke/MethodHandleStatics.java jdk7u/src/share/classes/java/lang/invoke/MethodHandleStatics.java --- jdk8/src/share/classes/java/lang/invoke/MethodHandleStatics.java 2012-10-15 12:21:52.806052959 -0700 +++ jdk7u/src/share/classes/java/lang/invoke/MethodHandleStatics.java 2012-10-16 10:48:29.728257304 -0700 @@ -94,10 +94,14 @@ // handy shared exception makers (they simplify the common case code) /*non-public*/ static InternalError newInternalError(String message, Throwable cause) { - return new InternalError(message, cause); + InternalError e = new InternalError(message); + e.initCause(cause); + return e; } /*non-public*/ static InternalError newInternalError(Throwable cause) { - return new InternalError(cause); + InternalError e = new InternalError(); + e.initCause(cause); + return e; } /*non-public*/ static RuntimeException newIllegalStateException(String message) { return new IllegalStateException(message); diff -Nur jdk8/src/share/classes/sun/invoke/util/ValueConversions.java jdk7u/src/share/classes/sun/invoke/util/ValueConversions.java --- jdk8/src/share/classes/sun/invoke/util/ValueConversions.java 2012-10-16 10:49:36.081911283 -0700 +++ jdk7u/src/share/classes/sun/invoke/util/ValueConversions.java 2012-10-16 10:48:19.626424849 -0700 @@ -1211,9 +1211,13 @@ // handy shared exception makers (they simplify the common case code) private static InternalError newInternalError(String message, Throwable cause) { - return new InternalError(message, cause); + InternalError e = new InternalError(message); + e.initCause(cause); + return e; } private static InternalError newInternalError(Throwable cause) { - return new InternalError(cause); + InternalError e = new InternalError(); + e.initCause(cause); + return e; } } diff --git a/src/share/classes/sun/misc/Unsafe.java b/src/share/classes/sun/misc/Unsafe.java --- a/src/share/classes/sun/misc/Unsafe.java +++ b/src/share/classes/sun/misc/Unsafe.java @@ -678,6 +678,14 @@ public native Object staticFieldBase(Field f); /** + * Detect if the given class may need to be initialized. This is often + * needed in conjunction with obtaining the static field base of a + * class. + * @return false only if a call to {@code ensureClassInitialized} would have no effect + */ + public native boolean shouldBeInitialized(Class c); + + /** * Ensure the given class has been initialized. This is often * needed in conjunction with obtaining the static field base of a * class.

2 2

hg: jdk8/tl/langtools: 7192245: Add parser support for default methods
by maurizio.cimadamore＠oracle.com 17 Oct '12

17 Oct '12

Changeset: 12cf6bfd8c05 Author: mcimadamore Date: 2012-10-17 16:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/12cf6bfd8c05 7192245: Add parser support for default methods Summary: Add support for 'default' keyword in modifier position Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/javac/defaultMethods/syntax/TestDefaultMethodsSyntax.java + test/tools/javac/diags/examples/DefaultMethodNotSupported.java

1 0

RFR (M): 8000989: smaller code changes to make future JSR 292 backports easier
by Christian Thalinger 17 Oct '12

17 Oct '12

http://cr.openjdk.java.net/~twisti/8000989 8000989: smaller code changes to make future JSR 292 backports easier Reviewed-by: In 8 we added two new constructors to InternalError which we use in 292. Factor InternalError generation to a method to make future backports to 7u easier. src/share/classes/java/lang/invoke/BoundMethodHandle.java src/share/classes/java/lang/invoke/CallSite.java src/share/classes/java/lang/invoke/DirectMethodHandle.java src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java src/share/classes/java/lang/invoke/Invokers.java src/share/classes/java/lang/invoke/LambdaForm.java src/share/classes/java/lang/invoke/MemberName.java src/share/classes/java/lang/invoke/MethodHandle.java src/share/classes/java/lang/invoke/MethodHandleImpl.java src/share/classes/java/lang/invoke/MethodHandleStatics.java src/share/classes/sun/invoke/util/ValueConversions.java test/java/lang/invoke/BigArityTest.java test/java/lang/invoke/PrivateInvokeTest.java

3 4

hg: jdk8/tl/jdk: 6809322: javax.management.timer.Timer does not fire all notifications
by dmitry.samersoff＠oracle.com 17 Oct '12

17 Oct '12

Changeset: b2d8a99a049e Author: dsamersoff Date: 2012-10-17 18:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2d8a99a049e 6809322: javax.management.timer.Timer does not fire all notifications Summary: Some notifications get dropped due to ConcurrentModificationException thrown in Timer.notifyAlarmClock() method. Reviewed-by: dholmes, rbackman Contributed-by: jaroslav.bachorik(a)oracle.com ! src/share/classes/javax/management/timer/Timer.java + test/javax/management/timer/MissingNotificationTest.java

1 0

Hashtable.Entry.hashCode() no longer conforms to Map.Entry.hashCode()
by Neil Richards 17 Oct '12

17 Oct '12

Hi, I notice that the behaviour of java.util.Hashtable.Entry.hashCode() no longer conforms to the defined behaviour (in the Java API Javadoc [1]) for java.util.Map.Entry.hashCode() implementations. The code in Hashtable.Entry.hashCode() assumes that the value in Hashtable.Entry.hash will always be the same as that for Hashtable.Entry.getKey().hashCode() . However, since Java bug 7126277 (Alternative String hashing implementation), the use of Hashtable.hashSeed, a randomizing factor, has been introduced into the calculation of Hashtable.hash(). It is the result from Hashtable.hash() which ends up stored in the Hashtable.Entry.hash field. So the assumption made in Hashtable.Entry.hashCode() is no longer valid, and the code needs to be corrected, so that it once more complies with the Java API defined behaviour. I have created a webrev [2] with my suggested fix for this problem, together with a simple testcase to demonstrate it. (I've also checked the other Map implementations modified by 7126277, and verified that the others still conform to the Java API in this regard). Please review the problem and suggested fix, and let me know your thoughts. I am not aware of an existing Java bug for this issue. Provided you agree with my analysis, could one be raised to allow the fix to be committed? Thanks, Neil [1] http://docs.oracle.com/javase/7/docs/api/java/util/Map.Entry.html#hashCode%… [2] http://cr.openjdk.java.net/~ngmr/hashtable-entry-hashcode-fix/webrev.00 -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

4 7

hg: jdk8/tl/jdk: 8000955: Hashtable.Entry.hashCode() does not conform to Map.Entry.hashCode() defined behaviour
by neil.richards＠ngmr.net 17 Oct '12

17 Oct '12

Changeset: 5eed4a92ca8c Author: ngmr Date: 2012-10-17 13:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5eed4a92ca8c 8000955: Hashtable.Entry.hashCode() does not conform to Map.Entry.hashCode() defined behaviour Reviewed-by: mduigou, alanb ! src/share/classes/java/util/Hashtable.java + test/java/util/Map/EntryHashCode.java

1 0