March 2012 - core-libs-dev

hg: jdk8/tl/langtools: 3 new changesets
by maurizio.cimadamore＠oracle.com 06 Mar '12

06 Mar '12

Changeset: dda6a5b15580 Author: mcimadamore Date: 2012-03-06 13:26 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dda6a5b15580 7148622: Some diagnostic methods do not go through Log.report Summary: Deferred lint diagnostics ignore Log settings such as deferred diagnostics Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java Changeset: 48ee63caaa93 Author: mcimadamore Date: 2012-03-06 13:28 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/48ee63caaa93 7144506: Attr.checkMethod should be called after inference variables have been fixed Summary: Unify post-inference sanity check with Attr.checkMethod Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! test/tools/javac/6758789/T6758789b.out ! test/tools/javac/generics/6723444/T6723444.out ! test/tools/javac/generics/7015430/T7015430.out Changeset: 38ae13dcd215 Author: mcimadamore Date: 2012-03-06 13:29 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/38ae13dcd215 7133238: Merge proto-kind and proto-type into a single result class Summary: Restructure attribution code so that the check-logic can be encapsulated into a single class Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java

1 0

Code review request: 6961765: Double byte characters corrupted in DN for LDAP referrals
by Weijun Wang 06 Mar '12

06 Mar '12

Hi Vinnie This bug is about using UrlUtil.decode() to decode a URL that is not fully encoded, i.e. including non-ASCII characters. The webrev is at http://cr.openjdk.java.net/~weijun/6961765/webrev.00/ It simply delegates the call to URLDecoder.decode(). LDAP URL (RFC 4516 2.1) specifies that only <reserved>, <unreserved>, and <pct-encoded> chars can be used, which do not include general non-ASCII unicode. So precisely the user input in the bug report is illegal, but since it's already a valid URL/URI in Java, we can somehow be more friendly. In fact, the javadoc of URLDecoder [1] also only allows these characters, but at the same time it says -- There are two possible ways in which this decoder could deal with illegal strings. It could either leave illegal characters alone or it could throw an IllegalArgumentException. Which approach the decoder takes is left to the implementation. Now the Oracle implementation of the class "leave illegal characters alone". In this sense, UrlUtil is not as good as URLDecoder. It neither leaves them alone nor throws an exception. To be more correct, I think we can update URLDecoder so that it leaves Unicode in the "other" category (non-control, non-whitespace non-ASCII Unicode chars, as described in URI's spec) unchanged, and throw an exception otherwise (that is, non-ASCII, and control or space). But I'll leave that to another RFE. Thanks Max -------- Original Message -------- *Change Request ID*: 6961765 *Synopsis*: Double byte characters corrupted in DN for LDAP referrals === *Description* ============================================================ SYNOPSIS -------- Double byte characters corrupted in DN for LDAP referrals OPERATING SYSTEM ---------------- All FULL JDK VERSION ---------------- All DESCRIPTION ----------- If the DN component of an LDAP URL contains double byte characters, it is corrupted by com.sun.jndi.toolkit.url.UrlUtil.decode(). This corruption leads to application level failures. Consider the following scenario: 1. Application connects to an LDAP server and searches for the string uid=???,??? (where ??? are double byte characters) 2. JNDI code receives a referral, for example: ldap://www.test.com/uid=???,???,ou=people,ou=test,ou=test,o=test 3. The referral is then parsed to split the hostname, port number and the DN element of the URI via com.sun.jndi.ldap.LdapURL.parsePathAndQuery() 4. The DN element is decoded using com.sun.jndi.toolkit.url.UrlUtil.decode() 5. This method expects the characters to be ASCII. If the characters are non-ASCII, as in our example, then those characters are not converted properly. 6. This corrupted DN is then passed to the LDAP server, resulting in an unexpected failure. TESTCASE -------- This testcase does not represent normal application code. It highlights the problem by calling into com.sun.* internal classes directly. This allows the problem to be demonstrated without setting up an LDAP server. import java.net.URI; import java.net.URLDecoder; import com.sun.jndi.ldap.LdapURL; public class LdapURLTest { public static void main (String args[]) throws Exception { String testString = ("ldap://www.test.com/uid=\u3070\u3073\u3076,\u3079\u307C\u307E,ou=test,ou=te…"); LdapURL ldURL = new LdapURL(testString); System.out.println(" LDAP URL String: " + testString); System.out.println(" decoded DN: " + ldURL.getDN()); // suggested fix demonstration String DN; String path = new URI(testString).getPath(); DN = path.startsWith("/") ? path.substring(1) : path; String proposedDN = URLDecoder.decode(DN, "UTF8"); System.out.println("\nDN from proposed fix: " + proposedDN); } } SUGGESTED FIX ------------- Use java.net.URLDecoder rather than com.sun.jndi.toolkit.url.UrlUtil to conduct the URL decoding in parsePathAndQuery(). Specifically, change the line that decodes the DN element in com.sun.jndi.ldap.LdapURL.parsePathAndQuery() from: DN = path.startsWith("/") ? path.substring(1) : path; if (DN.length() > 0) { --> DN = UrlUtil.decode(DN, "UTF8"); <-- } to: DN = path.startsWith("/") ? path.substring(1) : path; if (DN.length() > 0) { --> DN = URLDecoder.decode(DN, "UTF8"); <-- } === *Evaluation* ============================================================= The URL in the testcase has an invalid encoding. Its Unicode characters must be encoded in UTF-8. For example, \u3070 -> \e3\81\b0 -> %5Ce3%5C81%5Cb0

2 1

Code review request: 7151348: Build breaks due to warning clean up in sun.rmi.*(7146763)
by Kurchi Hazra 06 Mar '12

06 Mar '12

Hi, jdk8 build is breaking if SKIP_BOOT_CYCLE is set to false due to some changes made as a part of warnings cleanup in sun.rmi.* (see 7146763) that are incompatible with the code in the corba respository. This CR is simply to revert back the changes made to files in sun/rmi/rmic for the time being. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151348 (Not available yet) Webrev: http://cr.openjdk.java.net/~khazra/7151348/webrev.00/ Thanks, Kurchi

2 2

hg: jdk8/tl/jdk: 7149012: jarsigner needs not warn about cert expiration if the jar has a TSA timestamp
by weijun.wang＠oracle.com 06 Mar '12

06 Mar '12

Changeset: 26ed9a64a318 Author: weijun Date: 2012-03-06 10:25 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/26ed9a64a318 7149012: jarsigner needs not warn about cert expiration if the jar has a TSA timestamp Reviewed-by: xuelei ! src/share/classes/sun/security/tools/JarSigner.java

1 0

Asking about the interesting behaviours of TreeMap.putAll
by Charles Lee 06 Mar '12

06 Mar '12

Hi guys, I have a small test case[1] and the two invokes of putAll have different behaviors: the first invocation does not use the override put but the second invocation does. The root cause about this can be find in the TreeMap code: /if (size==0 && mapSize!=0 && map instanceof SortedMap) { Comparator c = ((SortedMap)map).comparator(); if (c == comparator || (c != null && c.equals(comparator))) { ++modCount; try { buildFromSorted(mapSize, map.entrySet().iterator(), null, null); } catch (java.io.IOException cannotHappen) { } catch (ClassNotFoundException cannotHappen) { } return; } }/ When meet some situations, buildFromSorted will be invoked instead of put. I understand it is a speed up, but it may confuse people: "I need my own put because of something, but interestingly sometimes it will not be called when putAll and I do not find the reason from the api spec." From the api spec of TreeMap's putAll, it says nothing about put. But from the api spec of AbstractMap's putAll and Map's putAll, they said: / "The effect of this call is equivalent to that of calling put(k, v) on this map once for each mapping from key k to value v in the specified map. " /The spec clearly say that, putAll will use put, that means, we can not use a putAll in an override put. Otherwise, it will recursive endlessly. So can I use a putAll in the override put method in an class which extends the TreeMap? [1] public class TreeMapTest<K, V> extends TreeMap<K, V> { @Override public V put(K key, V value) { System.out.println(key + " : " + value); return super.put(key, value); } /** * @param args */ public static void main(String[] args) { TreeMapTest<Integer, Integer> mTreeMap = new TreeMapTest<>(); TreeMap<Integer, Integer> mt = new TreeMap<>(); mt.put(1, 1); mTreeMap.putAll(mt); mTreeMap.clear(); mTreeMap.put(2, 2); mTreeMap.putAll(mt); } } -- Yours Charles

4 11

hg: jdk8/tl/jdk: 7151348: Build breaks due to warning clean up in sun.rmi.*(7146763)
by kurchi.subhra.hazra＠oracle.com 06 Mar '12

06 Mar '12

Changeset: ce6b852bf4e2 Author: khazra Date: 2012-03-05 17:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce6b852bf4e2 7151348: Build breaks due to warning clean up in sun.rmi.*(7146763) Summary: Undo changes to sun/rmi/rmic/* commited as fix for 7146763 Reviewed-by: smarks ! src/share/classes/sun/rmi/rmic/BatchEnvironment.java ! src/share/classes/sun/rmi/rmic/Main.java ! src/share/classes/sun/rmi/rmic/RMIGenerator.java ! src/share/classes/sun/rmi/rmic/newrmic/Main.java ! src/share/classes/sun/rmi/rmic/newrmic/Resources.java

1 0

hg: jdk8/tl/jdk: 7078053: Solaris JDK build: C compiler writing tmp files into the make tree
by philip.race＠oracle.com 05 Mar '12

05 Mar '12

Changeset: 8b4309cbd999 Author: prr Date: 2012-03-05 09:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8b4309cbd999 7078053: Solaris JDK build: C compiler writing tmp files into the make tree Reviewed-by: ohair, alanb ! make/java/nio/Makefile ! make/sun/xawt/Makefile

1 0

hg: jdk8/tl/jdk: 2 new changesets
by vincent.x.ryan＠oracle.com 05 Mar '12

05 Mar '12

Changeset: a9840446d677 Author: vinnie Date: 2012-03-05 14:13 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a9840446d677 7151109: backout CR 6988842 Reviewed-by: mullan ! make/sun/security/Makefile ! src/share/classes/sun/security/pkcs11/Config.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java ! test/ProblemList.txt ! test/sun/security/pkcs11/PKCS11Test.java - test/sun/security/pkcs11/nss/lib/README - test/sun/security/pkcs11/nss/lib/windows-amd64/freebl3.chk - test/sun/security/pkcs11/nss/lib/windows-amd64/freebl3.dll - test/sun/security/pkcs11/nss/lib/windows-amd64/libnspr4.dll - test/sun/security/pkcs11/nss/lib/windows-amd64/libnspr4.lib - test/sun/security/pkcs11/nss/lib/windows-amd64/libplc4.dll - test/sun/security/pkcs11/nss/lib/windows-amd64/libplc4.lib - test/sun/security/pkcs11/nss/lib/windows-amd64/libplds4.dll - test/sun/security/pkcs11/nss/lib/windows-amd64/libplds4.lib - test/sun/security/pkcs11/nss/lib/windows-amd64/nss3.dll - test/sun/security/pkcs11/nss/lib/windows-amd64/nss3.lib - test/sun/security/pkcs11/nss/lib/windows-amd64/nssckbi.dll - test/sun/security/pkcs11/nss/lib/windows-amd64/nssdbm3.chk - test/sun/security/pkcs11/nss/lib/windows-amd64/nssdbm3.dll - test/sun/security/pkcs11/nss/lib/windows-amd64/nssutil3.dll - test/sun/security/pkcs11/nss/lib/windows-amd64/nssutil3.lib - test/sun/security/pkcs11/nss/lib/windows-amd64/softokn3.chk - test/sun/security/pkcs11/nss/lib/windows-amd64/softokn3.dll - test/sun/security/pkcs11/nss/lib/windows-amd64/sqlite3.dll - test/sun/security/pkcs11/nss/lib/windows-amd64/ssl3.dll - test/sun/security/pkcs11/nss/lib/windows-amd64/ssl3.lib - test/sun/security/pkcs11/nss/lib/windows-i586/freebl3.chk - test/sun/security/pkcs11/nss/lib/windows-i586/freebl3.dll ! test/sun/security/pkcs11/nss/lib/windows-i586/libnspr4.dll - test/sun/security/pkcs11/nss/lib/windows-i586/libnspr4.lib ! test/sun/security/pkcs11/nss/lib/windows-i586/libplc4.dll - test/sun/security/pkcs11/nss/lib/windows-i586/libplc4.lib ! test/sun/security/pkcs11/nss/lib/windows-i586/libplds4.dll - test/sun/security/pkcs11/nss/lib/windows-i586/libplds4.lib ! test/sun/security/pkcs11/nss/lib/windows-i586/nss3.dll - test/sun/security/pkcs11/nss/lib/windows-i586/nss3.lib ! test/sun/security/pkcs11/nss/lib/windows-i586/nssckbi.dll - test/sun/security/pkcs11/nss/lib/windows-i586/nssdbm3.chk - test/sun/security/pkcs11/nss/lib/windows-i586/nssdbm3.dll - test/sun/security/pkcs11/nss/lib/windows-i586/nssutil3.dll - test/sun/security/pkcs11/nss/lib/windows-i586/nssutil3.lib - test/sun/security/pkcs11/nss/lib/windows-i586/softokn3.chk ! test/sun/security/pkcs11/nss/lib/windows-i586/softokn3.dll - test/sun/security/pkcs11/nss/lib/windows-i586/sqlite3.dll - test/sun/security/pkcs11/nss/lib/windows-i586/ssl3.dll - test/sun/security/pkcs11/nss/lib/windows-i586/ssl3.lib ! test/sun/security/pkcs11/nss/p11-nss.txt ! test/sun/security/tools/keytool/autotest.sh Changeset: 4785a6d4ae15 Author: vinnie Date: 2012-03-05 14:15 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4785a6d4ae15 Merge

1 0

hg: jdk8/tl/jdk: 7145043: HttpServerProvider.java:81: warning - @code("httpServerProvider") is an unknown tag
by chris.hegarty＠oracle.com 04 Mar '12

04 Mar '12

Changeset: f67ff7b0f6ae Author: chegar Date: 2012-03-04 07:41 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f67ff7b0f6ae 7145043: HttpServerProvider.java:81: warning - @code("httpServerProvider") is an unknown tag Reviewed-by: michaelm ! src/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java

1 0

hg: jdk8/tl/jdk: 7146763: Warnings cleanup in the sun.rmi and related packages
by kurchi.subhra.hazra＠oracle.com 02 Mar '12

02 Mar '12

Changeset: 8f61ac5986ee Author: khazra Date: 2012-03-02 13:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f61ac5986ee 7146763: Warnings cleanup in the sun.rmi and related packages Summary: Cleanup warnings and use jkd7 features in sun.rmi.* Reviewed-by: smarks, chegar, forax, dmocek ! make/sun/rmi/cgi/Makefile ! make/sun/rmi/registry/Makefile ! make/sun/rmi/rmi/Makefile ! make/sun/rmi/rmid/Makefile ! src/share/classes/com/sun/rmi/rmid/ExecOptionPermission.java ! src/share/classes/com/sun/rmi/rmid/ExecPermission.java ! src/share/classes/sun/rmi/log/ReliableLog.java ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! src/share/classes/sun/rmi/rmic/BatchEnvironment.java ! src/share/classes/sun/rmi/rmic/Main.java ! src/share/classes/sun/rmi/rmic/RMIGenerator.java ! src/share/classes/sun/rmi/rmic/newrmic/Main.java ! src/share/classes/sun/rmi/rmic/newrmic/Resources.java ! src/share/classes/sun/rmi/server/ActivatableRef.java ! src/share/classes/sun/rmi/server/Activation.java ! src/share/classes/sun/rmi/server/ActivationGroupImpl.java ! src/share/classes/sun/rmi/server/LoaderHandler.java ! src/share/classes/sun/rmi/server/MarshalInputStream.java ! src/share/classes/sun/rmi/server/UnicastRef.java ! src/share/classes/sun/rmi/server/UnicastRef2.java ! src/share/classes/sun/rmi/server/UnicastServerRef.java ! src/share/classes/sun/rmi/server/Util.java ! src/share/classes/sun/rmi/server/WeakClassHashMap.java ! src/share/classes/sun/rmi/transport/ConnectionInputStream.java ! src/share/classes/sun/rmi/transport/DGCAckHandler.java ! src/share/classes/sun/rmi/transport/DGCClient.java ! src/share/classes/sun/rmi/transport/DGCImpl.java ! src/share/classes/sun/rmi/transport/ObjectTable.java ! src/share/classes/sun/rmi/transport/StreamRemoteCall.java ! src/share/classes/sun/rmi/transport/Target.java ! src/share/classes/sun/rmi/transport/Transport.java ! src/share/classes/sun/rmi/transport/WeakRef.java ! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java ! src/share/classes/sun/rmi/transport/proxy/HttpInputStream.java ! src/share/classes/sun/rmi/transport/proxy/HttpSendSocket.java ! src/share/classes/sun/rmi/transport/proxy/RMIMasterSocketFactory.java ! src/share/classes/sun/rmi/transport/tcp/ConnectionMultiplexer.java ! src/share/classes/sun/rmi/transport/tcp/TCPChannel.java ! src/share/classes/sun/rmi/transport/tcp/TCPEndpoint.java ! src/share/classes/sun/rmi/transport/tcp/TCPTransport.java

1 0