March 2012 - core-libs-dev

hg: jdk8/tl/jdk: 2 new changesets
by chris.hegarty＠oracle.com 13 Mar '12

13 Mar '12

Changeset: e0bf958097e2 Author: chegar Date: 2012-03-13 09:33 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0bf958097e2 7152796: TEST_BUG: java/net/Socks/SocksV4Test.java does not terminate Reviewed-by: alanb ! test/java/net/Socks/SocksServer.java ! test/java/net/Socks/SocksV4Test.java Changeset: 939197ee597e Author: chegar Date: 2012-03-13 12:08 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/939197ee597e Merge

1 0

hg: jdk8/tl/jdk: 7149608: Default TZ detection fails on linux when symbolic links to non default location used.
by sean.coffey＠oracle.com 13 Mar '12

13 Mar '12

Changeset: 6bbafa8404eb Author: coffeys Date: 2012-03-13 11:01 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6bbafa8404eb 7149608: Default TZ detection fails on linux when symbolic links to non default location used. Reviewed-by: alanb, okutsu ! src/solaris/native/java/util/TimeZone_md.c

1 0

RFR : 7149608 (tz): Default TZ detection fails on linux when symbolic links to non default location used.
by Seán Coffey 13 Mar '12

13 Mar '12

Issue seen on somewhat irregular linux system configuration where /etc/localtime is a symbolic link to a directory outside of /usr/share/zoneinfo. In past, when a symbolic link was seen, the end target file was assumed to be under /usr/share/zoneinfo and a string comparison match was attempted. We need to factor in the case where symbolic link points to any other location and match the end target file with a TZ file from /usr/share/zoneinfo via findZoneinfoFile function. webrev : http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8/ bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7149608 regards, Sean.

3 10

RFR : 7148584 Jar tools fails to generate manifest correctly when boundary condition hit
by Seán Coffey 12 Mar '12

12 Mar '12

Issue seen when the inner Manifest.FastInputStream.peek() method is called just as we hit EOF of main buffer being parsed (the manifest input file) Simple fix involves getting peek() to return -1 if a fill() request fails to read anything. webrev : http://cr.openjdk.java.net/~coffeys/webrev.7148584.jdk8/ Bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7148584 regards, Sean.

4 6

hg: jdk8/tl/jdk: 7148584: Jar tools fails to generate manifest correctly when boundary condition hit
by sean.coffey＠oracle.com 12 Mar '12

12 Mar '12

Changeset: 134d9f4f9498 Author: coffeys Date: 2012-03-12 11:30 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/134d9f4f9498 7148584: Jar tools fails to generate manifest correctly when boundary condition hit Reviewed-by: alanb, sherman ! src/share/classes/java/util/jar/Manifest.java + test/java/util/jar/Manifest/CreateManifest.java

1 0

hg: jdk8/tl/jdk: 7152866: Tests not run because they are missing the @run tag
by alan.bateman＠oracle.com 12 Mar '12

12 Mar '12

Changeset: 6d934b1d9dd5 Author: alanb Date: 2012-03-12 10:17 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d934b1d9dd5 7152866: Tests not run because they are missing the @run tag Reviewed-by: chegar, dholmes ! test/ProblemList.txt - test/java/io/File/isDirectory/Applet.html ! test/java/io/Serializable/badSubstByReplace/BadSubstByReplace.java ! test/java/io/Serializable/replaceStringArray/ReplaceStringArray.java ! test/java/io/Serializable/replaceWithNull/ReplaceWithNull.java ! test/java/io/Serializable/verifyDynamicObjHandleTable/VerifyDynamicObjHandleTable.java ! test/java/nio/file/Files/CustomOptions.java ! test/java/text/Bidi/Bug6850113.java ! test/javax/naming/spi/DirectoryManager/GetContDirCtx.java ! test/sun/misc/Cleaner/exitOnThrow.sh ! test/sun/nio/cs/OLD/TestIBMDB.java - test/sun/nio/cs/OLD/TestX11CS.java ! test/sun/security/ssl/com/sun/net/ssl/SSLSecurity/ProviderTest.java

1 0

7152866: Tests not run because they are missing the @run tag
by Alan Bateman 12 Mar '12

12 Mar '12

I was looking at a test and happen to notice that it had a @build tag but no @run tag so the test wasn't actually running as expected (it wasn't a compile-only test). This prompted me to do a quick audit and I found several other tests with similar issues. The following webrev fixes the test description of several of these tests: http://cr.openjdk.java.net/~alanb/7152866/webrev/ Note that I didn't fix all the tests. It turns out that some of these tests don't compile or or fail on one or more platforms. I've created bugs for these [1]. TestX11CS.java is one case where it's not worth trying to fix it to compile so I propose to delete it. I've used the opportunity to remove some tests from the ProblemList while I was there. Thanks, Alan. [1] 7152856: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing on Windows 7152799: javax/naming/spi/DirectoryManager/GetContDirCtx.java failing with CannotProceedException 7152798: TEST_BUG: sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java does not compile 7152796: TEST_BUG: java/net/Socks/SocksV4Test.java does not terminate

4 7

java.util.zip.Deflater: needsInput() returns true after finish()
by Zhong Yu 10 Mar '12

10 Mar '12

In java.util.zip.Deflater, after finish() is called, needsInput() may still return true. This is counter-intuitive. It's probably not an issue in blocking style IO, since state is implied by context, code (lexically) after finish() knows it doesn't make sense to call needsInput(). In non-blocking IO, code needs another flag to remember that finish() has been called, so that it won't call needsInput() again (which may return a misleading true). That's an unnecessary chore, since Deflater already contains the flag. Suggested fix: java.util.zip.Deflater public boolean needsInput() { synchronized (zsRef) { return !finish && len <= 0; } } (I don't understand the `synchronized (zsRef)` part; this class should only be used serially anyway. But if other methods require synchronization, this method requires it too) Regards, Zhong Yu

1 0

hg: jdk8/tl/langtools: 7151802: compiler update caused sqe test failed
by maurizio.cimadamore＠oracle.com 09 Mar '12

09 Mar '12

Changeset: 97bec6ab1227 Author: mcimadamore Date: 2012-03-09 17:10 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/97bec6ab1227 7151802: compiler update caused sqe test failed Summary: Fix regression caused by 7144506 Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! test/tools/javac/6758789/T6758789b.out ! test/tools/javac/generics/7015430/T7015430.out + test/tools/javac/generics/7151802/T7151802.java + test/tools/javac/generics/7151802/T7151802.out

1 0

hg: jdk8/tl/jdk: 7151595: Disable creation of db demos if NO_DEMOS is specified
by mike.duigou＠oracle.com 08 Mar '12

08 Mar '12

Changeset: 2900d4ae2d39 Author: mduigou Date: 2012-03-08 13:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2900d4ae2d39 7151595: Disable creation of db demos if NO_DEMOS is specified Reviewed-by: weijun, dholmes ! make/common/Release.gmk

1 0