March 2012 - core-libs-dev

Suggestion about including pthread.h
by Shi Jun Zhang 22 Mar '12

22 Mar '12

Hi, Currently jdk/src/solaris/bin/java_md.c includes <pthread.h> with "#ifdef __linux__", but BSD, MAC OS, AIX all needs to include pthread.h. To avoid the situation that the ifdef clause becomes longer and longer like "#if defined(__linux__) || defined(_ALLBSD_SOURCE) || defined(AIX) || defined(OTHER_PLATFORMS)", i suggest to use USE_PTHREADS already defined in jdk/make/common/Defs-linux.gmk and add a compiler flag if USE_PTHREADS is true. It will look like this: ifeq ($(USE_PTHREADS), true) CPPFLAGS_COMMON += -DUSE_PTHREADS endif And then all the places need to include pthread.h only needs to use "#ifdef USE_PTHREADS". The files include pthread.h are jdk/src/solaris/bin/java_md.c jdk/src/solaris/native/sun/nio/ch/NativeThread.c jdk/src/solaris/transport/socket/socket_md.c Any comments? -- Regards, Shi Jun Zhang

4 16

hg: jdk8/tl/jdk: 7155300: Include pthread.h on all POSIX platforms except Solaris to improve portability
by littlee＠linux.vnet.ibm.com 22 Mar '12

22 Mar '12

Changeset: 1d418ec212ea Author: zhangshj Date: 2012-03-22 12:30 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d418ec212ea 7155300: Include pthread.h on all POSIX platforms except Solaris to improve portability Reviewed-by: alanb, dholmes ! src/solaris/bin/java_md.c ! src/solaris/transport/socket/socket_md.c

1 0

RFR 7065380 : Allow Collections.sort to sort Collections.singletonList() result
by Mike Duigou 21 Mar '12

21 Mar '12

Hello all; Currently Collections.sort() refuses to sort the lists which result from calling Collections.singletonList(). This makes some sense because the singleton lists are immutable but they are also alway sorted. This patch allows Collections.sort() to be used with empty and singleton lists of all types. A short circuit return is provided for lists of length 0 and 1 as they are already sorted. WEBREV @ http://cr.openjdk.java.net/~mduigou/7065380/0/webrev/ For the unit test ignore the diffs and view the "New" file--webrev doesn't understand "hg copy". Thanks, Mike

11 18

hg: jdk8/tl/jdk: 7146728: Inconsistent length for the generated secret using DH key agreement impl from SunJCE and PKCS11
by valerie.peng＠oracle.com 20 Mar '12

20 Mar '12

Changeset: 4c4d2337dfad Author: valeriep Date: 2012-03-20 15:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c4d2337dfad 7146728: Inconsistent length for the generated secret using DH key agreement impl from SunJCE and PKCS11 Summary: Always return the secret in the same length as the modulus. Reviewed-by: wetmore ! src/share/classes/com/sun/crypto/provider/DHKeyAgreement.java ! src/share/classes/sun/security/pkcs11/P11KeyAgreement.java ! test/com/sun/crypto/provider/KeyAgreement/DHKeyAgreement2.java + test/sun/security/pkcs11/KeyAgreement/TestInterop.java ! test/sun/security/pkcs11/KeyAgreement/TestShort.java

1 0

Re: No replaceLast() method in String
by Mike Duigou 20 Mar '12

20 Mar '12

I took a look through the bug database and can't find a reason (if there was one). It's likely not implemented because Matcher doesn't implement replaceLast(). Mike On Mar 20 2012, at 09:28 , Alex Kravets wrote: > Hi, > > I was looking at String API and noticed that there are methods for string > replacement: replace, replaceAll, replaceFirst but no replaceLast. Without > getting into detail of how to implement replaceLat (I know how), why was > this method not included in String API? I am just curious about this. > > Thanks, > Alex

2 1

hg: jdk8/tl/jdk: 7154114: jstat tests failing on non-english locales; ...
by staffan.larsen＠oracle.com 20 Mar '12

20 Mar '12

Changeset: 2dc35f14bf17 Author: sla Date: 2012-03-20 12:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2dc35f14bf17 7154114: jstat tests failing on non-english locales 7154113: jcmd, jps and jstat tests failing when there are unknown Java processes on the system Reviewed-by: rbackman, kamg, dsamersoff ! test/sun/tools/jcmd/jcmd_Output1.awk ! test/sun/tools/jps/jps-l_Output1.awk ! test/sun/tools/jps/jps_Output1.awk ! test/sun/tools/jstat/jstatClassOutput1.sh ! test/sun/tools/jstat/jstatClassloadOutput1.sh ! test/sun/tools/jstat/jstatCompilerOutput1.sh ! test/sun/tools/jstat/jstatFileURITest1.sh ! test/sun/tools/jstat/jstatGcCapacityOutput1.sh ! test/sun/tools/jstat/jstatGcCauseOutput1.sh ! test/sun/tools/jstat/jstatGcNewCapacityOutput1.sh ! test/sun/tools/jstat/jstatGcNewOutput1.sh ! test/sun/tools/jstat/jstatGcOldCapacityOutput1.sh ! test/sun/tools/jstat/jstatGcOldOutput1.sh ! test/sun/tools/jstat/jstatGcOutput1.sh ! test/sun/tools/jstat/jstatGcPermCapacityOutput1.sh ! test/sun/tools/jstat/jstatLineCounts1.sh ! test/sun/tools/jstat/jstatLineCounts2.sh ! test/sun/tools/jstat/jstatLineCounts3.sh ! test/sun/tools/jstat/jstatLineCounts4.sh ! test/sun/tools/jstat/jstatOptions1.sh ! test/sun/tools/jstat/jstatPrintCompilationOutput1.sh ! test/sun/tools/jstat/jstatSnap1.sh ! test/sun/tools/jstat/jstatSnap2.sh ! test/sun/tools/jstat/jstatTimeStamp1.sh ! test/sun/tools/jstatd/jpsOutput1.awk ! test/sun/tools/jstatd/jstatdDefaults.sh ! test/sun/tools/jstatd/jstatdExternalRegistry.sh ! test/sun/tools/jstatd/jstatdPort.sh ! test/sun/tools/jstatd/jstatdServerName.sh

1 0

hg: jdk8/tl/jdk: 7152176: More krb5 tests
by weijun.wang＠oracle.com 20 Mar '12

20 Mar '12

Changeset: 0d1c576980a0 Author: weijun Date: 2012-03-20 19:12 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0d1c576980a0 7152176: More krb5 tests Reviewed-by: xuelei + test/sun/security/krb5/auto/Basic.java ! test/sun/security/krb5/auto/Context.java + test/sun/security/krb5/auto/GSS.java ! test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/auto/TwoTab.java

1 0

hg: jdk8/tl/jdk: 7152798: TEST_BUG: sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java does not compile
by staffan.larsen＠oracle.com 19 Mar '12

19 Mar '12

Changeset: 3b50a4971a1a Author: sla Date: 2012-03-19 14:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b50a4971a1a 7152798: TEST_BUG: sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java does not compile Summary: Make sure the test is compiled, run and finds it supporting classes Reviewed-by: alanb, sspitsyn, rbackman ! test/sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java

1 0

hg: jdk8/tl/jdk: 7152007: Fix warnings in sun/rmi/rmic
by kurchi.subhra.hazra＠oracle.com 16 Mar '12

16 Mar '12

Changeset: 337d4570b8d6 Author: khazra Date: 2012-03-16 11:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/337d4570b8d6 7152007: Fix warnings in sun/rmi/rmic Summary: Minor code changes to remove warnings in sun/rmi/rmic Reviewed-by: chegar, smarks ! src/share/classes/sun/rmi/rmic/BatchEnvironment.java ! src/share/classes/sun/rmi/rmic/Main.java ! src/share/classes/sun/rmi/rmic/RMIGenerator.java ! src/share/classes/sun/rmi/rmic/newrmic/Main.java ! src/share/classes/sun/rmi/rmic/newrmic/Resources.java

1 0

hg: jdk8/tl/jdk: 7145419: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events.
by rickard.backman＠oracle.com 16 Mar '12

16 Mar '12

Changeset: fa957635aa40 Author: rbackman Date: 2012-03-14 08:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fa957635aa40 7145419: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events. Summary: Add more packages to filter avoids failing on events from background thread. Reviewed-by: acorn, sspitsyn, sla ! test/com/sun/jdi/EarlyReturnTest.java ! test/com/sun/jdi/MethodEntryExitEvents.java ! test/com/sun/jdi/MethodExitReturnValuesTest.java

1 0