June 2012 - core-libs-dev

hg: jdk8/tl/jdk: 7175413: Typo in comments of JVM_SupportsCX8 in jvm.h
by chris.hegarty＠oracle.com 08 Jun '12

08 Jun '12

Changeset: abe465d6a9b8 Author: chegar Date: 2012-06-08 09:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abe465d6a9b8 7175413: Typo in comments of JVM_SupportsCX8 in jvm.h Reviewed-by: chegar Contributed-by: Krystal Mok <sajia(a)taobao.com> ! src/share/javavm/export/jvm.h

1 0

typo in comments of JVM_SupportsCX8 in jvm.h
by Krystal Mok 08 Jun '12

08 Jun '12

Hi all, As discussed on hotspot-compiler-dev [1], I came across a typo in the exported jvm.h in the jdk workspace while working on 7174218. The fix is simple [2], and sync up with the changes in 7174218: diff -r 7def50698e78 src/share/javavm/export/jvm.h --- a/src/share/javavm/export/jvm.h Thu May 24 16:15:58 2012 -0700 +++ b/src/share/javavm/export/jvm.h Wed Jun 06 01:15:50 2012 +0800 @@ -595,7 +595,7 @@ JVM_AssertionStatusDirectives(JNIEnv *env, jclass unused); /* - * java.util.concurrent.AtomicLong + * java.util.concurrent.atomic.AtomicLong */ JNIEXPORT jboolean JNICALL JVM_SupportsCX8(void); Could someone review and sponsor this fix, please? Regards, Kris Mok [1]: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2012-June/00779… [2]: https://gist.github.com/2876357#file_remove_atomic_long_cs_impl_jdk.patch

3 4

[7u6] RFR (JAXP) : 7157608: One feature is not recognized.
by Joe Wang 08 Jun '12

08 Jun '12

The feature is: http://apache.org/xml/features/standard-uri-conformant True: Requires that a URI has to be provided where a URI is expected. False: Some invalid URI's are accepted as valid values when a URI is expected. Examples include: using platform dependent file separator in place of '/'; using Windows/DOS path names like "c:\blah" and "\\host\dir\blah"; using invalid URI characters (space, for example). I'm not sure why it was left out during jdk6 development. The implementation code was in the RI except the part that add the feature to the recognized list. It does appear to me a useful feature in cases such as when a file with the path generated in the Windows environment is provided to the parser. Since the impl code is in, fixing the issue is basically adding the feature to the recognized list as listed below: webrev: http://cr.openjdk.java.net/~joehw/7u6/7157608/webrev/ copied here: diff --git a/src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java b/src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java --- a/src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java +++ b/src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java @@ -182,7 +182,8 @@ protected static final String PARSER_SET EXTERNAL_GENERAL_ENTITIES, EXTERNAL_PARAMETER_ENTITIES, ALLOW_JAVA_ENCODINGS, - WARN_ON_DUPLICATE_ENTITYDEF + WARN_ON_DUPLICATE_ENTITYDEF, + STANDARD_URI_CONFORMANT }; /** Feature defaults. */ @@ -192,6 +193,7 @@ protected static final String PARSER_SET Boolean.TRUE, Boolean.TRUE, Boolean.FALSE, + Boolean.FALSE }; Thanks, Joe

2 1

hg: jdk8/tl/jaxp: 7151118: Regressions on 7u4 b11 comp. 7u4 b06 on specjvm2008.xml.transform subbenchmark
by huizhe.wang＠oracle.com 07 Jun '12

07 Jun '12

Changeset: 633700642caf Author: joehw Date: 2012-06-07 13:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/633700642caf 7151118: Regressions on 7u4 b11 comp. 7u4 b06 on specjvm2008.xml.transform subbenchmark Summary: roll back XalanJ-2271 that caused the regression Reviewed-by: lancea ! src/com/sun/org/apache/xml/internal/serializer/CharInfo.java ! src/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java ! src/com/sun/org/apache/xml/internal/serializer/ToStream.java ! src/com/sun/org/apache/xml/internal/serializer/ToXMLStream.java

1 0

hg: jdk8/tl/jdk: 7174736: JCK test api/java_util/HashMap/index_EntrySet failing
by mike.duigou＠oracle.com 07 Jun '12

07 Jun '12

Changeset: fc0e508b713f Author: mduigou Date: 2012-06-07 01:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc0e508b713f 7174736: JCK test api/java_util/HashMap/index_EntrySet failing Summary: Corrects a problem with HashMap.removeEntry() that caused a JCK test to fail Reviewed-by: mduigou Contributed-by: alan.bateman(a)oracle.com ! src/share/classes/java/util/HashMap.java

1 0

[PATCH] 7164256 : EnumMap.clone doesn't clear the entrySet field, keeping a reference to the original Map
by Diego Belfer 07 Jun '12

07 Jun '12

Hello, I have reported a bug in the implementation of the clone method of the EnumMap class. The instance field entrySet is not being cleared, so the entrySet field of the new instance references to the original EnumMap. I am providing a simple patch for review. It adds one line to the clone method that sets the entrySet field to null. This is my first contribution to the OpenJDK, so let me know if I am missing some step of the process. Thanks, Diego Belfer [muralx]

4 11

hg: jdk8/tl/jdk: 7174723: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing [win]
by alan.bateman＠oracle.com 07 Jun '12

07 Jun '12

Changeset: 23f8be788c77 Author: alanb Date: 2012-06-07 18:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23f8be788c77 7174723: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing [win] Reviewed-by: mduigou ! test/java/lang/ProcessBuilder/Basic.java

1 0

[7u6] RFR (JAXP) : 7151118: Regressions on 7u4 b11 comp. 7u4 b06 on specjvm2008.xml.transform subbenchmark
by Joe Wang 07 Jun '12

07 Jun '12

I tested through all of the Xalan updates and found XalanJ-2271 to be the culprit. It [1] was intended to improve performance in webserver environment while resolving unescaped chars in attributes. Unfortunately, it actually resulted in a 5% drop in specjvm2008. I tried to improve the patch, by for example not making mutable copies of the CharInfo objects and etc., but none could get all of the performance loss back. Since it was a proactive update, meaning no one requested it, instead of spending too much time on this issue, I decided to roll the entire patch back. Below is the webrev [2]. [1] https://issues.apache.org/jira/browse/XALANJ-2271 [2] http://cr.openjdk.java.net/~joehw/7u6/cr7151118/webrev/ All unit/sqe/tck tests passed. Please review. Thanks, Joe

2 1

hg: jdk8/tl/jdk: 7175041: HttpTimestamper should accept https URI
by weijun.wang＠oracle.com 07 Jun '12

07 Jun '12

Changeset: 9b814b887240 Author: weijun Date: 2012-06-07 22:33 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9b814b887240 7175041: HttpTimestamper should accept https URI Reviewed-by: mullan ! src/share/classes/sun/security/timestamp/HttpTimestamper.java

1 0

7174723: java/lang/ProcessBuilder/Basic.java failing [win]
by Alan Bateman 07 Jun '12

07 Jun '12

Mike, ProcessBuilder/Basic.java has been failing on Windows since the hash work went into jdk8/tl. This test is 11500 tests in one and the removeMappings fix fixes some of the failures. I looked into remaining issues today and it's another assumption on iteration order. A child process prints out the map of its environment variables and the parent assumes the order that they come back. I've changed the test so that the child process sorts them and adjusted the order that the parent expects. This means the test is passing again on all platforms. Attached is the patch. Assuming you are okay with then then we can push it after you push the fix for 7174736. -Alan diff --git a/test/java/lang/ProcessBuilder/Basic.java b/test/java/lang/ProcessBuilder/Basic.java --- a/test/java/lang/ProcessBuilder/Basic.java +++ b/test/java/lang/ProcessBuilder/Basic.java @@ -248,6 +248,7 @@ public class Basic { private static String getenvAsString(Map<String,String> environment) { StringBuilder sb = new StringBuilder(); + environment = new TreeMap<>(environment); for (Map.Entry<String,String> e : environment.entrySet()) // Ignore magic environment variables added by the launcher if (! e.getKey().equals("NLSPATH") && @@ -1625,7 +1626,7 @@ public class Basic { childArgs.add("System.getenv()"); String[] cmdp = childArgs.toArray(new String[childArgs.size()]); String[] envp; - String[] envpWin = {"=ExitValue=3", "=C:=\\", "SystemRoot="+systemRoot}; + String[] envpWin = {"=C:=\\", "=ExitValue=3", "SystemRoot="+systemRoot}; String[] envpOth = {"=ExitValue=3", "=C:=\\"}; if (Windows.is()) { envp = envpWin; @@ -1633,7 +1634,7 @@ public class Basic { envp = envpOth; } Process p = Runtime.getRuntime().exec(cmdp, envp); - String expected = Windows.is() ? "=C:=\\,SystemRoot="+systemRoot+",=ExitValue=3," : "=C:=\\,"; + String expected = Windows.is() ? "=C:=\\,=ExitValue=3,SystemRoot="+systemRoot+"," : "=C:=\\,"; String commandOutput = commandOutput(p); if (MacOSX.is()) { commandOutput = removeMacExpectedVars(commandOutput); @@ -1690,7 +1691,7 @@ public class Basic { commandOutput = removeMacExpectedVars(commandOutput); } check(commandOutput.equals(Windows.is() - ? "SystemRoot="+systemRoot+",LC_ALL=C," + ? "LC_ALL=C,SystemRoot="+systemRoot+"," : "LC_ALL=C,"), "Incorrect handling of envstrings containing NULs"); } catch (Throwable t) { unexpected(t); }

1 0