June 2012 - core-libs-dev

6901992 : Possible InvalidJarIndexException due to bug in sun.misc.JarIndex.merge()
by Diego Belfer 10 Jun '12

10 Jun '12

Hi, I am working on the bug 6901992. I have already fixed the merge method and I have created a test case for it too. Nevertheless, I was unable to reproduce the bug as a whole (using the ClassLoader mechanism) and get the InvalidJarIndexException, since the only way I might think of triggering the error is using an invalid index (INDEX.LIST), which does not make sense. I am triying to reproduce the bug using the URLClassLoader but maybe there is a different usage pattern implemented in the com.sun.deploy.cache classes. Where I can find the source files of that package? In addition, I could not find documentation or specification about how the classloader should process the INDEX.LST. For instance, it was a surprise for me that a jar listed in the INDEX.LIST was included by the classloader without an explicit listing in the classpath. Is there any specification for this? Thanks, Diego

1 0

hg: jdk8/tl/jdk: 7175775: Disable SA options in jinfo/Basic.java test until SA updated for new hash and String count/offset
by alan.bateman＠oracle.com 10 Jun '12

10 Jun '12

Changeset: fc575c78f5d3 Author: alanb Date: 2012-06-10 10:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc575c78f5d3 7175775: Disable SA options in jinfo/Basic.java test until SA updated for new hash and String count/offset Reviewed-by: minqi ! test/sun/tools/jinfo/Basic.sh

1 0

Empty regexp replaceall and surrogate pairs results in corrupted utf16.
by Dawid Weiss 08 Jun '12

08 Jun '12

Hi, I'm a committer to the Apache Lucene project. We have randomized tests and one seed hit the following (simplified) scenario: String s1 = "AB\uD840\uDC00C"; String s2 = s1.replaceAll("", "X"); the input contains an extended unicode character (any surrogate pair will do). The pattern is an empty string (in fact, it was randomized as "]|" but it's the same problem so I omit the details). The problem is that after applying this pattern, replaceAll inserts X in between the surrogate pair characters and this results in invalid UTF-16: AB𠀀C XAXBX?X?XCX I believe this is a bug in the regexp implementation (sorry, don't have a patch for it) but I'd like to confirm it's not something known. Pointers appreciated. Dawid

3 8

Review request for CR 171917 CachedRowSetImpl.populate does not handle map properly
by Lance Andersen - Oracle 08 Jun '12

08 Jun '12

Attached is the fix for bug 171917 . The populate() method needs to check for a size of 0 for the map in case a webrowset xml file has an empty map tag, which would result in calling setobject specifying a map and not all databases/drivers support this. simple 1 line change: hg diff CachedRowSetImpl.java diff -r 4580652d9828 src/share/classes/com/sun/rowset/CachedRowSetImpl.java --- a/src/share/classes/com/sun/rowset/CachedRowSetImpl.java Fri May 04 16:00:47 2012 -0400 +++ b/src/share/classes/com/sun/rowset/CachedRowSetImpl.java Fri May 25 15:45:29 2012 -0400 @@ -659,7 +659,7 @@ * us work with drivers that do not support * getObject with a map in fairly sensible way */ - if (map == null) { + if (map == null || map.size() == 0) { obj = data.getObject(i); } else { obj = data.getObject(i, map); Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com

3 5

hg: jdk8/tl/jaxp: 7157608: One feature is not recognized.
by huizhe.wang＠oracle.com 08 Jun '12

08 Jun '12

Changeset: 238d2d0249af Author: joehw Date: 2012-06-08 11:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/238d2d0249af 7157608: One feature is not recognized. Summary: adding feature standard-uri-conformant into the recognized list Reviewed-by: psandoz ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java

1 0

hg: jdk8/tl/jdk: 7161881: (dc) DatagramChannel.bind(null) fails if IPv4 socket and running with preferIPv6Addresses=true
by rob.mckenna＠oracle.com 08 Jun '12

08 Jun '12

Changeset: a7895dc61088 Author: robm Date: 2012-06-08 18:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7895dc61088 7161881: (dc) DatagramChannel.bind(null) fails if IPv4 socket and running with preferIPv6Addresses=true Reviewed-by: alanb, chegar ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java + test/java/nio/channels/DatagramChannel/BindNull.java

1 0

hg: jdk8/tl: 7165257: Add JFR tests to the JDK code base
by staffan.larsen＠oracle.com 08 Jun '12

08 Jun '12

Changeset: df998cd4d51d Author: sla Date: 2012-06-07 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/df998cd4d51d 7165257: Add JFR tests to the JDK code base Reviewed-by: ohair, dholmes, nloodin, mgronlun ! make/jprt.properties

1 0

hg: jdk8/tl/jdk: 2 new changesets
by staffan.larsen＠oracle.com 08 Jun '12

08 Jun '12

Changeset: 82c41d3065e2 Author: sla Date: 2012-06-07 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82c41d3065e2 7165257: Add JFR tests to the JDK code base Reviewed-by: ohair, dholmes, nloodin, mgronlun ! make/jprt.properties ! test/Makefile Changeset: 961807959c5f Author: sla Date: 2012-06-08 05:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/961807959c5f Merge

1 0

hg: jdk8/tl/jdk: 2 new changesets
by lance.andersen＠oracle.com 08 Jun '12

08 Jun '12

Changeset: 8305ddc88a5a Author: lancea Date: 2012-06-07 20:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8305ddc88a5a 7172551: Remove Native calls from DriverManager for jigsaw Reviewed-by: alanb, chegar, darcy, mchung ! make/java/java/FILES_c.gmk ! make/java/java/mapfile-vers ! makefiles/java/java/FILES_c.gmk ! makefiles/java/java/mapfile-vers ! src/share/classes/java/sql/DriverManager.java - src/share/native/java/sql/DriverManager.c Changeset: 7cb7bfae9d3a Author: lancea Date: 2012-06-08 09:22 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cb7bfae9d3a Merge

1 0

Request for Review(XS): 7156963 Incorrect copyright header in java/io/SerialCallbackContext
by Edvard Wendelin 08 Jun '12

08 Jun '12

Please review. In addition to fixing the copyright I also fixed the incorrect indentation of the rest of the file (which is kind of hard to tell from the webrev). Bug: 7156963 CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7156963 Synopsis: Incorrect copyright header in java/io/SerialCallbackContext Webrev: http://cr.openjdk.java.net/~ewendeli/7156963/webrev.01/ Testing: Verified that the JDK compiles properly. Thanks, Edvard

3 3