June 2014 - core-libs-dev

RFR: JDK-8044343 - Check jdk/src/windows/native/java/lang/ProcessEnvironment_md.c for JNI pending exceptions
by Mark Sheppard 02 Jun '14

02 Jun '14

Hi, please oblige and review the following change http://cr.openjdk.java.net/~msheppar/8044343/webrev/ which addresses issue https://bugs.openjdk.java.net/browse/JDK-8044343 which is a backport of https://bugs.openjdk.java.net/browse/JDK-8036603 the original changeset didn't apply cleanly and was applied manually http://hg.openjdk.java.net/jdk9/dev/jdk/rev/323b64a9dede regression tests ran ok and finally please approve backport to jdk8u-dev regards Mark

2 1

RFR [8037866] Replace the Fun class in tests with lambdas
by Ivan Gerasimov 02 Jun '14

02 Jun '14

Hello! Would you please help review the fix, which replaces the auxiliary Fun class with the same named functional interface? The anonymous classes instantiations are replaced with lambdas. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8037866 WEBREV: http://cr.openjdk.java.net/~igerasim/8037866/0/webrev/ Sincerely yours, Ivan

3 4

Two questions about parameter nullness in the JDK
by Michael Ernst 02 Jun '14

02 Jun '14

I have a couple of questions about places that the JDK is under-specified with respect to nullness properties. Many GitHub projects pass null as the implVendor argument to ClassLoader.definePackage: https://github.com/search?p=2&q=definePackage+packageName+null&ref=searchre… However, the ClassLoader.definePackage documentation does not say whether null is permitted or forbidden as an argument. Could you clarify and document this issue? Another example is ClassFileTransformer.transform. It seems safe to pass in a null protectionDomain to the current implementation: https://gist.github.com/trask/d47133aef3b662b6548b However, the documentation does not explicitly state whether null is permitted or forbidden. I'd like to get a ruling on this issue so that it can be documented as well. Thanks very much for your help! -Mike

1 0