June 2014 - core-libs-dev

Re: contains for TreeSet
by David Holmes 18 Jun '14

18 Jun '14

Moving your question to core-libs-dev, please drop build-dev from all future responses. David On 18/06/2014 10:56 AM, Su wrote: > May I ask why "contains" method of TreeSet uses the comparator to decide if > two objects are equals, but not the equals method of the object? > > Thank you. >

2 1

RFR JDK-8047062: Improve diagnostic output in com/sun/jndi/ldap/LdapTimeoutTest.java
by Pavel Rappo 17 Jun '14

17 Jun '14

Hi everyone, Could you please review my change for JDK-8047062? http://cr.openjdk.java.net/~prappo/8047062/webrev.00/ Thanks -Pavel

2 1

RFR JDK-8046768: com/sun/jndi/ldap/LdapTimeoutTest.java fails intermittently
by Pavel Rappo 17 Jun '14

17 Jun '14

Hi everyone, Could you please review my change for JDK-8046768? http://cr.openjdk.java.net/~prappo/8046768/webrev.00/ This change doesn't fix the issue. It barely adds a diagnostic output (LdapTimeoutTest.java:167) for the case that is failing. During my investigation I haven't been able to reproduce the issue in more than 1,500 test runs. But I believe the missing stacktrace of the NamingException could be diagnostically valuable in this case. Thanks -Pavel

1 1

[9] RFR (XS): 8046903: VM anonymous class members can't be statically invocable
by Vladimir Ivanov 17 Jun '14

17 Jun '14

http://cr.openjdk.java.net/~vlivanov/8046903/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8046903 j.l.i.InvokerBytecodeGenerator::isStaticallyInvocable doesn't distinguish between VM anonymous classes and ordinary classes. In some very specific circumstances (VM anonymous class declared in one of predefined core packages), it can consider a member of VM anonymous class as statically invocable and symbolically reference it from generated bytecode. It's wrong because such class can't be looked up by name and the attempt to run such code ends up with NoClassDefFoundError. The fix is to disable static invocation for members of VM anonymous classes. Testing: regression test. Thanks! Best regards, Vladimir Ivanov

2 2

[9] RFR (XS): 8044730: small errors in ConcurrentHashMap and LongAdder docs
by Stuart Marks 16 Jun '14

16 Jun '14

Hi Martin, Thanks for augmenting my patch and pushing it into the JSR166 repo. Here's the patch rebased against jdk9-dev. Please review. s'marks # HG changeset patch # User smarks # Date 1402960663 25200 # Mon Jun 16 16:17:43 2014 -0700 # Node ID c8c2d902f3f1338b8074607367e7af8e294ae1c6 # Parent ade4491b571e65f28a6295b8be9679830a5e9a85 8044730: small errors in ConcurrentHashMap and LongAdder docs Reviewed-by: XXX diff -r ade4491b571e -r c8c2d902f3f1 src/share/classes/java/util/concurrent/ConcurrentHashMap.java --- a/src/share/classes/java/util/concurrent/ConcurrentHashMap.java Mon Jun 16 13:48:58 2014 -0400 +++ b/src/share/classes/java/util/concurrent/ConcurrentHashMap.java Mon Jun 16 16:17:43 2014 -0700 @@ -133,12 +133,12 @@ * mapped values are (perhaps transiently) not used or all take the * same mapping value. * - * A ConcurrentHashMap can be used as scalable frequency map (a + * A ConcurrentHashMap can be used as a scalable frequency map (a * form of histogram or multiset) by using {@link * java.util.concurrent.atomic.LongAdder} values and initializing via * {@link #computeIfAbsent computeIfAbsent}. For example, to add a count * to a {@code ConcurrentHashMap<String,LongAdder> freqs}, you can use - * {@code freqs.computeIfAbsent(k -> new LongAdder()).increment();} + * {@code freqs.computeIfAbsent(key, k -> new LongAdder()).increment();} * * This class and its views and iterators implement all of the * optional methods of the {@link Map} and {@link Iterator} diff -r ade4491b571e -r c8c2d902f3f1 src/share/classes/java/util/concurrent/atomic/LongAdder.java --- a/src/share/classes/java/util/concurrent/atomic/LongAdder.java Mon Jun 16 13:48:58 2014 -0400 +++ b/src/share/classes/java/util/concurrent/atomic/LongAdder.java Mon Jun 16 16:17:43 2014 -0700 @@ -57,7 +57,7 @@ * frequency map (a form of histogram or multiset). For example, to * add a count to a {@code ConcurrentHashMap<String,LongAdder> freqs}, * initializing if not already present, you can use {@code - * freqs.computeIfAbsent(k -> new LongAdder()).increment();} + * freqs.computeIfAbsent(key, k -> new LongAdder()).increment();} * * This class extends {@link Number}, but does not define * methods such as {@code equals}, {@code hashCode} and {@code

2 1

RFR 8u20: JDK-8029674: (reflect) getMethods returns default methods that are not members of the class
by Joel Borggrén-Franck 16 Jun '14

16 Jun '14

Hi, Can I get a review for this almost trivial 8u20 back port. The 9 fix reviewed here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-June/027173.html applies cleanly except one hunk fails due to a non-backported change updating a for to a for each: $ cat src/share/classes/java/lang/Class.java.rej --- Class.java +++ Class.java @@ -2819,7 +2894,7 @@ // the end. MethodArray inheritedMethods = new MethodArray(); for (Class<?> i : getInterfaces()) { - inheritedMethods.addAllNonStatic(i.privateGetPublicMethods()); + inheritedMethods.addInterfaceMethods(i.privateGetPublicMethods()); } if (!isInterface()) { Class<?> c = getSuperclass(); In 8u the hunk needs to be: @@ -2819,9 +2894,8 @@ // out concrete implementations inherited from superclasses at // the end. MethodArray inheritedMethods = new MethodArray(); - Class<?>[] interfaces = getInterfaces(); - for (int i = 0; i < interfaces.length; i++) { - inheritedMethods.addAllNonStatic(interfaces[i].privateGetPublicMethods()); + for (Class<?> i : getInterfaces()) { + inheritedMethods.addInterfaceMethods(i.privateGetPublicMethods()); } if (!isInterface()) { Class<?> c = getSuperclass(); 8u webrev here: http://cr.openjdk.java.net/~jfranck/8029674/jdk8u/webrev.8u.00/ 9 Bug here: http://bugs.openjdk.java.net/browse/JDK-8029674 cheers /Joel

2 1

RFR [9] 8046902: Remove sun.misc.Timer
by Chris Hegarty 16 Jun '14

16 Jun '14

The type sun.misc.Timer has long since been replaced by the standard java.util.Timer. As an unneeded part of sun.misc, sun.misc.Timer should be removed from the platform. This is part of the larger cleanup of legacy unused classes from sun.misc, see JDK-6852936 [1]. sun.misc.Timeable will also be removed as part of this issue. http://cr.openjdk.java.net/~chegar/8046902/webrev.00/webrev/ -Chris. [0] https://bugs.openjdk.java.net/browse/JDK-8046902 [1] https://bugs.openjdk.java.net/browse/JDK-6852936

4 3

JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK
by Paul Sandoz 16 Jun '14

16 Jun '14

Hi, This is a request for review of Otavio's patch replacing StringBuffer with StringBuilder within OpenJDK. (I also need to review it.) It covers many areas and i have grouped the patches into such areas to aid reviewing. When commenting please including core-libs. Jtreg tests showed no regressions, but when reviewing we need to be mindful of the context e.g. if the buffer escapes and can cross thread boundaries. This is also an experiment to see if we can review the whole thing under one bug :-) if things prove problematic and slow we can split it out. Many files are touched but there are not many changes to each file and changes are very formulaic. I have also included ASM related changes, but i suspect we may have to leave those alone since such changes will make it more difficult to pull in ASM from upstream. - Otavio, for the record can you reply to this thread posting your single ("uber") patch as textual attachment? (IIUC such attachments should now be supported by the email server). Paul. - core http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-c… - io http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-i… - management http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-m… - rmi http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-r… - security http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-s… - tools http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-t… - graphics/media http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-m… - asm http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-a…

9 23

RFR: 8046389: Add missing @since tag under javax.sql.**
by Henry Jen 16 Jun '14

16 Jun '14

Hi, Please review a trivial webrev that provides missing @since tag for elements under javax.sql, javax.sql.CommonDataSource was extracted out since 1.6, methods have @since 1.4 tag because those methods existed in origins since then. http://cr.openjdk.java.net/~henryjen/jdk9/8046389/0/webrev/ Cheers, Henry

2 2

RFR [8042990] Optimize conversion to hex string
by Ivan Gerasimov 14 Jun '14

14 Jun '14

Hello! There is a method Integer.toHexString(int), which produce a string with no extra leading zeroes. I found a couple of places in jdk, where it would be useful to have a variant of the method which pads the result with the required amount of zeroes. Would you please take at the webrev? http://cr.openjdk.java.net/~igerasim/8042990/0/webrev/ It includes implementations of Integer.toHexString(int, int) and Long.toHexString(long, int) with the second argument standing for the minimum width of the produced string. It also contains a few replacements of the same behaving code with calls to these new methods. Sincerely yours, Ivan

2 1