May 2016 - core-libs-dev

RFR 8154189: Deprivilege java.sql and java.sql.rowset module
by Lance Andersen 31 May '16

31 May '16

Hi all, This is a request to review the changes below to Deprivilege java.sql and java.sql.rowset modules changes to: make/common/Modules.gmk ———————— ljanders-mac:make ljanders$ hg diff diff -r cae471d3b877 make/common/Modules.gmk --- a/make/common/Modules.gmk Thu May 26 17:17:51 2016 +0000 +++ b/make/common/Modules.gmk Fri May 27 13:21:22 2016 -0400 @@ -57,7 +57,6 @@ java.rmi \ java.security.jgss \ java.security.sasl \ - java.sql \ java.xml \ java.xml.crypto \ jdk.httpserver \ @@ -72,7 +71,6 @@ # to be deprivileged BOOT_MODULES += \ - java.sql.rowset \ java.smartcardio \ jdk.naming.rmi \ # @@ -105,6 +103,8 @@ PLATFORM_MODULES += \ java.compiler \ + java.sql \ + java.sql.rowset \ java.scripting \ jdk.accessibility \ jdk.charsets \ ljanders-mac:make ljanders$ ———————— Changes to: src/java.base/share/conf/security/java.policy ———————— ljanders-mac:jdk ljanders$ hg diff diff -r df35a805b405 src/java.base/share/conf/security/java.policy --- a/src/java.base/share/conf/security/java.policy Fri May 27 08:52:22 2016 -0700 +++ b/src/java.base/share/conf/security/java.policy Fri May 27 13:24:22 2016 -0400 @@ -33,6 +33,14 @@ permission java.io.FilePermission "${java.home}/conf/security/ucrypto-solaris.cfg", "read"; }; +grant codeBase "jrt:/java.sql" { + permission java.security.AllPermission; +}; + +grant codeBase "jrt:/java.sql.rowset" { + permission java.security.AllPermission; +}; + grant codeBase "jrt:/jdk.crypto.ec" { permission java.lang.RuntimePermission "accessClassInPackage.sun.security.*"; permission java.lang.RuntimePermission "loadLibrary.sunec"; ljanders-mac:jdk ljanders$ ———————————— As part of the testing, we have run - CTS JDBC tests - against Derby embedded and client driver - All of the Derby test suites - JTREG tests - JCK JDBC and RowSet tests The Derby tests suites uncovered 2 Derby specific issues which have been addressed in the derby trunk, all other tests passed thank you and have a nice weekend Best Lance <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com <mailto:Lance.Andersen@oracle.com>

4 5

Review request JDK-8153944: wsimport and wsgen usage messages not printed
by Mandy Chung 30 May '16

30 May '16

wsgen and wsimport tools use the utility classes in java.xml.bind module to localize messages. Resource bundles are encapsulated in named modules and hence utility like com.sun.istack.internal.localization.LocalizableMessageFactory. The owner of the resource bundle should be the one loading ResourceBundle. The solution to this type of issue is to update the utility classes to accept a function to return ResourceBundle rather than by base name. Another alternative could do the localization locally within the module and this may not be applicable to JAX-WS since jdk.xml.ws is tightly coupled with java.xml.ws. Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8153944/webrev.00 This patch touches quites a few files, one per supporting class to get messages from one resource bundle. The change is straight-forward and same pattern applies to each message file. Mandy

4 4

RFR 8157816, Mark 4 httpclient tests as intermittently failing
by Felix Yang 30 May '16

30 May '16

Hi all, please review the change to mark following tests with keyword 'intermittent'. These tests have been observed to fail intermittently for a while. test/java/net/httpclient/SplitResponse.java test/java/net/httpclient/http2/BasicTest.java test/java/net/httpclient/http2/ErrorTest.java test/java/net/httpclient/http2/TLSConnection.java Bug: https://bugs.openjdk.java.net/browse/JDK-8157816 Webrev: http://cr.openjdk.java.net/~xiaofeya/8157816/webrev.00/ Thanks, Felix Also attached the diff: diff -r ee29aaab5889 test/java/net/httpclient/SplitResponse.java --- a/test/java/net/httpclient/SplitResponse.java Mon May 30 14:58:59 2016 +0900 +++ b/test/java/net/httpclient/SplitResponse.java Sun May 29 23:49:16 2016 -0700 @@ -33,6 +33,7 @@ /** * @test * @bug 8087112 + * @key intermittent * @build Server * @run main/othervm -Djava.net.HttpClient.log=all SplitResponse */ diff -r ee29aaab5889 test/java/net/httpclient/http2/BasicTest.java --- a/test/java/net/httpclient/http2/BasicTest.java Mon May 30 14:58:59 2016 +0900 +++ b/test/java/net/httpclient/http2/BasicTest.java Sun May 29 23:49:16 2016 -0700 @@ -24,6 +24,7 @@ /* * @test * @bug 8087112 + * @key intermittent * @library /lib/testlibrary * @build jdk.testlibrary.SimpleSSLContext * @modules java.httpclient diff -r ee29aaab5889 test/java/net/httpclient/http2/ErrorTest.java --- a/test/java/net/httpclient/http2/ErrorTest.java Mon May 30 14:58:59 2016 +0900 +++ b/test/java/net/httpclient/http2/ErrorTest.java Sun May 29 23:49:16 2016 -0700 @@ -24,6 +24,7 @@ /* * @test * @bug 8157105 + * @key intermittent * @library /lib/testlibrary * @build jdk.testlibrary.SimpleSSLContext * @modules java.httpclient diff -r ee29aaab5889 test/java/net/httpclient/http2/TLSConnection.java --- a/test/java/net/httpclient/http2/TLSConnection.java Mon May 30 14:58:59 2016 +0900 +++ b/test/java/net/httpclient/http2/TLSConnection.java Sun May 29 23:49:16 2016 -0700 @@ -39,6 +39,7 @@ /* * @test * @bug 8150769 8157107 + * @key intermittent * @summary Checks that SSL parameters can be set for HTTP/2 connection * @modules java.httpclient * @compile/module=java.httpclient java/net/http/Http2Handler.java

2 1

JDK 9 RFR of JDK-8154980: Remove intermittent key from test BandIntegrity.java
by Amy Lu 30 May '16

30 May '16

tools/pack200/BandIntegrity.java This test was failing intermittently (JDK-8154049). Mentioned issues have been resolved and no open bug (no failure reported) till now. This patch is to remove @key intermittent from the test. bug: https://bugs.openjdk.java.net/browse/JDK-8154980 webrev: http://cr.openjdk.java.net/~amlu/8154980/webrev.00/ Thanks, Amy --- old/test/tools/pack200/BandIntegrity.java 2016-05-30 15:28:53.000000000 +0800 +++ new/test/tools/pack200/BandIntegrity.java 2016-05-30 15:28:53.000000000 +0800 @@ -26,7 +26,6 @@ * @summary test ensures the proper sequencing of bands, dump bands as well. * @compile -XDignore.symbol.file Utils.java BandIntegrity.java * @run main BandIntegrity - * @key intermittent * @author ksrini */ import java.io.File;

2 1

Review Request: JDK-8157986: Runtime support for javac to determine arguments to the runtime environment
by Mandy Chung 27 May '16

27 May '16

This patch allows jdk.compiler to get the runtime arguments without pulling in java.management (that requires java.rmi). We should look into use cases further in the future and determine whether a public API should be provided. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157986/webrev.00/index.html Mandy

2 2

RFR 8157996: Unneeded import in lib/testlibrary/jdk/testlibrary/SimpleSSLContext.java
by Alexandre (Shura) Iline 27 May '16

27 May '16

Hi. Please take a look on an obvious fix: http://cr.openjdk.java.net/~shurailine/8157996/webrev.00/ There was an unneeded import statement which was getting in the way when running tests with limited module availability. Also in a couple of places I have added try with resources. Shura

3 4

RFR(xs): 8059361: Properties.stringPropertyNames() returns a set inconsistent with the assertions from the spec
by Stuart Marks 26 May '16

26 May '16

Hi all, Please review this small spec change. Properties.stringPropertyNames() seems to imply that the Set it returns is modifiable. It is, but only partially. Since it's a keySet() from a Hashtable, it supports removal but not addition. This change removes the implication that the returned set is fully modifiable. Bug report: https://bugs.openjdk.java.net/browse/JDK-8059361 Diffs below. Thanks, s'marks diff -r 4d9388b1ae27 src/java.base/share/classes/java/util/Properties.java --- a/src/java.base/share/classes/java/util/Properties.java Wed May 25 13:38:35 2016 -0700 +++ b/src/java.base/share/classes/java/util/Properties.java Wed May 25 16:09:22 2016 -0700 @@ -1044,9 +1044,10 @@ * properties list. Properties whose key or value is not * of type {@code String} are omitted. * <p> - * The returned set is not backed by the {@code Properties} object. - * Changes to this {@code Properties} are not reflected in the set, - * or vice versa. + * The returned set is not backed by this {@code Properties} object. + * Changes to this {@code Properties} object are not reflected in the + * returned set. Any modifications that might be allowed on the + * returned set are not reflected in this Properties object. * * @return a set of keys in this property list where * the key and its corresponding value are strings,

3 8

JDK 9 RFR of JDK-6961865: javadoc for Boolean.valueOf(String) with null argument not clearly specified
by joe darcy 26 May '16

26 May '16

Hello, Please review these spec clarifications for java.lang.Boolean: JDK-6961865: javadoc for Boolean.valueOf(String) with null argument not clearly specified http://cr.openjdk.java.net/~darcy/6961865.0/ Thanks, -Joe

2 1

Files.walk() is unusable because of AccessDeniedException
by Gilles Habran 26 May '16

26 May '16

Good morning, I am trying to use Files.walk() in a Java 8 way but it is broken. I am trying to create an app to manage files and size on all my Linux system (so I would walk from the root directory and show the 5 biggest files of each directory for example). *JDK-8039910* has been raised for this issue but it is closed (2014-11-22). Alan Bateman wrote that the method is working as intended but I don't see how this could be intended because at the moment, it is unusable in a Java 8 way and for me. When we use a terminal operations on the Stream returned by Files.walk(), we get a crash because of AccessDeniedException For example, here is the directory (rules.d) that makes everything crash : [9:51:20 - ghabran@arch:/tmp/chromium-pepper-flash]$ ll /usr/share/polkit-1 total 8.0K drwxr-xr-x 2 root root 4.0K Apr 14 09:18 actions *drwxr-x--- 2 root polkitd 4.0K Apr 14 09:18 rules.d* As you can see, as a simple user, I don't have access. It is not possible to apply a filter to check the attributes to manage the file/directory to see if we have the rights because an exception is thrown before we get to check the attributes. Here are several scenarios : 1) This doesn't crash (there seems to have no exception thrown). I get error code 0, no exception is printed on my terminal. try { Stream<Path> directoryTree = Files.walk(*Paths.get("/")*); directoryTree .filter(p -> { try { return Files.isRegularFile(p) && Files.isReadable(p); } catch (Exception e) { return false; } }); } catch (IOException ioe) { System.out.println(ioe); } 2) this raises the exception AccessDeniedException (this goes in the catch) try { Stream<Path> directoryTree = Files.walk( *Paths.get("/usr/share/polkit-1/rules.d")*); directoryTree .filter(p -> { try { return Files.isRegularFile(p) && Files.isReadable(p); } catch (Exception e) { return false; } }); *} catch (IOException ioe) {* * System.out.println(ioe);* *}* 3) this crashes with a stack trace : AccessDeniedException *(this doesn't go in the catch)* try { Stream<Path> directoryTree = Files.walk(*Paths.get("/")*); directoryTree .filter(p -> { try { return Files.isRegularFile(p) && Files.isReadable(p); } catch (Exception e) { return false; } })*.forEach(System.out::println);* } catch (IOException ioe) { System.out.println(ioe); } 4) this crashes but goes into the catch try { Stream<Path> directoryTree = Files.walk( *Paths.get("/usr/share/polkit-1/rules.d")*); directoryTree .filter(p -> { try { return Files.isRegularFile(p) && Files.isReadable(p); } catch (Exception e) { return false; } })*.forEach(System.out::println)*; *} catch (IOException ioe) {* * System.out.println(ioe);* *}* In the meantime, I will use the old way with walkFileTree and a FileVisitor. How am I supposed to walk() a directory tree in Java 8 without walk() ? I was looking forward to using Stream<Path> to do it but I can't. What should I do ? Thank you. Regards, Gilles

7 10

[9] RFR: Static build of libzip is missing JNI_OnLoad_zip entry point
by Naoto Sato 26 May '16

26 May '16

Hello, The previous attempt to fix this one failed in the installer build, as it does not recognize the added macro. I've updated the fix to add extra check for static build (yeah, this is redundant with the real jni_util.h, but effectively avoid the installer build failure). http://cr.openjdk.java.net/~naoto/8150179/webrev.01/ Please review. Naoto

3 4