May 2016 - core-libs-dev

JDK 9 RFR of JDK-8157487: Mark ZoneId.java as intermittently failing
by Joseph D. Darcy 20 May '16

20 May '16

Hello, The test sun/net/www/protocol/http/ZoneId.java has been seen to intermittently fail (JDK-8085785) and should be marked accordingly. Please review the patch below which does this. Thanks, -Joe --- a/test/sun/net/www/protocol/http/ZoneId.java Fri May 20 14:41:41 2016 -0700 +++ b/test/sun/net/www/protocol/http/ZoneId.java Fri May 20 14:53:51 2016 -0700 @@ -24,6 +24,7 @@ /* * @test * @bug 8027308 + * @key intermittent * @modules java.base/sun.net.www.protocol.http * @summary verifies that HttpURLConnection does not send the zone id in the * 'Host' field of the header:

2 1

[9] RFR of 5100935: No way to access the 64-bit integer multiplication of 64-bit CPUs efficiently
by Brian Burkhalter 20 May '16

20 May '16

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-5100935 Patch: http://cr.openjdk.java.net/~bpb/5100935/webrev.00/ Summary: Add multiplyFull() and multiplyHigh() methods to java.lang.Math. This change addresses the Java specification and implementation only. The addition of compiler intrinsics for these methods will be tracked separately. Thanks, Brian

4 8

RFR (JAXP) 8054632: [since-tag]: javadoc for xml classes has invalid @since tag
by huizhe wang 20 May '16

20 May '16

Hi, This patch applies similar change[1] made to the DOM sources under java.xml for those under jdk.xml.dom, replacing "@since DOM Level 2" with "@since 1.4, DOM Level 2", and adding "@since 1.4, DOM Level 2" to the ones (under html package) that missed the @since tag. JBS: https://bugs.openjdk.java.net/browse/JDK-8054632 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8054632/webrev/ [1] https://bugs.openjdk.java.net/browse/JDK-8047723 Thanks, Joe

2 2

[9] RFR: 8152207: Perform array bound checks while getting a length of bytecode instructions
by Artem Smotrakov 20 May '16

20 May '16

Hello, Please review two small patches for jdk and hotspot repos which add array bound checks to functions which return a length of bytecode instruction. Please see details in https://bugs.openjdk.java.net/browse/JDK-8152207 http://cr.openjdk.java.net/~asmotrak/8152207/jdk/webrev.00/ http://cr.openjdk.java.net/~asmotrak/8152207/hotspot/webrev.00/ Artem

2 3

RFR: JDK-8143282: \p{Cn} unassigned code points should be included in \p{C}
by Xueming Shen 20 May '16

20 May '16

Hi, Please help review the change for 8143282. issue: https://bugs.openjdk.java.net/browse/JDK-8143282 webrev: http://cr.openjdk.java.net/~sherman/8143282 thanks, Sherman

2 5

RFR 8156718: Need tests for IsoFields getFrom for unsupported non-Iso Temporal fields
by Bhanu Gopularam 20 May '16

20 May '16

Hi all, Could you please review fix for following issue. Bug id: https://bugs.openjdk.java.net/browse/JDK-8156718 Solution: Added tck tests for validating getFrom method for unsupported non-Iso temporal fields Webrev: http://cr.openjdk.java.net/~bgopularam/JDK-8156718/webrev.00/ Thanks, Bhanu

4 8

RFR: 8157449: Adjust link-time generated Species classes to match JDK-8148604 usage
by Claes Redestad 20 May '16

20 May '16

Hi, I noticed that the BMH$Species classes generated at link time slightly mismatch the classes generated when concatenating things. Updating this to match reality helps mitigate a small fraction of the startup penalty to enabling the optimal string concatenation strategy: Bug: https://bugs.openjdk.java.net/browse/JDK-8157449 Webrev: http://cr.openjdk.java.net/~redestad/8157449/webrev.00/ Note that the plan is to generate this list of defaults automatically in a profiling step, either during build or as part of the ongoing development process. Apologies for not having gotten to that yet. :-) Thanks! /Claes

2 1

Review Request: 8157391: jdeps left JarFile open
by Mandy Chung 20 May '16

20 May '16

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157391/webrev.00/index.html tools/jdeps/modules/GenModuleInfo.java tools/jdeps/modules/TransitiveDeps.java tools/jdeps/modules/InverseDeps.java These tests still failed on windows after JDK-8152502. Now I have the jtreg logs showing that JAR files can’t be deleted although I still can’t reproduce them locally and on JPRT (will find out what’s the difference tomorrow). Mandy

3 4

TreeMap specific override of putIfAbsent/merge
by Tomasz Kowalczewski 20 May '16

20 May '16

Hi all, TreeMap does not have its own specific overrides of Map methods that were added in java 8. In our specific usage we do what is effective a merge operation: For incoming K and V: 1. get value from map 2. if present - merge with incoming value V 3. if absent - associate K with V in the map For case where K is not in the map we traverse the tree map it twice. Implementing TreeMap specific override of putIfAbsent would allow as to avoid this cost. Was such change considered in past and rejected? Is anyone interested in a patch that implements it? -- Regards, Tomasz Kowalczewski

2 1

RFR: 8157437 Typos in Stream JavaDoc
by Paul Sandoz 20 May '16

20 May '16

Hi, I introduced some typos in my haste to push the fix for JDK-8130023 (API java.util.stream: explicitly specify guaranteed execution of the pipeline) (I am reminded of the phrase “Go slow and you’ll get there faster”.) So to slow my self down i did a search for spelling errors in all of the stream package and found a few in internal comments. Paul. diff -r 871cb8793270 src/java.base/share/classes/java/util/stream/AbstractTask.java --- a/src/java.base/share/classes/java/util/stream/AbstractTask.java Fri May 20 11:47:39 2016 +0200 +++ b/src/java.base/share/classes/java/util/stream/AbstractTask.java Fri May 20 13:37:14 2016 +0200 @@ -106,7 +106,7 @@ protected Spliterator<P_IN> spliterator; /** Target leaf size, common to all tasks in a computation */ - protected long targetSize; // may be laziliy initialized + protected long targetSize; // may be lazily initialized /** * The left child. diff -r 871cb8793270 src/java.base/share/classes/java/util/stream/DoubleStream.java --- a/src/java.base/share/classes/java/util/stream/DoubleStream.java Fri May 20 11:47:39 2016 +0200 +++ b/src/java.base/share/classes/java/util/stream/DoubleStream.java Fri May 20 13:37:14 2016 +0200 @@ -211,7 +211,7 @@ * .sum(); * }</pre> * - * In cases where stream implementation is able to optimize away the + * In cases where the stream implementation is able to optimize away the * production of some or all the elements (such as with short-circuiting * operations like {@code findFirst}, or in the example described in * {@link #count}), the action will not be invoked for those elements. diff -r 871cb8793270 src/java.base/share/classes/java/util/stream/IntStream.java --- a/src/java.base/share/classes/java/util/stream/IntStream.java Fri May 20 11:47:39 2016 +0200 +++ b/src/java.base/share/classes/java/util/stream/IntStream.java Fri May 20 13:37:14 2016 +0200 @@ -209,7 +209,7 @@ * .sum(); * }</pre> * - * In cases where stream implementation is able to optimize away the + * In cases where the stream implementation is able to optimize away the * production of some or all the elements (such as with short-circuiting * operations like {@code findFirst}, or in the example described in * {@link #count}), the action will not be invoked for those elements. diff -r 871cb8793270 src/java.base/share/classes/java/util/stream/LongStream.java --- a/src/java.base/share/classes/java/util/stream/LongStream.java Fri May 20 11:47:39 2016 +0200 +++ b/src/java.base/share/classes/java/util/stream/LongStream.java Fri May 20 13:37:14 2016 +0200 @@ -209,7 +209,7 @@ * .sum(); * }</pre> * - * In cases where stream implementation is able to optimize away the + * In cases where the stream implementation is able to optimize away the * production of some or all the elements (such as with short-circuiting * operations like {@code findFirst}, or in the example described in * {@link #count}), the action will not be invoked for those elements. diff -r 871cb8793270 src/java.base/share/classes/java/util/stream/Stream.java --- a/src/java.base/share/classes/java/util/stream/Stream.java Fri May 20 11:47:39 2016 +0200 +++ b/src/java.base/share/classes/java/util/stream/Stream.java Fri May 20 13:37:14 2016 +0200 @@ -93,7 +93,7 @@ * example of such an optimization, see the API note documented on the * {@link #count} operation. For more detail, see the * <a href="package-summary.html#SideEffects">side-effects</a> section of the - * strean package documentation.) + * stream package documentation.) * * Collections and streams, while bearing some superficial similarities, * have different goals. Collections are primarily concerned with the efficient @@ -428,7 +428,7 @@ * .collect(Collectors.toList()); * }</pre> * - * In cases where stream implementation is able to optimize away the + * In cases where the stream implementation is able to optimize away the * production of some or all the elements (such as with short-circuiting * operations like {@code findFirst}, or in the example described in * {@link #count}), the action will not be invoked for those elements. diff -r 871cb8793270 src/java.base/share/classes/java/util/stream/StreamSpliterators.java --- a/src/java.base/share/classes/java/util/stream/StreamSpliterators.java Fri May 20 11:47:39 2016 +0200 +++ b/src/java.base/share/classes/java/util/stream/StreamSpliterators.java Fri May 20 13:37:14 2016 +0200 @@ -28,7 +28,6 @@ import java.util.Objects; import java.util.Spliterator; import java.util.concurrent.ConcurrentHashMap; -import java.util.concurrent.ForkJoinPool; import java.util.concurrent.atomic.AtomicLong; import java.util.function.BooleanSupplier; import java.util.function.Consumer; @@ -104,7 +103,7 @@ T_BUFFER buffer; /** - * True if full traversal has occurred (with possible cancelation). + * True if full traversal has occurred (with possible cancellation). * If doing a partial traversal, there may be still elements in buffer. */ boolean finished;

4 3