May 2016 - core-libs-dev

RFR 8130023 API java.util.stream: explicitly specify guaranteed execution of the pipeline
by Paul Sandoz 20 May '16

20 May '16

Hi, Please review: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8130023-stream-elide-ops-side-… <http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8130023-stream-elide-ops-side-…> This is a spec tweak to streams to state that implementations are free to elide some or all operations in a pipeline as long as it does not affect the result of the stream computation i.e. side-effects beware! Paul.

2 3

JDK 9 RFR of JDK-8157211: Mark tools/launcher/FXLauncherTest.java as intermittently failing
by Hamlin Li 20 May '16

20 May '16

tools/launcher/FXLauncherTest.java This test is known to fail intermittently (JDK-8130392 <https://bugs.openjdk.java.net/browse/JDK-8130392>), it should be marked accordingly with@key intermittentjtreg tag in the test file. bug: https://bugs.openjdk.java.net/browse/JDK-8157211 webrev: http://cr.openjdk.java.net/~mli/8157211/webrev.00/ Thank you -Hamlin --- a/test/tools/launcher/FXLauncherTest.java Tue May 17 19:20:05 2016 -0700 +++ b/test/tools/launcher/FXLauncherTest.java Tue May 17 21:44:18 2016 -0700 @@ -29,6 +29,7 @@ * jfx app class, a main-class for the manifest, a bogus one and none. * All should execute except the incorrect fx app class entries. * @run main/othervm FXLauncherTest + * @key intermittent */ import java.io.File; import java.io.IOException;

2 2

Review request 8153042: jdeps should continue to report JDK internal APIs that are removed/renamed in JDK 9
by Mandy Chung 20 May '16

20 May '16

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8153042/webrev.00/index.html Several JDK internal APIs have been removed JDK 9. It’d be helpful to continue to flag those internal APIs if they are used by existing libraries. This fix is an interim solution. A longer-term solution may be for jdeps to support -release option (something for the future). Mandy

2 1

RFR [9] 8157154: jmod jlink properties file need copyright header
by Chris Hegarty 20 May '16

20 May '16

Quite trivially, the copyright headers were omitted from these new property files. This review request simply adds the standard header to: jdk/src/jdk.jlink/share/classes/jdk/tools/jimage/resources/jimage.properties jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties jdk/src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod.properties -Chris. $ hg diff diff --git a/src/jdk.jlink/share/classes/jdk/tools/jimage/resources/jimage.properties b/src/jdk.jlink/share/classes/jdk/tools/jimage/resources/jimage.properties --- a/src/jdk.jlink/share/classes/jdk/tools/jimage/resources/jimage.properties +++ b/src/jdk.jlink/share/classes/jdk/tools/jimage/resources/jimage.properties @@ -1,3 +1,28 @@ +# +# Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. +# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. +# +# This code is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License version 2 only, as +# published by the Free Software Foundation. Oracle designates this +# particular file as subject to the "Classpath" exception as provided +# by Oracle in the LICENSE file that accompanied this code. +# +# This code is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License +# version 2 for more details (a copy is included in the LICENSE file that +# accompanied this code). +# +# You should have received a copy of the GNU General Public License version +# 2 along with this work; if not, write to the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. +# +# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA +# or visit www.oracle.com if you need additional information or have any +# questions. +# + main.usage.summary=\ Usage: {0} <extract|info|list|set|verify> <options> jimage...\n\ use --help for a list of possible options diff --git a/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties b/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties --- a/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties +++ b/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties @@ -1,3 +1,28 @@ +# +# Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. +# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. +# +# This code is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License version 2 only, as +# published by the Free Software Foundation. Oracle designates this +# particular file as subject to the "Classpath" exception as provided +# by Oracle in the LICENSE file that accompanied this code. +# +# This code is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License +# version 2 for more details (a copy is included in the LICENSE file that +# accompanied this code). +# +# You should have received a copy of the GNU General Public License version +# 2 along with this work; if not, write to the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. +# +# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA +# or visit www.oracle.com if you need additional information or have any +# questions. +# + main.usage.summary=\ Usage: {0} <options> --modulepath <modulepath> --addmods <mods> --output <path>\n\ use --help for a list of possible options diff --git a/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties b/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties --- a/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties +++ b/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties @@ -1,3 +1,28 @@ +# +# Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. +# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. +# +# This code is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License version 2 only, as +# published by the Free Software Foundation. Oracle designates this +# particular file as subject to the "Classpath" exception as provided +# by Oracle in the LICENSE file that accompanied this code. +# +# This code is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License +# version 2 for more details (a copy is included in the LICENSE file that +# accompanied this code). +# +# You should have received a copy of the GNU General Public License version +# 2 along with this work; if not, write to the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. +# +# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA +# or visit www.oracle.com if you need additional information or have any +# questions. +# + release-info.argument=<file>|add:<key1>=<value1>:<key2>=<value2>:...|del:<key list> release-info.description=\ diff --git a/src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod.properties b/src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod.properties --- a/src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod.properties +++ b/src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod.properties @@ -1,3 +1,28 @@ +# +# Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. +# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. +# +# This code is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License version 2 only, as +# published by the Free Software Foundation. Oracle designates this +# particular file as subject to the "Classpath" exception as provided +# by Oracle in the LICENSE file that accompanied this code. +# +# This code is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License +# version 2 for more details (a copy is included in the LICENSE file that +# accompanied this code). +# +# You should have received a copy of the GNU General Public License version +# 2 along with this work; if not, write to the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. +# +# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA +# or visit www.oracle.com if you need additional information or have any +# questions. +# + main.usage.summary=\ Usage: {0} (create|list|describe|hash) <OPTIONS> <jmod-file>\n\ use --help for a list of possible options

3 3

[9] RFR of 8023217: Additional floorDiv/floorMod/multiplyExact methods for java.lang.Math
by Brian Burkhalter 20 May '16

20 May '16

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8023217 Patch: http://cr.openjdk.java.net/~bpb/8023217/webrev.00/ Summary: Add some additional methods of the same name as existing methods but with the commonly used parameter signature “long,int”: long multiplyExact(long,int) long floorDiv(long,int) int floorDiv(long,int) These methods also provide hooks for potential intrinsics. There might be room for improvement in their Java implementations. The modifications to the java.time classes are to fix warnings about “redundant cast to int.” Thanks, Brian

4 9

Review request: 8152502: tools/jdeps/modules/GenModuleInfo.java and TransitiveDeps fails on windows
by Mandy Chung 19 May '16

19 May '16

These jdeps tests fails running on windows “Error. failed clean up files after test”. A bug in the tests and implementation that calls Files.walk without try-with-resources. Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8152502/webrev.00/index.html This fix calls Files::walk with try-with-resources. I wasn’t quite able to reproduce the error on my windows machine. I’d like to push this fix and address any issue, if any. Mandy

2 1

RFR (JAXP) 8139585: Typo: "APIi" instead of "API"
by huizhe wang 19 May '16

19 May '16

Hi, Replaced the texts with the titles of the documents they are referring to. JBS: https://bugs.openjdk.java.net/browse/JDK-8139585 Webrev: http://cr.openjdk.java.net/~joehw/jdk9/8139585/webrev/ Thanks, Joe

2 2

RFR: 8144062: Move jdk.Version to java.lang.Runtime.Version
by Iris Clark 19 May '16

19 May '16

Hi. Reviving this work from a few months back. Please review the following changes to move jdk.Version to jdk.lang.Runtime.Version. Bug 8144062: Move jdk.Version to java.lang.Runtime.Version https://bugs.openjdk.java.net/browse/JDK-8144062 webrev http://cr.openjdk.java.net/~iris/verona/8144062/webrev.1/ When jdk.Version was initially pushed in jdk-9+1-5, it was Improperly exported by java.base. After exploring a few options, the best choice was to move jdk.Version to java.lang.Runtime.Version (a nested class of Runtime). By making Version an SE API, it may be exported by the java.base module. As part of the move, a limited number of chnages were made to the Version class: - Change package name and class declaration (to static) - Eliminate use of "JDK" when describing a Java SE API - Initial clarifications related to zeros (trailing vs. Internal components) - Small typographical and grammatical enhancements - Indentation The complete Runtime.Version specification is available here: http://cr.openjdk.java.net/~iris/verona/8144062/doc.1/java/lang/Runtime.Ver… The old jdk.Version.current() was replaced with Runtime.version(). In System.getProperties(), we indicate which version-related system properties may be supported by Runtime.Version. The remaining jdk and langtools file changes are all side-effects of changing jdk.Version.current() to Runtime.version(). Thanks, Iris

5 8

Helpers for MethodHandles.byteArrayViewVarHandle VarHandle
by Jaroslav Kameník 19 May '16

19 May '16

Hi, what do you thing about adding helper methods for this kind of VarHandle? It would be nice to have something like Long.getFrom[LE/BE](byte[] arr, int index) // LE/BE -> endianity Long.setTo[LE/BE](long val, byte[] arr, int index) or Arrays.getLongFrom[LE/BE](byte[] arr, int index) Arrays.setLongTo[LE/BE](long val, byte[] arr, int index) Jaroslav

2 6

Review request for JDK-8156680: jdeps implementation refresh
by Mandy Chung 19 May '16

19 May '16

JDK-8156680: jdeps implementation refresh JDK-8153042: jdeps should continue to report JDK internal APIs that are removed/renamed in JDK 9 Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8156680/webrev.00/ This refactors the jdeps implementation that regression tests can be developed without the need to parse the output file. It also includes a list of the removed JDK internal APIs and provides the pointer where to look for more further information. JDK-8153481: tools/jdeps/modules/GenModuleInfo.java and ModuleTest.java fails intermittently Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8153481/webrev.00/ Mandy

2 9