July 2016 - core-libs-dev

JDK 9 RFR of JDK-8162746: VersionCheck.java failure after change for JDK-8160921
by Joseph D. Darcy 28 Jul '16

28 Jul '16

Hello, When the binary p2launcher was renamed to jweblauncher (JDK-8160921), the test tools/launcher/VersionCheck.java did not get the corresponding update and started failing. Please review the patch below to address this. Thanks, -Joe --- a/test/tools/launcher/VersionCheck.java Thu Jul 28 12:09:07 2016 -0700 +++ b/test/tools/launcher/VersionCheck.java Thu Jul 28 15:11:02 2016 -0700 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2007, 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2007, 2016, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,7 +23,7 @@ /** * @test - * @bug 6545058 6611182 8016209 8139986 + * @bug 6545058 6611182 8016209 8139986 8162746 * @summary validate and test -version, -fullversion, and internal, as well as * sanity checks if a tool can be launched. * @compile VersionCheck.java @@ -56,7 +56,7 @@ "jcontrol", "jmc", "jmc.ini", - "jp2launcher", + "jweblauncher", "jvisualvm", "packager", "ssvagent", @@ -93,11 +93,11 @@ "jps", "jrunscript", "jjs", - "jp2launcher", "jsadebugd", "jstack", "jstat", "jstatd", + "jweblauncher", "jvisualvm", "keytool", "kinit",

2 1

RFR: 8158295 Add a multi-release jar validation mechanism to jar tool
by Steve Drach 28 Jul '16

28 Jul '16

Hi, Please review the following: webrev: http://cr.openjdk.java.net/~sdrach/8158295/webrev.01/ <http://cr.openjdk.java.net/~sdrach/8158295/webrev.01/> issue: https://bugs.openjdk.java.net/browse/JDK-8158295 <https://bugs.openjdk.java.net/browse/JDK-8158295> This changeset adds a multi-release jar validator to jar tool. After the jar tool builds a multi-release jar, the potential resultant jar file is passed to the validator to assure that the jar file meets the minimal standards of a multi-release jar, in particular that versioned classes have the same api as base classes they override. There are other checks, for example warning if two classes are identical. If the jar file is invalid, it is not kept, so —create will not produce a jar file and —update will keep the input jar file. Thanks Steve

3 10

RFR [9] 8134779 & 8134847: Minor usability issues with the jmod tool
by Chris Hegarty 28 Jul '16

28 Jul '16

This is a minor change for a couple of usability issues with the jmod tool. It now issues a warning when it encounters duplicate entries, or an out of place module-info.class. http://cr.openjdk.java.net/~chegar/8134779_8134847/ https://bugs.openjdk.java.net/browse/JDK-8134779 https://bugs.openjdk.java.net/browse/JDK-8134847 -Chris.

2 1

RFR [9] 8156824: com.sun.jndi.ldap.pool.PoolCleaner should clear its context class loader
by Chris Hegarty 28 Jul '16

28 Jul '16

Another issue where an internal platform thread is unnecessarily retaining a reference to its creating thread’s context class loader. In this case, it appears to be safe to use an InnocuousThread, which will have a null context class loader. http://cr.openjdk.java.net/~chegar/8156824/01/ https://bugs.openjdk.java.net/browse/JDK-8156824 It’s not clear to me why the construction was not always in a privileged block, maybe “modifyThread” was assumed. We now definitely need a privileged block as the context class loader is being set. -Chris.

3 4

RFR [9] 8160513: ClassNotFoundException sun.misc.GC when running Tomcat 9 with JDK 9
by Chris Hegarty 28 Jul '16

28 Jul '16

The GC.Daemon thread has no need of any user defined class loader, so should set its context class loader to null before starting, so as to not inadvertently retain a reference to the creating thread’s context class loader. http://cr.openjdk.java.net/~chegar/8160513/ https://bugs.openjdk.java.net/browse/JDK-8160513 -Chris. P.S. I added a detailed comment the JIRA issue, for those wondering why Tomcat is running into this.

4 8

RFR: 8160605: java/util/SplittableRandom/SplittableRandomTest.java failed with timeout
by Martin Buchholz 28 Jul '16

28 Jul '16

Hi Paul, This deletes the testng ports of jsr166 tck random tests. If you can remember doing any work worth keeping, other than explicitly testing -Djava.util.secureRandomSeed=true (which we are adding to our tck tests), let me know. http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-RandomTests/

2 1

RFR: 8162563: Fix double checked locking in System.console()
by Martin Buchholz 28 Jul '16

28 Jul '16

Hi Xueming, I'd like you to do a wee code review, http://cr.openjdk.java.net/~martin/webrevs/openjdk9/Console-double-checked-…

4 8

JDK 9 RFR of JDK-8162666: Mark ValidationWarningsTest.java as intermittently failing
by Joseph D. Darcy 27 Jul '16

27 Jul '16

The test javax/xml/jaxp/unittest/common/ValidationWarningsTest.java is known to intermittently fail (JDK-8150145) and should be marked accordingly. Please review the patch below with does this (and removes an unnecessary space from the TEST.ROOT file). Thanks, -Joe --- a/test/TEST.ROOT Wed Jul 27 18:23:04 2016 +0300 +++ b/test/TEST.ROOT Wed Jul 27 15:07:26 2016 -0700 @@ -15,7 +15,7 @@ othervm.dirs=javax/xml/jaxp # Group definitions -groups=TEST.groups +groups=TEST.groups # Minimum jtreg version requiredVersion=4.2 b02 diff -r 794a2f7c2bb6 test/javax/xml/jaxp/unittest/common/ValidationWarningsTest.java --- a/test/javax/xml/jaxp/unittest/common/ValidationWarningsTest.java Wed Jul 27 18:23:04 2016 +0300 +++ b/test/javax/xml/jaxp/unittest/common/ValidationWarningsTest.java Wed Jul 27 15:07:26 2016 -0700 @@ -38,8 +38,9 @@ /* * @test + * @bug 8144593 + * @key intermittent * @modules javax.xml/com.sun.org.apache.xerces.internal.jaxp - * @bug 8144593 * @summary Check that warnings about unsupported properties from SAX * parsers are suppressed during the xml validation process. */

2 1

RFR (JAXP) 8158084: Catalog API: JAXP XML Processor Support
by huizhe wang 27 Jul '16

27 Jul '16

Hi, This is an enhancement to support the Catalog API (javax.xml.catalog) throughout the JAXP processors. All of the CatalogFeatures are supported by the JAXP factories and processors (e.g. SAXParser), and corresponding System properties as specified in the CatalogFeatures. An additional javax.xml property "USE_CATALOG" is added to allow switching on/off the Catalog support for a processor or all of them (through the System properties or jaxp.properties). The USE_CATALOG feature is on by default for all processors. The only thing needed then, to resolve external references with a catalog, is setting the path to the catalog on the processor. While the USE_CATALOG is on by default, the Catalog support is noninterference. As long as no catalog is set, the Catalog is mute. Catalog, even if one exists, will not interfere with custom resolvers, it is simply ignored if a custom resolver is present. specdiff: http://cr.openjdk.java.net/~joehw/jdk9/8158084/specdiff/overview-summary.ht… webrev: http://cr.openjdk.java.net/~joehw/jdk9/8158084/webrev/ Tests: 140ish new test cases; all existing SQE/unit tests pass. JCK has a large number of failures due to one Catalog API test that left a configuration file behind. I'll discuss that with the JCK team. Thanks, Joe

4 4

JDK 9 RFR of 8161402: Provide a javadoc description for java.prefs module
by Brian Burkhalter 26 Jul '16

26 Jul '16

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8161402 Patch: [1] Thanks, Brian [1] diff --- a/src/java.prefs/share/classes/module-info.java +++ b/src/java.prefs/share/classes/module-info.java @@ -23,6 +23,10 @@ * questions. */ +/** + * java.prefs defines and exports the preferences APIs of the Java SE platform. + */ + module java.prefs { requires java.xml;

7 19