July 2016 - core-libs-dev

RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED
by David Holmes 19 Jul '16

19 Jul '16

The bug report for this is confidential but quite simply all of the little tweaks and knobs we added to the open build and source files to support the Java SE Embedded product no longer need to be there for JDK 9. Many of them have already been removed via other changes but this cleans up the rest. webrev: http://cr.openjdk.java.net/~dholmes/8140723/webrev.jdk/ The changes relate to: - Java version information - isEmbedded() check in test code Platform.java - special AWT build settings for Embedded - special Toolkit handling for Embedded In make/lib/Awt2dLibraries.gmk I commented out a setting which was seemingly introduced only to support (old) embedded releases: # decimal constant is unsigned only in ISO C90 (JAVASE_EMBEDDED) BUILD_LIBAWT_XAWT_XToolkit.c_CFLAGS := -w which I think pertained to: #define DEF_AWT_MAX_POLL_TIMEOUT ((uint32_t)4000000000) Unless AWT folk indicate otherwise I will delete those two lines in final push. Thanks, David -----

4 7

8161129 Unsafe::getUnsafe should allow the platform class loader to access it
by Paul Sandoz 19 Jul '16

19 Jul '16

Hi, Please review the patch below. Since Jigsaw encapsulates jdk.internal.misc.Unsafe there is no need to perform any runtime checks such as: - hiding the getUnsafe method from reflection; and - checking the class loader of the calling class for invocation of getUnsafe. This more cleanly enables qualified modules to utilise the internal Unsafe without reflection gymnastics, even though we should be reviewing that usage and to reduce it where possible. I also took the opportunity to hide the “theInternalUnsafe” field in the sun.misc.Unsafe. That just avoids any futile attempts to obtain the field’s value after which any reflective access on that value will fail. Paul. diff -r 4f5f82c457af src/java.base/share/classes/jdk/internal/misc/Unsafe.java --- a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java Mon Jul 18 13:13:52 2016 +0800 +++ b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java Mon Jul 18 17:50:20 2016 +0200 @@ -26,8 +26,6 @@ package jdk.internal.misc; import jdk.internal.HotSpotIntrinsicCandidate; -import jdk.internal.reflect.CallerSensitive; -import jdk.internal.reflect.Reflection; import jdk.internal.vm.annotation.ForceInline; import java.lang.reflect.Field; @@ -57,7 +55,6 @@ private static native void registerNatives(); static { registerNatives(); - Reflection.registerMethodsToFilter(Unsafe.class, "getUnsafe"); } private Unsafe() {} @@ -87,16 +84,8 @@ * }}</pre> * * (It may assist compilers to make the local variable {@code final}.) - * - * @throws SecurityException if the class loader of the caller - * class is not in the system domain in which all permissions - * are granted. */ - @CallerSensitive public static Unsafe getUnsafe() { - Class<?> caller = Reflection.getCallerClass(); - if (!VM.isSystemDomainLoader(caller.getClassLoader())) - throw new SecurityException("Unsafe"); return theUnsafe; } diff -r 4f5f82c457af src/jdk.unsupported/share/classes/sun/misc/Unsafe.java --- a/src/jdk.unsupported/share/classes/sun/misc/Unsafe.java Mon Jul 18 13:13:52 2016 +0800 +++ b/src/jdk.unsupported/share/classes/sun/misc/Unsafe.java Mon Jul 18 17:50:20 2016 +0200 @@ -56,6 +56,7 @@ static { Reflection.registerMethodsToFilter(Unsafe.class, "getUnsafe"); + Reflection.registerFieldsToFilter(Unsafe.class, "theInternalUnsafe"); } private Unsafe() {}

6 9

JDK 9 RFR of JDK-8161567: Mark java/util/concurrent/forkjoin/FJExceptionTableLeak.java as intermittently failing
by Amy Lu 19 Jul '16

19 Jul '16

java/util/concurrent/forkjoin/FJExceptionTableLeak.java Test was ever fixed in JDK-8144990, but still failing intermittently as reported in JDK-8151158. This patch is to add back @key intermittent to the test. (and keep it in tier2 till issue resolved.) Please review. bug: https://bugs.openjdk.java.net/browse/JDK-8161567 webrev: http://cr.openjdk.java.net/~amlu/8161567/webrev.00/ Thanks, Amy --- old/test/java/util/concurrent/forkjoin/FJExceptionTableLeak.java 2016-07-18 14:37:25.000000000 +0800 +++ new/test/java/util/concurrent/forkjoin/FJExceptionTableLeak.java 2016-07-18 14:37:25.000000000 +0800 @@ -35,6 +35,7 @@ * @test * @author Doug Lea * @bug 8004138 + * @key intermittent * @summary Check if ForkJoinPool table leaks thrown exceptions. * @run main/othervm -Xmx8m -Djava.util.concurrent.ForkJoinPool.common.parallelism=4 FJExceptionTableLeak */

4 4

JDK 9 RFR of JDK-8161500: Use getTypeName and StringJoiner in core reflection toString methods
by Joseph D. Darcy 18 Jul '16

18 Jul '16

Hello, Please review this straightforward cleanup of some of the core reflection implementation classes: JDK-8161500: Use getTypeName and StringJoiner in core reflection toString methods http://cr.openjdk.java.net/~darcy/8161500.1/ All java/lang/Class and java/lang/reflect regression tests pass with this patch. (If the fix for JDK-8054213: "Class name repeated in output of Type.toString()" is pushed before this fix, a simple merge will be needed.) Thanks, -Joe

3 2

[9] RFR: 8159214: jlink --include-locales problems
by Naoto Sato 18 Jul '16

18 Jul '16

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8159214 The fix is located at: http://cr.openjdk.java.net/~naoto/8159214/webrev.04/ Naoto

2 2

RFR(XXXXXXXS): 8161034 Incorrect GPL header in jdk/src/java.base/windows/native/libjava/jni_util_md.c
by frederic parain 18 Jul '16

18 Jul '16

Hello, src/java.base/windows/native/libjava/jni_util_md.c file contains incorrect GPL header which fails make/scripts/lic_check.sh script check. Failure is caused by missing comma after modification years. Please, help to review its addition: http://cr.openjdk.java.net/~fparain/8161034/webrev.00/ lic_check.sh passes after this modification: ### Checking copyright notice in the file: jdk/src/java.base/windows/native/libjava/jni_util_md.c ### SUCCESS: The license header for /export/fparain/WORK/JDK9/8161034/hs/jdk/src/java.base/windows/native/libjava/jni_util_md.c has been verified. ### Thank you, Fred

2 2

RFR(S): 8161212: Test times out: java/lang/invoke/LoopCombinatorLongSignatureTest.java
by Michael Haupt 18 Jul '16

18 Jul '16

Dear all, please review this fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8161212 Webrev: http://cr.openjdk.java.net/~mhaupt/8161212/webrev.00/ Running the test in LambdaForm interpretation mode takes a long time. As the test is actually about capturing excessively long loop clause lists, running the constructed loop should be optional. The fix disables running the loop by default and introduces a -run option that can be used if the loop should actually be run. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment

2 2

Breakages in jdk9/dev
by David Holmes 18 Jul '16

18 Jul '16

FYI: It appears some changes in the JDK are exposing some bugs in the JVM. The following crash appears on OSX, and can happen during the build process: https://bugs.openjdk.java.net/browse/JDK-8155781 The following runtime crash may also be seen on 64-bit: https://bugs.openjdk.java.net/browse/JDK-8161550 David

1 0

[doc-only] JDK 9 RFR of 8161455: Missing word in API documentation
by Brian Burkhalter 15 Jul '16

15 Jul '16

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8161455 Patch: [1] Thanks, Brian [1] diff --- a/src/java.base/share/classes/java/nio/file/Files.java +++ b/src/java.base/share/classes/java/nio/file/Files.java @@ -3290,8 +3290,8 @@ * a size of {@code 0}. All bytes in the byte array are written to the file. * The method ensures that the file is closed when all bytes have been * written (or an I/O error or other runtime exception is thrown). If an I/O - * error occurs then it may do so after the file has created or truncated, - * or after some bytes have been written to the file. + * error occurs then it may do so after the file has been created or + * truncated, or after some bytes have been written to the file. * * Usage example: By default the method creates a new file or * overwrites an existing file. Suppose you instead want to append bytes @@ -3360,7 +3360,8 @@ * a size of {@code 0}. The method ensures that the file is closed when all * lines have been written (or an I/O error or other runtime exception is * thrown). If an I/O error occurs then it may do so after the file has - * created or truncated, or after some bytes have been written to the file. + * been created or truncated, or after some bytes have been written to the + * file. * * @param path * the path to the file

3 2

JDK 9 RFR of 8161413: Math.fma javadoc doesn't have @since 9 [doc-only]
by Brian Burkhalter 15 Jul '16

15 Jul '16

Please review @ your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8161413 Patch: [1] Thanks, Brian [1] diff --- a/src/java.base/share/classes/java/lang/Math.java +++ b/src/java.base/share/classes/java/lang/Math.java @@ -1613,6 +1613,8 @@ * @return (a × b + c) * computed, as if with unlimited range and precision, and rounded * once to the nearest {@code double} value + * + * @since 9 */ // @HotSpotIntrinsicCandidate public static double fma(double a, double b, double c) { @@ -1728,6 +1730,8 @@ * @return (a × b + c) * computed, as if with unlimited range and precision, and rounded * once to the nearest {@code float} value + * + * @since 9 */ // @HotSpotIntrinsicCandidate public static float fma(float a, float b, float c) { --- a/src/java.base/share/classes/java/lang/StrictMath.java +++ b/src/java.base/share/classes/java/lang/StrictMath.java @@ -1276,6 +1276,8 @@ * @return (a × b + c) * computed, as if with unlimited range and precision, and rounded * once to the nearest {@code double} value + * + * @since 9 */ public static double fma(double a, double b, double c) { return Math.fma(a, b, c); @@ -1328,6 +1330,8 @@ * @return (a × b + c) * computed, as if with unlimited range and precision, and rounded * once to the nearest {@code float} value + * + * @since 9 */ public static float fma(float a, float b, float c) { return Math.fma(a, b, c);

2 1