July 2016 - core-libs-dev

RFR 8054213: Class name repeated in output of Type.toString()
by Svetlana Nikandrova 15 Jul '16

15 Jul '16

Hello, could you please review this fix for toString() method of ParameterizedTypeImpl. The problem is that when we obtain simple name of nested type shared prefix is only removed for ParameterizedType owner. We need to remove it for other cases too. Please note that I also changed delimiter between outer and inner class from "." to "$". I believe as "$" is usually used to separate nested class name "." looks inconsistent and confusing. Let me know if you have any objections. Webrev: http://cr.openjdk.java.net/~msolovie/8054213/webrev.00/ <http://cr.openjdk.java.net/%7Emsolovie/8054213/webrev.00/> Issue: https://bugs.openjdk.java.net/browse/JDK-8054213 Thank you, Svetlana

2 9

RFR: 8159684: (tz) Support tzdata2016f
by Ramanand Patil 15 Jul '16

15 Jul '16

Hi all, Please review the latest TZDATA integration (tzdata2016f) to JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8159684 Webrev: http://cr.openjdk.java.net/~rpatil/8159684/webrev.00/ All the TimeZone related tests are passed after this integration. Regards, Ramanand.

2 2

Fwd: RFR 8161426: Test java/util/zip/InflaterInputStream/TestAvailable.java fails on open-only linux
by Brian Burkhalter 14 Jul '16

14 Jul '16

HI Sherman, Approved. I should have caught that myself yesterday: I’ve made that same mistake in the past. Brian On Jul 14, 2016, at 2:45 PM, Xueming Shen <xueming.shen(a)oracle.com> wrote: > Would you please help review the change for JDK-8161426. The test case > I pushed back yesterday fails in corner case when the Random.nextInt(n) > returns 0, in which we have a 0-length data/src byte[]. > > issue: https://bugs.openjdk.java.net/browse/JDK-8161426 > webrev: http://cr.openjdk.java.net/~sherman/8161426/webrev

1 0

RFR 8161426: Test java/util/zip/InflaterInputStream/TestAvailable.java fails on open-only linux
by Xueming Shen 14 Jul '16

14 Jul '16

Brian, Would you please help review the change for JDK-8161426. The test case I pushed back yesterday fails in corner case when the Random.nextInt(n) returns 0, in which we have a 0-length data/src byte[]. issue: https://bugs.openjdk.java.net/browse/JDK-8161426 webrev: http://cr.openjdk.java.net/~sherman/8161426/webrev Thanks, Sherman

1 0

RFR: 9: 8161011: Mark test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java as itnermittent
by Rajan Halade 14 Jul '16

14 Jul '16

This test is seen to fail intermittently due to JDK-8085192. Please review following patch which marks it as intermittent. diff -r 848c94ca6394 test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java --- a/test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java Thu Jul 07 14:16:58 2016 -0700 +++ b/test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java Thu Jul 07 15:55:14 2016 -0700 @@ -24,6 +24,7 @@ /* * @test * @bug 4510355 + * @key intermittent * @summary ActivationGroup implementations cannot be downloaded by default; * Creates a custom activation group without setting a security manager * in activation group's descriptor. The custom activation group Thanks, Rajan

3 3

JDK 9 RFR of JDK-8161347: Mark java/lang/ProcessBuilder/Zombies.java as intermittently failing
by Amy Lu 14 Jul '16

14 Jul '16

java/lang/ProcessBuilder/Zombies.java This test is known to fail intermittently (JDK-8160151), this patch is to mark the test accordingly with keyword 'intermittent'. (Note that this test has been demoted to tier2.) bug: https://bugs.openjdk.java.net/browse/JDK-8161347 webrev: http://cr.openjdk.java.net/~amlu/8161347/webrev.00/ Thanks, Amy --- old/test/java/lang/ProcessBuilder/Zombies.java 2016-07-14 13:50:10.000000000 +0800 +++ new/test/java/lang/ProcessBuilder/Zombies.java 2016-07-14 13:50:10.000000000 +0800 @@ -24,6 +24,7 @@ /* * @test * @bug 6474073 + * @key intermittent * @summary Make sure zombies don't get created on Unix * @author Martin Buchholz */

2 1

RFR(S): 8160564: TEST: Add a test to check the implementation of VersionProps.versionNumbers()
by Volker Simonis 14 Jul '16

14 Jul '16

Hi, can I please have a review for the following change which makes VersionProps.versionNumbers() testable and the corresponding regression test: http://cr.openjdk.java.net/~simonis/webrevs/2016/8160564/ https://bugs.openjdk.java.net/browse/JDK-8160564 During the review for "8160457: VersionProps.versionNumbers() is broken" it was suggested to refactor VersionProps.versionNumbers() in order to make it testable by a regression test. This change does exactly that. It extracts the implementation of VersionProps.versionNumbers() into a new method parseVersionNumbers(String versionNumber) which can be tested from the associated regression test. There are still two points to notice: - VersionProps.versionNumbers() deliberately doesn't check for badly formatted version strings because it is assumed it will only get valid input (see discussion for "JDK-8160000: Runtime.version() cause startup regressions" at [2]). So we can currently only check that VersionProps.versionNumbers() accepts all kind of valid version strings. - I was a little bit surprised that I could reflectively access and execute java.lang.VersionProps.parseVersionNumbers() where both the class and the method are package private. Maybe this is related to Jigsaw issue #ReflectiveAccessToNonExportedTypes [3]? As I'm not a Jigsaw expert, I'd be graceful to anybody explaining me why this is still so easily possible with Jigsaw? Thank you and best regards, Volker [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-June/042058.html [2] https://bugs.openjdk.java.net/browse/JDK-8160000 [3] http://openjdk.java.net/projects/jigsaw/spec/issues/#ReflectiveAccessToNonE…

8 21

RFR (JAXP): 8148350: Element.setAttributeNS() empty namespace does not throw exception
by Aleks Efimov 14 Jul '16

14 Jul '16

Hi, Please, help to review the fix for org.w3c.dom.Element#setAttributeNS method in JDK9: According to w3.org documentation empty string cannot be used as a namespace name [1]. Therefore the setAttributeNS [2] should raise DOMException (NAMESPACE_ERR) when namespaceURI is empty string (similar to null value). Webrev with proposed fix (regtest is included): http://cr.openjdk.java.net/~aefimov/8148350/9/00/ Best Regards, Aleksej [1] https://www.w3.org/TR/xml-names/#iri-use [2] https://docs.oracle.com/javase/8/docs/api/org/w3c/dom/Element.html#setAttri…

3 4

RFR JDK-7031075: GZIPInputStream's available() reports 1, but read() gives -1.
by Xueming Shen 13 Jul '16

13 Jul '16

Hi, Please help review the change for JDK-7031075. issue: https://bugs.openjdk.java.net/browse/JDK-7031075 webrev: http://cr.openjdk.java.net/~sherman/7031075/webrev This is a corner case in current implementation, in which the "readEOF" flag is only set when/after the read/skip method is invoked and the "eof" is "explicitly" reached. Which means even the inflater has reached the "end of the compressed stream" (inf.finished() == true) during the last read/skip invocation (since there are still data available, so the date gets read/returned successfully), the readEOF is not set, and therefor the available() return > 0 if checked. The proposed change here is to do an extra check of the inf.finished(), if it returns true, means there is no more data inside the inflater the end of compressed stream has been reached, available() returns true in this case. Thanks, Sherman

3 9

JEP 293: Guidelines for JDK Command-Line Tool Options
by mark.reinhold＠oracle.com 13 Jul '16

13 Jul '16

New JEP Candidate: http://openjdk.java.net/jeps/293 - Mark

4 4