August 2016 - core-libs-dev

[PATCH] JDK-8155102: Process.toString could include pid, isAlive, exitStatus
by Andrey Dyachkov 05 Aug '16

05 Aug '16

Hello, I have added toString() method in Process.java. diff --git a/src/java.base/share/classes/java/lang/Process.java b/src/java.base/share/classes/java/lang/Process.java --- a/src/java.base/share/classes/java/lang/Process.java +++ b/src/java.base/share/classes/java/lang/Process.java @@ -548,5 +548,16 @@ return toHandle().descendants(); } + @Override + public String toString() { + boolean isAlive = this.isAlive(); + return new StringBuilder(this.getClass().getSimpleName()).append("[") + .append("running=").append(isAlive).append(", ") + .append(isAlive ? "pid=" : "exitCode=") + .append(isAlive ? this.getPid() : this.exitValue()) + .append("]") + .toString(); + } + }

2 6

Review request for JDK-8145545 : Typos in Javadoc of XmlAdapter
by Abhijit Roy 05 Aug '16

05 Aug '16

Hi all, Please review a fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8145545 Bug - Typos in Javadoc of XmlAdapter Webrev - http://cr.openjdk.java.net/~ntv/ababroy/8145545/webrev.00/ I have just rectified and modified those error. And moving forward it for review. Regards, Abhijit.

3 3

Re: RFR: JDK-8161230 - Create java.util.stream.Stream from Iterator / Enumeration
by Gregg Wonderly 05 Aug '16

05 Aug '16

Sent from my iPad > On Aug 4, 2016, at 11:18 PM, Alan Bateman <Alan.Bateman(a)oracle.com> wrote: > >> On 04/08/2016 10:33, Patrick Reinhart wrote: >> >> Hi Paul, >> >> I was quit busy lately and this comes a bit late, I guess you do not have less work ;-) >> >> On 15.07.2016 17:10, Paul Sandoz wrote: >>>> When I understand you correctly here we should concentrate on the public >>>> methods naming firstly? I initially was not sure, what a proper naming >>>> for the steams method was. It seem to me reasonable the way Stuart pointed >>>> them out on his first comment to name them something like this: >>>> >>>> Stream<URL> resources(String name) >>>> Stream<URL> systemResources(String name) >>>> >>>> >>>> Yes. >> I have a first proposal for the new methods and their documentation to start with the discussion about the actual API without the implementation jet: > The method names look right but I don't think `throws IOException` is needed. If overridden then the implementations could be truely lazy and the method will need to specify how stream operations will wrap the errors in UncheckedIOExceptions. > > For the initial sentence then it might be better to say that it "Returns a stream that loads the resources ...". I think that the use of the Stream should throw checked exceptions and these method invocations should only throw RuntimeException instances to make it clear that lazy implementations are expected. Gregg

1 0

RFR (JAXP) 8160069: RuntimeException thrown by XPathFactory::newInstance missing the cause
by Joe Wang 05 Aug '16

05 Aug '16

Hi, Please review the patch that sets the cause to the Exception: http://cr.openjdk.java.net/~joehw/jdk9/8160069/webrev/ Thanks, Joe

2 2

RFR(XS): 8162670: make of jtreg_tests fails if no tests are run, causing jprt test runs to also fail
by Chris Plummer 04 Aug '16

04 Aug '16

Hello, Please review this simple change: https://bugs.openjdk.java.net/browse/JDK-8162670 http://cr.openjdk.java.net/~cjplummer/8162670/webrev-00/ Note the copyright dates haven't been updated in this webrev, but I did update them locally after noticing that. Tested with jprt test case given in the CR, and also with a jprt run using "testset -hotspot" to make sure I didn't break anything. thanks, Chris

3 9

Re: RFR(S): 8162727 - Testbug: additional requires properties can't be used for filtering server vm in jdk jtreg tests
by Dmitrij Pochepko 04 Aug '16

04 Aug '16

Sure, now including core-libs-dev Thanks, Dmitrij On 29.07.2016 20:16, joe darcy wrote: > Hello, > > I also recommend sending this review request over to core-libs-dev > since it affect the jdk repo. > > Thanks, > > -Joe > > > On 7/29/2016 12:35 AM, Dmitry Fazunenko wrote: >> Hi Dmitrij, >> >> The change itself looks good. >> >> One note: this change adds a little overhead (a very little) for >> running tests in jdk repository, but it's required only for VM >> specific tests stored in jdk. As alternative of this change I can >> suggest moving VM specific tests from the 'jdk' to 'hotspot' >> repository. Perhaps, such massive update is too late for JDK9 time >> frame and could be done only in JDK10. >> So, if the changes depending on 8162727 are not so critical and could >> be deferred I would prefer to postpone this fix. >> >> Thanks, >> Dima >> >> >> On 29.07.2016 4:29, Vladimir Kozlov wrote: >>> It affects all groups. Should be reviewed on hotspot-dev. >>> >>> Thanks, >>> Vladimir >>> >>> On 7/28/16 10:19 AM, Dmitrij Pochepko wrote: >>>> Hi, >>>> >>>> please review small patch for 8162727 - Testbug: additional >>>> requires properties can't be used for filtering server vm in jdk >>>> jtreg tests >>>> >>>> A problem is that tests under jdk repo can't use additional jtreg >>>> requires properties(like vm.flavor to filter out client or server >>>> vm). The same functionality was introduced for hotspot repo as part >>>> of JDK-8154956. So, in order to filter tests using these additional >>>> properties a small fix is created. >>>> >>>> webrev: http://cr.openjdk.java.net/~dpochepk/8162727/webrev.01/ >>>> CR: https://bugs.openjdk.java.net/browse/JDK-8162727 >>>> >>>> Thanks, >>>> Dmitrij >> >

4 7

Why is there no Math.ceilDiv?
by Philipp Nowak 04 Aug '16

04 Aug '16

Hello, I hope this is the right place to ask this question. If it is not, I would kindly ask you to direct me to the correct place. I was wondering why there is no Math.ceilDiv() method, when a floorDiv() method got added in Java 8 through JDK-8023217 [1]. Is there any reason why such method did not get added with floorDiv(), and, if not, is there any process to request such a method? Best regards, Philipp Nowak [1] https://bugs.openjdk.java.net/browse/JDK-8023217

3 2

[jdk9] RFR (XXS): 8163180: Typos around @code javadoc tag usage
by Ivan Gerasimov 04 Aug '16

04 Aug '16

Hello! In a few places the @code javadoc tag misses the curly bracket. Would you please review a trivial fix? http://cr.openjdk.java.net/~igerasim/8163180/00/webrev/ With kind regards, Ivan

2 1

RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit tests
by Frank Yuan 04 Aug '16

04 Aug '16

Hi Would you like to review http://cr.openjdk.java.net/~fyuan/8067170/webrev.00/? Bug: https://bugs.openjdk.java.net/browse/JDK-8067170 In this change, I enabled security manager for JAXP unit tests with improving the implementation approach and fixing some defects. Now jaxp tests use TestNG annotation to enable security manager and apply policies combination, like the following example(this full example is at: http://cr.openjdk.java.net/~fyuan/8067170/webrev.00/test/javax/xml/jaxp/uni…) @Listeners({ jaxp.library.FilePolicy.class, jaxp.library.InternalAPIPolicy.class }) public class Bug8003147Test { There are also 2 additional patterns for some special cases: 1. JAXPTestUtilities.runWithTmpPermission(Runnable, Permission.) is used for some cases which require their own special permissions, e.g. http://cr.openjdk.java.net/~fyuan/8067170/webrev.00/test/javax/xml/jaxp/uni…. 2. JAXPTestUtilities.tryRunWithPolicyManager(Runnable, Permission.) is used for cases where some test methods need to be run with security manager and some others need to be run without security manager because they have different behaviors when having sm or not. E.g. http://cr.openjdk.java.net/~fyuan/8067170/webrev.00/test/javax/xml/jaxp/uni…. Such cases must run in single thread, all other cases don't require it, are thread safe. Btw, I moved internaltest into unittest because it's unnecessary to separate them. Thanks, Frank

5 27

HttpURLConnection.getResponseCode() documentation comment
by boris.x.shukhat＠barclays.com 03 Aug '16

03 Aug '16

To whom it may concern, This comment is about API documentation on HttpURLConnection.getResponseCode() and it is based on the implementation details as well. HttpURLConnection implementation caches response code that allows to repeatedly get a response code from HttpURLConnection even after disconnect() is called. If a response code had been cached before disconnect() was called then its value is returned. But if the return code has not been cached, it (under some circumstances) opens a connection and leaves it opened if disconnect() is not called again. If called in the loop multiple times this design potentially can cause connection leakage and it happens in open source library https://github.com/elastic/elasticsearch-metrics-reporter-java/blob/master/… lines 397-406 I do not think that it is reasonable to change the implementation at this point because it can break existing software but it has to be reflected in API help on HttpURLConnection.getResponseCode() that it can leave connection open and another disconnect() may need to be called. The problem can be reproduced by running the following code long enough and using ss Linux command (netstat command on Windows) to periodically monitor sockets with established connection. public class Test { public static void main(String...args) throws Exception { while(true) { URL url=new URL("..."); HttpURLConnection connection=(HttpURLConnection)url.openConnection(); connection.connect(); connection.disconnect(); int responseCode=connection.getResponseCode(); Thread.sleep(10); } } } Thanks, Boris Shukhat _______________________________________________ This message is for information purposes only, it is not a recommendation, advice, offer or solicitation to buy or sell a product or service nor an official confirmation of any transaction. It is directed at persons who are professionals and is not intended for retail customer use. Intended for recipient only. This message is subject to the terms at: www.barclays.com/emaildisclaimer. For important disclosures, please see: www.barclays.com/salesandtradingdisclaimer regarding market commentary from Barclays Sales and/or Trading, who are active market participants; and in respect of Barclays Research, including disclosures relating to specific issuers, please see http://publicresearch.barclays.com. _______________________________________________

1 0