August 2016 - core-libs-dev

JDK 9 RFR of JDK-8161024: Remove intermittent key from java/lang/Runtime/exec/LotsOfOutput.java
by Amy Lu 03 Aug '16

03 Aug '16

java/lang/Runtime/exec/LotsOfOutput.java This test was failing intermittently (JDK-8078582 JDK-8086117). Mentioned issues have been resolved and no open bug (no failure reported) till now. This patch is to remove @key intermittent from the test. bug: https://bugs.openjdk.java.net/browse/JDK-8161024 webrev: http://cr.openjdk.java.net/~amlu/8161024/webrev.00/ Thanks, Amy --- old/test/java/lang/Runtime/exec/LotsOfOutput.java 2016-08-03 15:47:45.000000000 +0800 +++ new/test/java/lang/Runtime/exec/LotsOfOutput.java 2016-08-03 15:47:45.000000000 +0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2016, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,7 +25,6 @@ * @test * @bug 4369826 8078582 * @summary Process with lots of output should not crash VM - * @key intermittent * @author kladko */

2 1

[8u] request for approval: "8152172: PPC64: Support AES intrinsics"
by Volker Simonis 03 Aug '16

03 Aug '16

Hi, could you please approve the backport of the following, mostly ppc64 change to jdk8u-dev: 8152172: PPC64: Support AES intrinsics Bug: https://bugs.openjdk.java.net/browse/JDK-8152172 Webrev: http://cr.openjdk.java.net/~simonis/webrevs/2016/8152172_8u_hs/ Webrev http://cr.openjdk.java.net/~simonis/webrevs/2016/8152172_8u_jdk/ Review: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-March/thre… URL:http://hg.openjdk.java.net/jdk9/hs-comp/jdk/rev/74bc7be0777b URL:http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/68394bf0a09f As you can see, the change consists of two parts - the main one in the hotpsot repo and a small part in the jdk repo. The jdk part applied cleanly to jdk8u (with the usual directory shuffling). The hotspot part required a small tweak, but only in the ppc-only part. This is because the feature detection for the AES instructions was already active in jdk9 when the original change was made but is not available in jdk8u until now. You can find the additional changes at the end of this mail for your convenience. The required shared changes cleanly apply to jdk8u. As Vladimir pointed out in a previous thread, shared Hotspot changes have to go through JPRT even in jdk8u-dev. So I need a sponsor to do that and synchronously push both parts. @Hiroshii: could you please verify that you are fine with the change? I've done some tests on Power8LE but just want to be sure this downport satisfies your needs as well. Thank you and best regards, Volker ===================== diff -r 15928d255046 src/cpu/ppc/vm/vm_version_ppc.cpp --- a/src/cpu/ppc/vm/vm_version_ppc.cpp Wed Jul 13 00:47:40 2016 -0700 +++ b/src/cpu/ppc/vm/vm_version_ppc.cpp Fri Jul 22 10:32:36 2016 +0200 @@ -452,6 +476,7 @@ a->popcntw(R7, R5); // code[7] -> popcntw a->fcfids(F3, F4); // code[8] -> fcfids a->vand(VR0, VR0, VR0); // code[9] -> vand + a->vcipher(VR0, VR1, VR2); // code[10] -> vcipher a->blr(); // Emit function to set one cache line to zero. Emit function descriptor and get pointer to it. @@ -495,6 +520,7 @@ if (code[feature_cntr++]) features |= popcntw_m; if (code[feature_cntr++]) features |= fcfids_m; if (code[feature_cntr++]) features |= vand_m; + if (code[feature_cntr++]) features |= vcipher_m; // Print the detection code. if (PrintAssembly) { diff -r 15928d255046 src/cpu/ppc/vm/vm_version_ppc.hpp --- a/src/cpu/ppc/vm/vm_version_ppc.hpp Wed Jul 13 00:47:40 2016 -0700 +++ b/src/cpu/ppc/vm/vm_version_ppc.hpp Fri Jul 22 10:32:36 2016 +0200 @@ -42,6 +42,7 @@ fcfids, vand, dcba, + vcipher, num_features // last entry to count features }; enum Feature_Flag_Set { @@ -56,6 +57,7 @@ fcfids_m = (1 << fcfids ), vand_m = (1 << vand ), dcba_m = (1 << dcba ), + vcipher_m = (1 << vcipher), all_features_m = -1 }; static int _features; @@ -83,6 +85,7 @@ static bool has_fcfids() { return (_features & fcfids_m) != 0; } static bool has_vand() { return (_features & vand_m) != 0; } static bool has_dcba() { return (_features & dcba_m) != 0; } + static bool has_vcipher() { return (_features & vcipher_m) != 0; } static const char* cpu_features() { return _features_str; }

2 4

JDK 9 RFR of JDK-8162817: Annotation toString output not reusable for source input
by joe darcy 02 Aug '16

02 Aug '16

As pointed out by recent core-libs-dev traffic ([1] [2]), the toString output for annotation objects cannot be directly reused as source input if the annotation values are any of: * Class values of array classes (uses JVM name) * Arrays (output uses brackets ("[]") rather than braces {"{}") In addition, there are problems with other situations including: * Strings don't have surrounding " characters. * Chars don't have surrounding ' charcters. * Long values outside of the int range don't have a "L" suffix. Please review the webrev for the change addressing these shortcomings: JDK-8162817: Annotation toString output not reusable for source input http://cr.openjdk.java.net/~darcy/8162817.1/ This change should cover 99 44/100 % of the annotation values that appear in practice; limited efforts were taken quoting characters in strings, etc. The basic approach is to introduce a family of overloaded toSourceString methods to wrap/filter different kinds of values coupled with methods to convert the various primitive arrays to Stream<String> for final processing by a shared method to surround an array by "{" and "}" and add comma separators as needed. Thanks, -Joe [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-July/042637.html [2] http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-July/042645.html

2 2

RFR 9: [TESTBUG] 8160151: java/lang/ProcessBuilder/Zombies.java failed with error "1 zombies!"
by Roger Riggs 02 Aug '16

02 Aug '16

Please review a test fix for an intermittently failing ProcessBuilder test. The test should be run in a separate vm so it only sees Zombies from processes it creates. When run in-process with jtreg, it may see Zombies from other processes created by jtreg. Additional diagnostic information is added as well in case of recurrence. The test is moved back to tier1. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-zombies-8160151/ Issue: https://bugs.openjdk.java.net/browse/JDK-8160151 Thanks, Roger

2 3

JDK 9 RFR of 8161970, 8157664: Remove 4 tools tests from ProblemList.txt
by Amy Lu 02 Aug '16

02 Aug '16

tools/jlink/JLinkOptimTest.java This test has been removed in JDK-8160829 sun/tools/jinfo/JInfoSanityTest.java sun/tools/jinfo/JInfoRunningProcessFlagTest.java sun/tools/jmap/heapconfig/JMapHeapConfigTest.java These tests have been removed in JDK-8155091 Please review the patch to delete these tests from ProblemList.txt. bug: https://bugs.openjdk.java.net/browse/JDK-8161970 https://bugs.openjdk.java.net/browse/JDK-8157664 webrev: http://cr.openjdk.java.net/~amlu/8161970-8157664/webrev.00/ Thanks, Amy --- old/test/ProblemList.txt 2016-08-02 13:44:34.000000000 +0800 +++ new/test/ProblemList.txt 2016-08-02 13:44:34.000000000 +0800 @@ -318,7 +318,7 @@ ############################################################################ -# jdk_tools +# core_tools tools/pack200/CommandLineTests.java 7143279,8059906 generic-all @@ -368,20 +368,14 @@ sun/tools/jcmd/TestJcmdSanity.java 8031482 windows-all -sun/tools/jmap/heapconfig/JMapHeapConfigTest.java 8072131,8132452 generic-all - sun/tools/jstatd/TestJstatdExternalRegistry.java 8046285 generic-all sun/tools/jps/TestJpsJar.java 8160923 generic-all sun/tools/jps/TestJpsJarRelative.java 6456333 generic-all -sun/tools/jinfo/JInfoRunningProcessFlagTest.java 6734748 generic-all - sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java 8057732 generic-all -sun/tools/jinfo/JInfoSanityTest.java 8059035 generic-all - demo/jvmti/compiledMethodLoad/CompiledMethodLoadTest.java 8151899 generic-all ############################################################################ @@ -391,9 +385,3 @@ com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java 8141370 linux-i586,macosx-all ############################################################################ - -# core_tools - -tools/jlink/JLinkOptimTest.java 8159264 generic-all - -############################################################################

3 2

RFR 8159487: Add JAVA_VERSION, OS_NAME, OS_ARCH properties in release file
by Sundararajan Athijegannathan 02 Aug '16

02 Aug '16

Please review http://cr.openjdk.java.net/~sundar/8159487/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8159487 OS_NAME, OS_ARCH, OS_VERSION properties are already added due to another fix. Just adding "JAVA_VERSION" and a test change to check these properties exist in release file. Thanks -Sundar

2 1

[9] RFR: 8162797: Code clean-up in IncludeLocalesPlugin
by Naoto Sato 02 Aug '16

02 Aug '16

Hello, Please review this small change for the bug: https://bugs.openjdk.java.net/browse/JDK-8162797 The fix is located at: http://cr.openjdk.java.net/~naoto/8162797/webrev.00/ Naoto

2 1

RFR: 8162439: Runtime.Version.parse needs fast-path for major versions
by Claes Redestad 01 Aug '16

01 Aug '16

Hi, please review this patch to address a startup regression due to use of Runtime.Version.parse("8") etc in JarFile, as introduced by JDK-8150680. This solution introduce a fast-path in case of what appears to be a single number is sent to Runtime.Version.parse to avoid initializing Runtime.VersionBuilder: Webrev: http://cr.openjdk.java.net/~redestad/8162439/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8162439 Passes all existing tests. Thanks! /Claes

3 6

RFR 8157135, Fix module dependencies javax/* EE tests
by Felix Yang 01 Aug '16

01 Aug '16

Hi all, please review the patch for some tests, which explicitly declare module dependencies to EE modules. Bug: https://bugs.openjdk.java.net/browse/JDK-8157135 Webrev: http://cr.openjdk.java.net/~xiaofeya/8157135/webrev.00/ This is a partial fix left by https://bugs.openjdk.java.net/browse/JDK-8155088. The fix had been hold off for a moment, to wait for new jtreg with resolved https://bugs.openjdk.java.net/browse/CODETOOLS-7901671. Otherwise those tests will be ignored silently. Thanks, Felix

2 1

RFR (JAXP): 8162598 XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace
by Langer, Christoph 01 Aug '16

01 Aug '16

Hi, please review my change for the XSLT namespace issue. Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8162598.1/ Bug: https://bugs.openjdk.java.net/browse/JDK-8162598 The issue has already been discussed in this thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-July/042525.html Apart from the real fix in LiteralElement.java, method translate(), I've done some further cleanups in a few places. @Joe: The cleanups collide with some places of your proposed change for https://bugs.openjdk.java.net/browse/JDK-8158084 where we'd like to do the same things. So we'll have to synchronize on pushing. I've also enhanced the test case "TransformerTest" and added a method which does a regression test for the bug reported. Thanks in advance for reviewing. Best regards Christoph

4 8