February 2017 - core-libs-dev

JDK 9 RFR of JDK-8175240: Problem list org/omg/CORBA/OrbPropertiesTest.java
by Amy Lu 20 Feb '17

20 Feb '17

org/omg/CORBA/OrbPropertiesTest.java This test changes the JDK under testing and may affect other tests (JDK-8175177). Please review this patch to put the test to problem list until issues addressed. bug: https://bugs.openjdk.java.net/browse/JDK-8175240 webrev: http://cr.openjdk.java.net/~amlu/8175240/webrev.00/ Thanks, Amy --- old/test/ProblemList.txt 2017-02-20 10:57:10.000000000 +0800 +++ new/test/ProblemList.txt 2017-02-20 10:57:10.000000000 +0800 @@ -310,4 +310,6 @@ javax/xml/ws/clientjar/TestWsImport.java 8173317 generic-all +org/omg/CORBA/OrbPropertiesTest.java 8175177 generic-all + ############################################################################

2 1

RFR JDK-8174996: jar leaves temporary file when exception occur in creating jar
by Xueming Shen 17 Feb '17

17 Feb '17

Hi, Please help review the change for issue: https://bugs.openjdk.java.net/browse/JDK-8174996 webrev: http://cr.openjdk.java.net/~sherman/8174996/webrev The cause/trigger of this "regression" is that the jdk9 jar implementation now builds the target jar file on a temporary file first and then copies it to the the target destination, after sanity check if any. Same as what the "update" operation has been implemented (which means this is A problem for "update" operation as well, if ZipException/IOException gets thrown in the middle of the operation the temporary file is left un-deleted. In case of "update" operation, the temp file is at the same directory as the existing target jar file, if the "jar" is not from the stdin). In fact, in releases before jdk9, even there is no temporary file left behind in this situation, the destination jar file is left as a "broken jar" without being deleted. So for the use scenario described in this issue report, with jdk 8 or earlier, command jar cf test.jar -C a test test will create a broken jar file "test.jar", after the exception thrown. So strictly speaking, this is a not really a "regression", but a bug in different form, though it is still desired to be addressed/fixed. Given the nature the temporary file, it is relatively hard to create a regression test to check/verify the remove of the temporary after the exception. I'm not adding an auto regression test for this fix, though the fix has been verified manually. Thanks, Sherman

2 2

rmid on Unix fails with Exception - maybe aftermath of JDK-8173607 ??
by Langer, Christoph 17 Feb '17

17 Feb '17

Hi Daniel, when starting "rmid" from current builds on Linux (and probably other Unix platforms as well) we are currently getting the exception below. It looks as if on that path libnio was not loaded and hence we're getting an UnsatisfiedLinkError. In UnixNativeDispatcher.java one can find a static initialization block which should do that, however, it needs elevated access. Maybe rmid is missing a permission for that? Any thoughts? Thanks & best regards Christoph ...>/jdk9-build-dir/images/jdk/bin/rmid Exception in thread "main" java.lang.UnsatisfiedLinkError: sun.nio.fs.UnixNativeDispatcher.getcwd()[B at java.base/sun.nio.fs.UnixNativeDispatcher.getcwd(Native Method) at java.base/sun.nio.fs.UnixFileSystem.<init>(UnixFileSystem.java:66) at java.base/sun.nio.fs.LinuxFileSystem.<init>(LinuxFileSystem.java:39) at java.base/sun.nio.fs.LinuxFileSystemProvider.newFileSystem(LinuxFileSystemProvider.java:46) at java.base/sun.nio.fs.LinuxFileSystemProvider.newFileSystem(LinuxFileSystemProvider.java:39) at java.base/sun.nio.fs.UnixFileSystemProvider.<init>(UnixFileSystemProvider.java:56) at java.base/sun.nio.fs.LinuxFileSystemProvider.<init>(LinuxFileSystemProvider.java:41) at java.base/sun.nio.fs.DefaultFileSystemProvider.create(DefaultFileSystemProvider.java:41) at java.base/java.io.FilePermission.<clinit>(FilePermission.java:206) at java.base/java.lang.SecurityManager.checkRead(SecurityManager.java:899) at java.base/java.io.File.exists(File.java:815) at java.base/java.lang.ClassLoader$2.run(ClassLoader.java:2513) at java.base/java.lang.ClassLoader$2.run(ClassLoader.java:2510) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/java.lang.ClassLoader.loadLibrary0(ClassLoader.java:2509) at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2478) at java.base/java.lang.Runtime.loadLibrary0(Runtime.java:873) at java.base/java.lang.System.loadLibrary(System.java:1818) at java.base/sun.nio.fs.UnixNativeDispatcher$1.run(UnixNativeDispatcher.java:611) at java.base/sun.nio.fs.UnixNativeDispatcher$1.run(UnixNativeDispatcher.java:609) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/sun.nio.fs.UnixNativeDispatcher.<clinit>(UnixNativeDispatcher.java:609) at java.base/sun.nio.fs.UnixFileSystem.<init>(UnixFileSystem.java:66) at java.base/sun.nio.fs.LinuxFileSystem.<init>(LinuxFileSystem.java:39) at java.base/sun.nio.fs.LinuxFileSystemProvider.newFileSystem(LinuxFileSystemProvider.java:46) at java.base/sun.nio.fs.LinuxFileSystemProvider.newFileSystem(LinuxFileSystemProvider.java:39) at java.base/sun.nio.fs.UnixFileSystemProvider.<init>(UnixFileSystemProvider.java:56) at java.base/sun.nio.fs.LinuxFileSystemProvider.<init>(LinuxFileSystemProvider.java:41) at java.base/sun.nio.fs.DefaultFileSystemProvider.create(DefaultFileSystemProvider.java:41) at java.base/java.nio.file.FileSystems.<clinit>(FileSystems.java:91) at java.base/java.nio.file.Paths.get(Paths.java:84) at java.base/jdk.internal.jimage.ImageReaderFactory.<clinit>(ImageReaderFactory.java:50) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/sun.net.www.protocol.jrt.JavaRuntimeURLConnection.<clinit>(JavaRuntimeURLConnection.java:59) at java.base/sun.net.www.protocol.jrt.Handler.openConnection(Handler.java:42) at java.base/java.net.URL.openConnection(URL.java:1049) at java.base/jdk.internal.module.SystemModuleFinder$ImageModuleReader.checkPermissionToConnect(SystemModuleFinder.java:287) at java.base/jdk.internal.module.SystemModuleFinder$ImageModuleReader.<init>(SystemModuleFinder.java:296) at java.base/jdk.internal.module.SystemModuleFinder$1.get(SystemModuleFinder.java:245) at java.base/jdk.internal.module.SystemModuleFinder$1.get(SystemModuleFinder.java:242) at java.base/jdk.internal.module.ModuleReferenceImpl.open(ModuleReferenceImpl.java:83) at java.base/jdk.internal.loader.BuiltinClassLoader.createModuleReader(BuiltinClassLoader.java:934) at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1719) at java.base/jdk.internal.loader.BuiltinClassLoader.moduleReaderFor(BuiltinClassLoader.java:926) at java.base/jdk.internal.loader.BuiltinClassLoader.access$100(BuiltinClassLoader.java:92) at java.base/jdk.internal.loader.BuiltinClassLoader$1.run(BuiltinClassLoader.java:356) at java.base/jdk.internal.loader.BuiltinClassLoader$1.run(BuiltinClassLoader.java:351) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/jdk.internal.loader.BuiltinClassLoader.findMiscResource(BuiltinClassLoader.java:350) at java.base/jdk.internal.loader.BuiltinClassLoader.findResources(BuiltinClassLoader.java:311) at java.base/jdk.internal.loader.BootLoader.findResources(BootLoader.java:156) at java.base/java.lang.ClassLoader.getResources(ClassLoader.java:1430) at java.base/java.lang.ClassLoader.getResources(ClassLoader.java:1428) at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1082) at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.access$1200(ServiceLoader.java:1004) at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator$1.run(ServiceLoader.java:1131) at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator$1.run(ServiceLoader.java:1130) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1133) at java.base/java.util.ServiceLoader$1.hasNext(ServiceLoader.java:1163) at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1258) at java.base/java.nio.channels.spi.SelectorProvider.loadProviderAsService(SelectorProvider.java:122) at java.base/java.nio.channels.spi.SelectorProvider.access$200(SelectorProvider.java:69) at java.base/java.nio.channels.spi.SelectorProvider$1.run(SelectorProvider.java:180) at java.base/java.nio.channels.spi.SelectorProvider$1.run(SelectorProvider.java:176) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/java.nio.channels.spi.SelectorProvider.provider(SelectorProvider.java:175) at java.base/java.lang.System.inheritedChannel(System.java:276) at java.rmi/sun.rmi.server.Activation$2.run(Activation.java:1960) at java.rmi/sun.rmi.server.Activation$2.run(Activation.java:1958) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.rmi/sun.rmi.server.Activation.main(Activation.java:1957)

5 10

JDK 10 RFR of JDK-8172928: Add doc link from System.identityHashCode to Object.hashCode
by Joseph D. Darcy 17 Feb '17

17 Feb '17

Hello, Please review the patch below to address JDK-8172928: Add doc link from System.identityHashCode to Object.hashCode Thanks, -Joe diff -r e405d4bf5c56 src/java.base/share/classes/java/lang/System.java --- a/src/java.base/share/classes/java/lang/System.java Tue Feb 14 16:56:12 2017 +0100 +++ b/src/java.base/share/classes/java/lang/System.java Thu Feb 16 18:26:54 2017 -0800 @@ -534,6 +534,8 @@ * @param x object for which the hashCode is to be calculated * @return the hashCode * @since 1.1 + * @see Object#hashCode + * @see java.util.Objects#hashCode(Object) */ @HotSpotIntrinsicCandidate public static native int identityHashCode(Object x);

3 2

JDK 9 RFR of JDK-8175062: Mark java/nio/channels/AsyncCloseAndInterrupt.java as intermittently failing
by Amy Lu 16 Feb '17

16 Feb '17

java/nio/channels/AsyncCloseAndInterrupt.java This test is known to fail intermittently (JDK-8172045), this patch is to mark the test accordingly with keyword 'intermittent'. Please review. bug: https://bugs.openjdk.java.net/browse/JDK-8175062 webrev: http://cr.openjdk.java.net/~amlu/8175062/webrev.00/ Thanks, Amy --- old/test/java/nio/channels/AsyncCloseAndInterrupt.java 2017-02-16 15:06:51.000000000 +0800 +++ new/test/java/nio/channels/AsyncCloseAndInterrupt.java 2017-02-16 15:06:51.000000000 +0800 @@ -25,6 +25,7 @@ * @bug 4460583 4470470 4840199 6419424 6710579 6596323 6824135 6395224 7142919 * 8151582 8068693 8153209 * @run main/othervm AsyncCloseAndInterrupt + * @key intermittent * @summary Comprehensive test of asynchronous closing and interruption * @author Mark Reinhold */

2 1

RFR [JAXP] [TESTBUG] JDK-8175043 Multiple jaxp tests failing across platforms
by Frank Yuan 16 Feb '17

16 Feb '17

Hi Max and All Would you like to review http://cr.openjdk.java.net/~fyuan/8175043/webrev.00/? Bug: https://bugs.openjdk.java.net/browse/JDK-8175043 Some JAXP tests are impacted by JDK-8168410, to fix the issue, I added the pull path name to the file name in the tests, and added a temporary FilePermission for the specified file names in XSLTFunctionsTest.java. To Max I didn't take your proposal because we do want to assign FilePermission for the specified userdir, not for ".". To avoid assigning potentially extra permission now or future, I used the explicit full file path in the test. Thanks Frank

3 4

RFR: 8174735 Update JAX-WS RI integration to latest version
by Roman Grigoriadi 16 Feb '17

16 Feb '17

Hi, Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo. JBS: https://bugs.openjdk.java.net/browse/JDK-8174735 Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8174735/00/ You can find change list in the description of JBS and its linked issues. Most diffs are for SAAJ-RI related to JDK-8166745 - remove dependencies on jdks Xerces internal classes. Thanks, Roman

7 17

[9] RFR: 8173390: Investigate SymbolTable in SAXParser
by Aleks Efimov 16 Feb '17

16 Feb '17

Hi, Please, help to review the change required by JAXWS-RI code [1]: SAXParser needs to reset internal SymbolTable to enable pooling of parsers in SAAJ-RI code. Latest version of JAXWS-RI code (that is currently under review [2]) doesn't provide a workaround to reset the symbol table (it was done to remove module dependency on Xerces internal classes). So the solution is to reset the SymbolTable during SAXParser reset. The webrev with the changes and simple test that reproduces SAAJ-RI behavior: http://cr.openjdk.java.net/~aefimov/8173390/9/00/ The fix was tested with all JDK/JCK (JAX[P|B|WS] related tests. No failures observed. Thank you, Aleksej [1] https://bugs.openjdk.java.net/browse/JDK-8173390 [2] http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-February/046386.h…

3 5

Review Request: JDK-8174694: improve error message shown when main class can't be loaded
by Vicente Romero 15 Feb '17

15 Feb '17

Hi, Please review the fix for bug [1]. The fix is improving an already existing error message. The public patch can be reached at [2] Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8174694 [2] http://cr.openjdk.java.net/~vromero/8174694/webrev.00/jdk.patch

4 10

RFR: JDK-8146299 - Disable rmic -Xnew
by Mark Sheppard 15 Feb '17

15 Feb '17

Hi please oblige and review the following change: http://cr.openjdk.java.net/~msheppar/8146299-II/webrev.03/ to address the issue: https://bugs.openjdk.java.net/browse/JDK-8146299 which is to disables a currently undocumented, and unsupported feature in rmic * the parsing of the commandline option -Xnew is commented out * a set of tests are disabled using the @ignore tag * the ProblemList.txt is amended accordingly regards Mark

5 7