February 2017 - core-libs-dev

RFR(s): 8174194: Several java/lang tests failing due to undeclared module dependencies.
by Sergei Kovalev 09 Feb '17

09 Feb '17

Hi Daniel, Thank you for review. > Hi Sergey, > > LFMultiThreadCachingTest.java > > Can you clarify the change in this file? > > jdk.management requires java.management - so if the test failed with > --limit-modules when it required jdk.management then it's not going to > pass if it is changed to require only java.management. > > Or is it that jdk.management was actually not required and the > test was passing all right because it only required java.management? Actually jdk.management is not required for this particular test. java.management module is enough to pass the test. > The other files look OK, I guess. > > best regards, > > -- daniel > > On 08/02/17 13:51, Sergei Kovalev wrote: > >/Hi Team, />//>/Please review small fix for test suite regarding module dependency. />//>/BugID: https://bugs.openjdk.java.net/browse/JDK-8174194 />/WebRev: http://cr.openjdk.java.net/~skovalev/8174194/webrev.00/ > <http://cr.openjdk.java.net/%7Eskovalev/8174194/webrev.00/> />// > -- With best regards, Sergei

3 3

JDK 9 RFR of JDK-8169903: Refactor spliterator traversing tests into a library
by Amy Lu 09 Feb '17

09 Feb '17

java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java java/util/Spliterator/SpliteratorCollisions.java Test functions in above tests are almost duplicate with functions in java/util/stream/SpliteratorTestHelper.java. Test can reuse test functions from SpliteratorTestHelper, but with it’s own DataProvider. Please review the patch for refactoring spliterator traversing tests. bug: https://bugs.openjdk.java.net/browse/JDK-8169903 webrev: http://cr.openjdk.java.net/~amlu/8169903/webrev.00/ SpliteratorTestHelper.java has a minor update, added one small testcase that originally from SpliteratorCollisions.testForEach. The two skipped tests in SpliteratorCollisions.java are now enabled back, as mentioned bug has already been fixed. 256 /* skip this test until 8013649 is fixed ... 268 */ This patch also brings back Integer.MAX_VALUE test data which requires big memory (and removed in JDK-8169838), in a separate test. Thanks, Amy

2 7

RFR JDK-8173777: Merge javac -Xmodule into javac--patch-module
by Jan Lahoda 08 Feb '17

08 Feb '17

Hi, I'd like to ask for a review of a patch that merges the -Xmodule: functionality into --patch-module. After this patch, the input source files are matched against modules patched with --patch-module, and are compiled as-if they were part of the module they are patching. (In the multi-module mode, patches for more than one module can be compiled, in the single-module mode, patches for only one module can be compiled.) Removal of the -Xmodule: option will need adjustments in several repositories, as tests in multiple repositories are currently using -Xmodule:, and also jtreg is using the option. The current patch hence preserves the existing -Xmodule: functionality, although the option is hidden and no longer announced in help. I think it would be good to push the javac/langtools change proposed below, and then continue with other repositories. The langtools patch is here: http://cr.openjdk.java.net/~jlahoda/8173777/langtools.00/ (note it also contains changes to jshell and javadoc). Proposed jdk repository changes are here: http://cr.openjdk.java.net/~jlahoda/8173777/jdk.00/ How does this look? Any feedback is welcome. Thanks, Jan

4 6

RFR: 8173898: StackWalker.walk throws InternalError if called from a constructor invoked through reflection.
by Daniel Fuchs 08 Feb '17

08 Feb '17

Hi, Please find below a simple fix for: 8173898: StackWalker.walk throws InternalError if called from a constructor invoked through reflection. https://bugs.openjdk.java.net/browse/JDK-8173898 http://cr.openjdk.java.net/~dfuchs/webrev_8173898/webrev.00/ best regards, -- daniel

4 12

RFR(s): 8174194: Several java/lang tests failing due to undeclared module dependencies.
by Sergei Kovalev 08 Feb '17

08 Feb '17

Hi Team, Please review small fix for test suite regarding module dependency. BugID: https://bugs.openjdk.java.net/browse/JDK-8174194 WebRev: http://cr.openjdk.java.net/~skovalev/8174194/webrev.00/ -- With best regards, Sergei

2 1

JDK 9: 8174128: [testbug] Remove implementation dependency from java.time TCK tests
by Roger Riggs 08 Feb '17

08 Feb '17

Please review minor changes to the java.time.tck tests to avoid the use of implementation details and the related opening of the modules. The testng directive to open needed modules is now specific to the java.time.test... tests. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-opens-8174128/ Thanks, Roger

3 2

RFR: JDK-8049375 - Extend how the org.omg.CORBA.ORB handles the search for orb.properties
by Mark Sheppard 08 Feb '17

08 Feb '17

Hi, please oblige and review the following changes to the corba component http://cr.openjdk.java.net/~msheppar/8049375/corba/webrev/ http://cr.openjdk.java.net/~msheppar/8049375/test/webrev/ which address the issue https://bugs.openjdk.java.net/browse/JDK-8049375 the JDK9 rt image has changed structure to include a conf directory. This will hold a component's properties file, if any, and as such the corba component has amended the locating of the properties file with a search in the ${java.home}/conf directory. regards Mark

3 6

RFR: 8173943: Change error reporting of LauncherHelper to include actual Error class name
by Ramanand Patil 07 Feb '17

07 Feb '17

Hi all, Please review the following trivial bug fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8173943 Webrev: http://cr.openjdk.java.net/~rpatil/8173943/webrev.00/ LinkageError message added by - https://bugs.openjdk.java.net/browse/JDK-8167063 is updated to include the Error Class name. Regards, Ramanand.

4 6

8057795: Update of the mimestypes.default for JAF
by Lance Andersen 07 Feb '17

07 Feb '17

Hi all, Attached is the diff to update the mimetypes.default for JAF. The standalone standalone JAF was updated with support for .png files some time ago. ——————— hg diff diff -r 7c829eba7814 src/java.activation/share/classes/META-INF/mimetypes.default --- a/src/java.activation/share/classes/META-INF/mimetypes.default Sat Feb 04 14:03:15 2017 -0500 +++ b/src/java.activation/share/classes/META-INF/mimetypes.default Tue Feb 07 14:23:23 2017 -0500 @@ -7,6 +7,7 @@ image/ief ief image/jpeg jpeg jpg jpe JPG image/tiff tiff tif +image/png png PNG image/x-xwindowdump xwd application/postscript ai eps ps application/rtf rtf ljanders-mac:jaxws ljanders$ —————————— Best, Lance <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com <mailto:Lance.Andersen@oracle.com>

3 4

RFR 8169313: SecurityException, java.xml.ws not granted NetPermission("getProxySelector")
by Lance Andersen 06 Feb '17

06 Feb '17

Hi all, Attached is the change to address 8169313 ———— hg diff diff -r 19aaaf6ee13e src/java.base/share/lib/security/default.policy --- a/src/java.base/share/lib/security/default.policy Sat Feb 04 14:04:28 2017 -0500 +++ b/src/java.base/share/lib/security/default.policy Mon Feb 06 12:07:39 2017 -0500 @@ -102,6 +102,8 @@ }; grant codeBase "jrt:/java.xml.ws" { + permission java.net.NetPermission + "getProxySelector"; permission java.lang.RuntimePermission "accessClassInPackage.com.sun.org.apache.xml.internal.resolver"; permission java.lang.RuntimePermission ljanders-mac:jdk ljanders$ ----------- <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com <mailto:Lance.Andersen@oracle.com>

3 2